Skip to contentSkip to conversation

drivers: sm7xxfb: Mark function as static in sm7xxfb.c

PATCH In review Rashika Kheria 3 participants 3 messages Dec 21, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: sm7xxfb: Mark function as static in sm7xxfb.c

Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not used outside this file.

This eliminates the following warning in sm7xxfb.c:
drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes]

---
 drivers/staging/sm7xxfb/sm7xxfb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm7xxfb/sm7xxfb.c +1 -1
index ba199ff..f08b216 100644
@@ -585,7 +585,7 @@ static void smtc_set_timing(struct smtcfb_info *sfb)
 	}
 }
 
-void smtcfb_setmode(struct smtcfb_info *sfb)
+static void smtcfb_setmode(struct smtcfb_info *sfb)
 {
 	switch (sfb->fb.var.bits_per_pixel) {
 	case 32:
Signature · 1 line
1.7.9.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rashika Kheria

Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not used outside this file.

This eliminates the following warning in sm7xxfb.c:
drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes]

Quoted 19 lines
 drivers/staging/sm7xxfb/sm7xxfb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm7xxfb/sm7xxfb.c +1 -1
index ba199ff..f08b216 100644
@@ -585,7 +585,7 @@ static void smtc_set_timing(struct smtcfb_info *sfb)
 	}
 }
 
-void smtcfb_setmode(struct smtcfb_info *sfb)
+static void smtcfb_setmode(struct smtcfb_info *sfb)
 {
 	switch (sfb->fb.var.bits_per_pixel) {
 	case 32:
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#2 lore raw
In reply to Rashika Kheria
Quoted 7 lines · Rashika Kheria

Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not used outside this file.

This eliminates the following warning in sm7xxfb.c:
drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes]

Quoted 18 lines
---
 drivers/staging/sm7xxfb/sm7xxfb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm7xxfb/sm7xxfb.c +1 -1
index ba199ff..f08b216 100644
@@ -585,7 +585,7 @@ static void smtc_set_timing(struct smtcfb_info *sfb)
 	}
 }
 
-void smtcfb_setmode(struct smtcfb_info *sfb)
+static void smtcfb_setmode(struct smtcfb_info *sfb)
 {
 	switch (sfb->fb.var.bits_per_pixel) {
 	case 32: