FireWire fixlet
Linus,
please pull from the tag "firewire-fix" at
git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git firewire-fix
to receive a one-liner fix/ revert. This reenables WRITE SAME over SBP-2 like in v3.8...v3.12 (or v3.8-rc1...v3.13-rc2 to be overly precise). Buggy targets which could malfunction when being subjected to this command are already sufficiently protected by a scsi_level check in sd + SCSI core.
Stefan Richter (1):
firewire: sbp2: bring back WRITE SAME support
drivers/firewire/sbp2.c | 1 - 1 file changed, 1 deletion(-)
Quoted 1 line
From
ce027ed98fd176710fb14be9d6015697b62436f0Mon Sep 17 00:00:00 2001
From: Stefan Richter <[email protected]>
Date: Sun, 15 Dec 2013 16:18:01 +0100
Subject: [PATCH] firewire: sbp2: bring back WRITE SAME support
Commit 54b2b50c20a6 "[SCSI] Disable WRITE SAME for RAID and virtual host adapter drivers" disabled WRITE SAME support for all SBP-2 attached targets. But as described in the changelog of commit b0ea5f19d3d8 "firewire: sbp2: allow WRITE SAME and REPORT SUPPORTED OPERATION CODES", it is not required to blacklist WRITE SAME.
Bring the feature back by reverting the sbp2.c hunk of commit 54b2b50c20a6.
--- drivers/firewire/sbp2.c | 1 - 1 file changed, 1 deletion(-)
drivers/firewire/sbp2.c +0 -1
@@ -1623,7 +1623,6 @@ static struct scsi_host_template scsi_driver_template = { .cmd_per_lun = 1, .can_queue = 1, .sdev_attrs = sbp2_scsi_sysfs_attrs, - .no_write_same = 1, };MODULE_AUTHOR ("Kristian Hoegsberg <[email protected]>" );
Signature · 3 lines
Stefan Richter -=====-===-= ==-- =-==- http://arcgraph.de/sr/