Skip to contentSkip to conversation

ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

PATCH New Noam Camus 3 participants 6 messages Dec 22, 2013 – May 1, 2014

lore
Share & tools
lore

Noam Camus

author
#0 lore raw

PATCH 2/29 ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Hi Thomas,
Yes it was intentionality.
I send only the ones that seem to me as generic.
Noam

On Dec 22, 2013 7:41 PM, Thomas Petazzoni <[email protected]> wrote:
Dear Noam Camus,

Quoted 8 lines · Noam Camus

fix 2 issues:
1) need to set .config, which normally it is at post patch hook
2) need to rsync *.old directories/files excluded by --cvs-exclude

---
 package/uclibc/uclibc.mk |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

You sent five patches to the Buildroot mailing list, but they are part of a 29 patch series. We did not receive the entire patch series.

Was this intentional?

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

#1 lore raw

PATCH 2/29 ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Dear Noam Camus,

Quoted 2 lines · Noam Camus

Yes it was intentionality.
I send only the ones that seem to me as generic.

Ah, ok. Done like you did, it looked like a "mistake", as people normally try to send complete patch series to the list. But anyway, we'll review your patches.

Thanks!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 2/29 ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Hi Thomas,

Is there anything I can do to help in applying those commits?

Noam
Note: at the moment only one out of five was applied.
-----Original Message-----
From: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com]
Sent: Monday, December 23, 2013 9:53 AM
To: Noam Camus
Cc: buildroot at busybox.net
Subject: Re: [Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Dear Noam Camus,

Quoted 2 lines · Noam Camus

Yes it was intentionality.
I send only the ones that seem to me as generic.

Ah, ok. Done like you did, it looked like a "mistake", as people normally try to send complete patch series to the list. But anyway, we'll review your patches.

Thanks!

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering http://free-electrons.com

#3 lore raw

PATCH 2/29 ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Dear Noam Camus,

Quoted 4 lines · Noam Camus

Is there anything I can do to help in applying those commits?

Noam
Note: at the moment only one out of five was applied.

Yes, I believe you could resend them, rebased on top of the current -next branch, in a patch series that only includes those patches (the fact that you sent only 5 patches, but they were number <something>/29 was quite confusing).

Also, make sure each of your commits has a long enough commit log to allow reviewers to understand what problem the commit is fixing, and how the solution works.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 2/29 ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Hi,

Quoted 9 lines · Thomas Petazzoni

Dear Noam Camus,

Quoted 4 lines · Noam Camus

Is there anything I can do to help in applying those commits?

Noam
Note: at the moment only one out of five was applied.

Quoted 8 lines

Yes, I believe you could resend them, rebased on top of the current -next branch, in a patch series that only includes those patches (the fact that you sent only 5 patches, but they were number <something>/29 was quite confusing).

Also, make sure each of your commits has a long enough commit log to allow reviewers to understand what problem the commit is fixing, and how the solution works.

This specific patch 02/29 (uClibc .config) is at least partially addressed in the meantime, with commit
http://git.buildroot.org/buildroot/commit/?id=a25df76b39863e5d1a4e927696bf83055e8ce244

Best regards,
Thomas

#5 lore raw

PATCH 2/29 ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Hi,

Quoted 18 lines · Thomas De Schampheleire

Hi,

Quoted 14 lines · Thomas Petazzoni

Dear Noam Camus,

Quoted 4 lines · Noam Camus

Is there anything I can do to help in applying those commits?

Noam
Note: at the moment only one out of five was applied.

Yes, I believe you could resend them, rebased on top of the current -next branch, in a patch series that only includes those patches (the fact that you sent only 5 patches, but they were number <something>/29 was quite confusing).

Quoted 7 lines
Quoted 3 lines

Also, make sure each of your commits has a long enough commit log to allow reviewers to understand what problem the commit is fixing, and how the solution works.

This specific patch 02/29 (uClibc .config) is at least partially addressed in the meantime, with commit
http://git.buildroot.org/buildroot/commit/?id=a25df76b39863e5d1a4e927696bf83055e8ce244

The second part of this patch should also be fixed now: we no longer use --cvs-exclude in the rsync step, but have an explicit list of version-controlled directories to exclude from the rsync. The pattern *.old is not in the exclusion list, so is copied from the overriden dir.

I'm therefore marking this patch as Superseded in patchwork. Do let me know if you think my analysis is not correct.

Best regards,
Thomas