bluez5_utils: new package

PATCH New Alexandre Belloni 3 participants 12 messages Dec 23, 2013 – Mar 7, 2014

lore

Share & tools

lore

Alexandre Belloni

author

2013-12-23 09:37 UTC #0 lore raw

PATCH 1/1 bluez5_utils: new package

Signed-off-by Alexandre Belloni <[email protected]>

---
 package/Config.in                                  |   1 +
 package/bluez5_utils/Config.in                     |  16 ++++
 .../bluez5_utils-5.12-enable_cg2900.patch          | 106 +++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk               |  31 ++++++
 package/bluez_utils/Config.in                      |   8 +-
 5 files changed, 161 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils-5.12-enable_cg2900.patch
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

package/Config.in +1 -0

index 490bef87a2eb..ff39f32b9b0b 100644
@@ -770,6 +770,7 @@ source "package/axel/Config.in"
 source "package/bcusdk/Config.in"
 source "package/bind/Config.in"
 source "package/bluez_utils/Config.in"
+source "package/bluez5_utils/Config.in"
 source "package/bmon/Config.in"
 source "package/boa/Config.in"
 source "package/bridge-utils/Config.in"

package/bluez5_utils/Config.in new file +16 -0

new file mode 100644
index 000000000000..f0a71125e2ad
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez5-utils"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2
+	depends on BR2_USE_MMU # dbus, libglib2
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	help
+	  bluez utils
+
+	  http://www.kernel.org/pub/linux/bluetooth
+
+comment "bluez5-utils needs a toolchain w/ wchar, threads"
+	depends on !BR2_avr32 && BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

package/bluez5_utils/bluez5_utils-5.12-enable_cg2900.patch new file +106 -0

106 lines not on this page · raw message

package/bluez5_utils/bluez5_utils.mk new file +31 -0

new file mode 100644
index 000000000000..23244221df80
@@ -0,0 +1,31 @@
+################################################################################
+#
+# bluez5_utils
+#
+################################################################################
+
+BLUEZ5_UTILS_VERSION = 5.12
+BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
+BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
+BLUEZ5_UTILS_INSTALL_STAGING = YES
+BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 readline libical
+BLUEZ5_UTILS_CONF_OPT = --enable-test --enable-tools --disable-android
+BLUEZ5_UTILS_AUTORECONF = YES
+BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
+BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
+
+ifeq ($(BR2_PACKAGE_UDEV),y)
+BLUEZ5_UTILS_CONF_OPT += --enable-udev
+BLUEZ5_UTILS_DEPENDENCIES += udev
+else
+BLUEZ5_UTILS_CONF_OPT += --disable-udev
+endif
+
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+BLUEZ5_UTILS_CONF_OPT += --enable-systemd
+BLUEZ5_UTILS_DEPENDENCIES += systemd
+else
+BLUEZ5_UTILS_CONF_OPT += --disable-systemd
+endif
+
+$(eval $(autotools-package))

package/bluez_utils/Config.in +7 -1

index 1315b9ef4166..a4ca3977d29d 100644
@@ -1,11 +1,14 @@
 config BR2_PACKAGE_BLUEZ_UTILS
 	bool "bluez-utils"
+	depends on !BR2_PACKAGE_BLUEZ5_UTILS
 	depends on !BR2_avr32
-	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_USE_WCHAR # libglib2, libical
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2
 	depends on BR2_USE_MMU # dbus, libglib2
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_READLINE
+	select BR2_PACKAGE_LIBICAL
 	help
 	  bluez utils

@@ -48,3 +51,6 @@ endif
 comment "bluez-utils needs a toolchain w/ wchar, threads"
 	depends on !BR2_avr32 && BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "bluez 4.x is not compatible with bluez 5.x"
+    depends on BR2_PACKAGE_BLUEZ5_UTILS

Signature · 1 line

1.8.3.2

Baruch Siach

2013-12-23 09:50 UTC #1 lore raw

PATCH 1/1 bluez5_utils: new package

Hi Alexandre,

Quoted 1 line · Alexandre Belloni

Signed-off-by Alexandre Belloni <[email protected]>

[...]

package/bluez5_utils/Config.in line 5

Quoted 11 lines

package/bluez5_utils/Config.in new file +5 -0

new file mode 100644
index 000000000000..f0a71125e2ad
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez5-utils"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2

Why alsa-lib?

baruch

Quoted 11 lines

package/bluez5_utils/Config.in new file +11 -0

+	depends on BR2_USE_MMU # dbus, libglib2
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	help
+	  bluez utils
+
+	  http://www.kernel.org/pub/linux/bluetooth
+
+comment "bluez5-utils needs a toolchain w/ wchar, threads"
+	depends on !BR2_avr32 && BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Alexandre Belloni

author

2013-12-23 09:54 UTC #2 lore raw

PATCH 1/1 bluez5_utils: new package

Quoted 13 lines · Baruch Siach

package/bluez5_utils/Config.in line 5

Quoted 12 lines

package/bluez5_utils/Config.in new file +5 -0

new file mode 100644
index 000000000000..f0a71125e2ad
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez5-utils"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2

Why alsa-lib?

Hum, right, it got copied from bluez-utils, I'll remove it

Signature · 3 lines

Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Baruch Siach

2013-12-23 09:57 UTC #3 lore raw

PATCH 1/1 bluez5_utils: new package

Hi Alexandre,

Quoted 14 lines · Alexandre Belloni

Quoted 4 lines · Baruch Siach
Quoted 4 lines
package/bluez5_utils/Config.in new file +0 -1
new file mode 100644
index 000000000000..f0a71125e2ad
--- /dev/null
Quoted 8 lines
package/bluez5_utils/Config.in line 5
Quoted 7 lines
+++ b/package/bluez5_utils/Config.in
package/bluez5_utils/Config.in new file +5 -0
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez5-utils"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2
Why alsa-lib?

Quoted 1 line

Hum, right, it got copied from bluez-utils, I'll remove it

Also, it seems that libglib2 doesn't need threads, only wchar.

baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Thomas Petazzoni

2013-12-23 10:11 UTC #4 lore raw

PATCH 1/1 bluez5_utils: new package

Dear Baruch Siach,

Quoted 3 lines · Baruch Siach

Quoted 1 line
Hum, right, it got copied from bluez-utils, I'll remove it
Also, it seems that libglib2 doesn't need threads, only wchar.

libglib2 does need thread support:

config BR2_PACKAGE_LIBGLIB2
bool "libglib2"
select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE select BR2_PACKAGE_LIBFFI
select BR2_PACKAGE_PCRE_UCP if BR2_PACKAGE_PCRE select BR2_PACKAGE_ZLIB
depends on BR2_USE_WCHAR # gettext depends on BR2_TOOLCHAIN_HAS_THREADS

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Alexandre Belloni

author

2013-12-23 10:16 UTC #5 lore raw

PATCH 1/1 bluez5_utils: new package

Quoted 8 lines · Thomas Petazzoni

Dear Baruch Siach,
Quoted 2 lines · Baruch Siach
Quoted 1 line
Hum, right, it got copied from bluez-utils, I'll remove it
Also, it seems that libglib2 doesn't need threads, only wchar.
libglib2 does need thread support:

Quoted 9 lines

config BR2_PACKAGE_LIBGLIB2
bool "libglib2"
select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE select BR2_PACKAGE_LIBFFI
select BR2_PACKAGE_PCRE_UCP if BR2_PACKAGE_PCRE select BR2_PACKAGE_ZLIB
depends on BR2_USE_WCHAR # gettext depends on BR2_TOOLCHAIN_HAS_THREADS

Yeah, anyway, my patch is doing less thant the one from Marcin last month so maybe we should focus on getting his in and we can drop mine...

Quoted 1 line

Thomas

Signature · 3 lines

Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Baruch Siach

2013-12-23 10:17 UTC #6 lore raw

PATCH 1/1 bluez5_utils: new package

In reply to Thomas Petazzoni

Hi Thomas,

Quoted 6 lines · Thomas Petazzoni

Quoted 3 lines · Baruch Siach
Quoted 1 line
Hum, right, it got copied from bluez-utils, I'll remove it
Also, it seems that libglib2 doesn't need threads, only wchar.
libglib2 does need thread support:

You're right. I looked in an old branch. Sorry for the noise.

baruch

Quoted 9 lines

config BR2_PACKAGE_LIBGLIB2
bool "libglib2"
select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE select BR2_PACKAGE_LIBFFI
select BR2_PACKAGE_PCRE_UCP if BR2_PACKAGE_PCRE select BR2_PACKAGE_ZLIB
depends on BR2_USE_WCHAR # gettext depends on BR2_TOOLCHAIN_HAS_THREADS

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Thomas Petazzoni

2013-12-23 09:50 UTC #7 lore raw

PATCH 1/1 bluez5_utils: new package

In reply to Alexandre Belloni

Dear Alexandre Belloni,

Quoted 11 lines · Alexandre Belloni

Signed-off-by Alexandre Belloni <[email protected]>

---
 package/Config.in                                  |   1 +
 package/bluez5_utils/Config.in                     |  16 ++++
 .../bluez5_utils-5.12-enable_cg2900.patch          | 106 +++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk               |  31 ++++++
 package/bluez_utils/Config.in                      |   8 +-
 5 files changed, 161 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils-5.12-enable_cg2900.patch
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

When you send a new version of a patch, please change the subject prefix to add "PATCH v2", and also include a changelog in your patch so that we know what changed between v1 and v2.

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2013-12-23 09:57 UTC #8 lore raw

PATCH 1/1 bluez5_utils: new package

Hello,

Quoted 13 lines · Thomas Petazzoni

Quoted 11 lines · Alexandre Belloni

Signed-off-by Alexandre Belloni <[email protected]>

---
 package/Config.in                                  |   1 +
 package/bluez5_utils/Config.in                     |  16 ++++
 .../bluez5_utils-5.12-enable_cg2900.patch          | 106 +++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk               |  31 ++++++
 package/bluez_utils/Config.in                      |   8 +-
 5 files changed, 161 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils-5.12-enable_cg2900.patch
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

Quoted 3 lines

When you send a new version of a patch, please change the subject prefix to add "PATCH v2", and also include a changelog in your patch so that we know what changed between v1 and v2.

My bad. The previous version of this patch was not sent by you, but by Marcin Bis, so your version is not really a v2.

Have you looked at Marcin Bis version to see if your version includes all of what Marcin did, if applicable?

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2014-03-07 22:56 UTC #9 lore raw

PATCH 1/1 bluez5_utils: new package

In reply to Alexandre Belloni

Dear Alexandre Belloni,

Quoted 11 lines · Alexandre Belloni

Signed-off-by Alexandre Belloni <[email protected]>

---
 package/Config.in                                  |   1 +
 package/bluez5_utils/Config.in                     |  16 ++++
 .../bluez5_utils-5.12-enable_cg2900.patch          | 106 +++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk               |  31 ++++++
 package/bluez_utils/Config.in                      |   8 +-
 5 files changed, 161 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils-5.12-enable_cg2900.patch
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

Can you resend an updated version of this patch, that takes into account the review comments you have received? It would be great to have bluez5_utils in Buildroot.

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Alexandre Belloni

author

2014-03-07 23:03 UTC #10 lore raw

PATCH 1/1 bluez5_utils: new package

Hi,

Quoted 15 lines · Thomas Petazzoni

Dear Alexandre Belloni,

Quoted 11 lines · Alexandre Belloni

Signed-off-by Alexandre Belloni <[email protected]>

---
 package/Config.in                                  |   1 +
 package/bluez5_utils/Config.in                     |  16 ++++
 .../bluez5_utils-5.12-enable_cg2900.patch          | 106 +++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk               |  31 ++++++
 package/bluez_utils/Config.in                      |   8 +-
 5 files changed, 161 insertions(+), 1 deletion(-)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils-5.12-enable_cg2900.patch
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

Quoted 4 lines

Can you resend an updated version of this patch, that takes into account the review comments you have received? It would be great to have bluez5_utils in Buildroot.

It may make sense to take the patch from Marcin as it is almost the same as mine Yann had a few comments on it this week:

http://lists.busybox.net/pipermail/buildroot/2014-March/091454.html

Signature · 3 lines

Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2014-03-07 23:09 UTC #11 lore raw

PATCH 1/1 bluez5_utils: new package

Dear Alexandre Belloni,

Quoted 8 lines · Alexandre Belloni

Quoted 3 lines
Can you resend an updated version of this patch, that takes into account the review comments you have received? It would be great to have bluez5_utils in Buildroot.
It may make sense to take the patch from Marcin as it is almost the same as mine Yann had a few comments on it this week:
http://lists.busybox.net/pipermail/buildroot/2014-March/091454.html

Then, can you sync with Marcin and see if any of you can resend an updated patch?

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com