debugfs: silence build warning and remove incorrect error message
PATCH 1/1 debugfs: silence build warning and remove incorrect error message
Commit fe56188b07 modified the code used to check the block number argument to the command line -s switch, adding a call to com_err(). This causes a compile time warning because the third argument to com_err() isn't a string. Also, when the block number argument is bad it outputs an incorrect error message - "Operation not permitted".
Fix these minor problems by removing the call to com_err(). Other code provides enough error reporting information in this case.
--- debugfs/debugfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
debugfs/debugfs.c +1 -3
@@ -2458,10 +2458,8 @@ int main(int argc, char **argv)break ;case 's' : retval =strtoblk (argv[0 ], optarg, &superblock); -if (retval) { -com_err (argv[0 ], retval,0 , debug_prog_name); +if (retval)return 1 ; - }break ;case 'c' : catastrophic =1 ;
Signature · 1 line
1.8.3.2
Theodore Ts'o
AppliedQuoted 10 lines · Eric Whitney
Commit
fe56188b07modified the code used to check the block number argument to the command line -s switch, adding a call tocom_err(). This causes a compile time warning because the third argument tocom_err()isn't a string. Also, when the block number argument is bad it outputs an incorrect error message - "Operation not permitted".Fix these minor problems by removing the call to
com_err(). Other code provides enough error reporting information in this case.Signed-off-by Eric Whitney <[email protected]>
Thanks, applied.
- Ted