Skip to contentSkip to conversation

e2fsprogs: Rename the first patch to match the naming policy.

PATCH New sonic.adi at gmail.com 5 participants 6 messages Nov 15, 2013 – Dec 25, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e2fsprogs: Rename the first patch to match the naming policy.

From: Sonic Zhang <[email protected]>

---
 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch | 11 +++++++++++
 package/e2fsprogs/e2fsprogs-sem-init-libs.patch      | 11 -----------
 2 files changed, 11 insertions(+), 11 deletions(-)
 create mode 100644 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch
 delete mode 100644 package/e2fsprogs/e2fsprogs-sem-init-libs.patch
package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch new file +11 -0
new file mode 100644
index 0000000..56f1cc2
@@ -0,0 +1,11 @@
+--- e2fsprogs-1.41.9/MCONFIG.in.orig	2009-10-07 20:25:07.000000000 +0800
++++ e2fsprogs-1.41.9/MCONFIG.in	2009-10-07 20:21:41.000000000 +0800
+@@ -85,7 +85,7 @@
+ #
+ LIB = $(top_builddir)/lib
+ LIBSS = $(LIB)/libss at LIB_EXT@ @PRIVATE_LIBS_CMT@ @DLOPEN_LIB@
+-LIBCOM_ERR = $(LIB)/libcom_err at LIB_EXT@ @PRIVATE_LIBS_CMT@ @SEM_INIT_LIB@
++LIBCOM_ERR = $(LIB)/libcom_err at LIB_EXT@ @SEM_INIT_LIB@
+ LIBE2P = $(LIB)/libe2p at LIB_EXT@
+ LIBEXT2FS = $(LIB)/libext2fs at LIB_EXT@
+ LIBUUID = @LIBUUID@ @SOCKET_LIB@
package/e2fsprogs/e2fsprogs-sem-init-libs.patch deleted +0 -11
deleted file mode 100644
index 56f1cc2..0000000
@@ -1,11 +0,0 @@
---- e2fsprogs-1.41.9/MCONFIG.in.orig	2009-10-07 20:25:07.000000000 +0800
-+++ e2fsprogs-1.41.9/MCONFIG.in	2009-10-07 20:21:41.000000000 +0800
-@@ -85,7 +85,7 @@
- #
- LIB = $(top_builddir)/lib
- LIBSS = $(LIB)/libss at LIB_EXT@ @PRIVATE_LIBS_CMT@ @DLOPEN_LIB@
--LIBCOM_ERR = $(LIB)/libcom_err at LIB_EXT@ @PRIVATE_LIBS_CMT@ @SEM_INIT_LIB@
-+LIBCOM_ERR = $(LIB)/libcom_err at LIB_EXT@ @SEM_INIT_LIB@
- LIBE2P = $(LIB)/libe2p at LIB_EXT@
- LIBEXT2FS = $(LIB)/libext2fs at LIB_EXT@
- LIBUUID = @LIBUUID@ @SOCKET_LIB@
Signature · 1 line
1.8.2.3
#1 lore raw

PATCH 1/1 e2fsprogs: Rename the first patch to match the naming policy.

Sonic, Thomas,

Quoted 9 lines · On Fri, Nov 15, 2013 at 10:30 AM, <[email protected]> wrote:

From: Sonic Zhang <[email protected]>

---
 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch | 11 +++++++++++
 package/e2fsprogs/e2fsprogs-sem-init-libs.patch      | 11 -----------
 2 files changed, 11 insertions(+), 11 deletions(-)
 create mode 100644 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch
 delete mode 100644 package/e2fsprogs/e2fsprogs-sem-init-libs.patch

Also here I wonder why git/git-format-patch did not recognize the move?

Best regards,
Thomas

#2 lore raw

PATCH 1/1 e2fsprogs: Rename the first patch to match the naming policy.

Dear Thomas De Schampheleire,

Quoted 7 lines · Thomas De Schampheleire
Quoted 5 lines
 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch | 11 +++++++++++
 package/e2fsprogs/e2fsprogs-sem-init-libs.patch      | 11 -----------
 2 files changed, 11 insertions(+), 11 deletions(-)
 create mode 100644 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch
 delete mode 100644 package/e2fsprogs/e2fsprogs-sem-init-libs.patch

Also here I wonder why git/git-format-patch did not recognize the move?

Because you need to explicitly do a 'git format-patch -M', or configure Git in your ~/.gitconfig to enable rename detection permanently.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 e2fsprogs: Rename the first patch to match the naming policy.

Quoted 10 lines · Thomas Petazzoni

Dear Thomas De Schampheleire,

Quoted 6 lines · Thomas De Schampheleire
Quoted 5 lines
  package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch | 11 +++++++++++
  package/e2fsprogs/e2fsprogs-sem-init-libs.patch      | 11 -----------
  2 files changed, 11 insertions(+), 11 deletions(-)

create mode 100644 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch delete mode 100644 package/e2fsprogs/e2fsprogs-sem-init-libs.patch

Quoted 4 lines
Quoted 1 line

Also here I wonder why git/git-format-patch did not recognize the move?

Because you need to explicitly do a 'git format-patch -M', or configure Git in your ~/.gitconfig to enable rename detection permanently.

But anyway it doesn't really matter, since git-repack will convert it
into a proper rename. It just makes the patch on the list shorter and easier to review.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH 1/1 e2fsprogs: Rename the first patch to match the naming policy.

Quoted 10 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Also here I wonder why git/git-format-patch did not recognize the move?

Because you need to explicitly do a 'git format-patch -M', or configure Git in your ~/.gitconfig to enable rename detection permanently.

But anyway it doesn't really matter, since git-repack will convert it
into a proper rename. It just makes the patch on the list shorter and easier to review.

.. which is also very important!

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 e2fsprogs: Rename the first patch to match the naming policy.

In reply to sonic.adi at gmail.com

Dear sonic.adi at gmail.com,

Quoted 9 lines · sonic.adi at gmail.com

From: Sonic Zhang <[email protected]>

---
 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch | 11 +++++++++++
 package/e2fsprogs/e2fsprogs-sem-init-libs.patch      | 11 -----------
 2 files changed, 11 insertions(+), 11 deletions(-)
 create mode 100644 package/e2fsprogs/e2fsprogs-0001-sem-init-libs.patch
 delete mode 100644 package/e2fsprogs/e2fsprogs-sem-init-libs.patch

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com