Skip to contentSkip to conversation

fio: new package

PATCH New Ezequiel Garcia 2 participants 8 messages Oct 30, 2013 – Dec 26, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fio: new package

---
 package/Config.in     |  1 +
 package/fio/Config.in |  6 ++++++
 package/fio/fio.mk    | 25 +++++++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/fio/Config.in
 create mode 100644 package/fio/fio.mk
package/Config.in +1 -0
index 4c4da51..7cb46aa 100644
@@ -47,6 +47,7 @@ source "package/dmalloc/Config.in"
 source "package/dropwatch/Config.in"
 source "package/dstat/Config.in"
 source "package/duma/Config.in"
+source "package/fio/Config.in"
 source "package/gdb/Config.in"
 source "package/iozone/Config.in"
 source "package/kexec/Config.in"
package/fio/Config.in new file +6 -0
new file mode 100644
index 0000000..263e7f5
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_FIO
+	bool "fio"
+	depends on BR2_USE_MMU # fork()
+	help
+	  fio is an I/O tool meant to be used both for benchmark
+	  and stress/hardware verification.
package/fio/fio.mk new file +25 -0
new file mode 100644
index 0000000..60cd14f
@@ -0,0 +1,25 @@
+################################################################################
+#
+# fio
+#
+################################################################################
+
+FIO_VERSION = 2.1.3
+FIO_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/f/fio
+FIO_SOURCE = fio_$(FIO_VERSION).orig.tar.gz
+FIO_LICENSE = GPLv2
+FIO_LICENSE_FILES = LICENSE
+
+define FIO_CONFIGURE_CMDS
+	(cd $(@D); ./configure --cc="$(TARGET_CC)" --extra-cflags="$(TARGET_CFLAGS)")
+endef
+
+define FIO_BUILD_CMDS
+	$(MAKE) -C $(@D)
+endef
+
+define FIO_INSTALL_TARGET_CMDS
+	$(INSTALL) -D $(@D)/fio $(TARGET_DIR)/usr/bin/fio
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 fio: new package

Dear Ezequiel Garcia,

Quoted 8 lines · Ezequiel Garcia
---
 package/Config.in     |  1 +
 package/fio/Config.in |  6 ++++++
 package/fio/fio.mk    | 25 +++++++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/fio/Config.in
 create mode 100644 package/fio/fio.mk

Thanks, I've applied this, after making several changes.

Quoted 19 lines
package/Config.in +1 -0
index 4c4da51..7cb46aa 100644
@@ -47,6 +47,7 @@ source "package/dmalloc/Config.in"
 source "package/dropwatch/Config.in"
 source "package/dstat/Config.in"
 source "package/duma/Config.in"
+source "package/fio/Config.in"
 source "package/gdb/Config.in"
 source "package/iozone/Config.in"
 source "package/kexec/Config.in"
package/fio/Config.in new file +0 -0
new file mode 100644
index 0000000..263e7f5

package/fio/Config.in line 3

Quoted 3 lines
package/fio/Config.in new file +3 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_FIO
+	bool "fio"
+	depends on BR2_USE_MMU # fork()

The package required largefile and thread support.

package/fio/Config.in line 6

Quoted 3 lines
package/fio/Config.in new file +3 -0
+	help
+	  fio is an I/O tool meant to be used both for benchmark
+	  and stress/hardware verification.

I've added an upstream URL here.

Quoted 6 lines
package/fio/fio.mk new file +0 -0
new file mode 100644
index 0000000..60cd14f

package/fio/fio.mk line 9

Quoted 9 lines
package/fio/fio.mk new file +9 -0
@@ -0,0 +1,25 @@
+################################################################################
+#
+# fio
+#
+################################################################################
+
+FIO_VERSION = 2.1.3
+FIO_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/f/fio
+FIO_SOURCE = fio_$(FIO_VERSION).orig.tar.gz

I've switched to use the official Git repository at git.kernel.dk, and used the new 2.1.4 version.

package/fio/fio.mk line 10

Quoted 1 line
package/fio/fio.mk new file +1 -0
+FIO_LICENSE = GPLv2

I've changed that to "GPLv2 + special obligations", because the LICENSE file makes additional requirements to the GPLv2.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 fio: new package

Hi Thomas,

Quoted 10 lines · Thomas Petazzoni
Quoted 8 lines · Ezequiel Garcia
---
 package/Config.in     |  1 +
 package/fio/Config.in |  6 ++++++
 package/fio/fio.mk    | 25 +++++++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/fio/Config.in
 create mode 100644 package/fio/fio.mk
Quoted 2 lines

Thanks, I've applied this, after making several changes.

All the changes look good to me, thanks for doing this and sorry for being lazy and not take better care to push this submission.

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 fio: new package

Dear Ezequiel Garcia,

Quoted 6 lines · Ezequiel Garcia
Quoted 2 lines

Thanks, I've applied this, after making several changes.

All the changes look good to me, thanks for doing this and sorry for being lazy and not take better care to push this submission.

We still have the problem that fio uses posix_madvise(), which isn't supported in uClibc 0.9.33. It is supported in uClibc git, and we have backported the patch in package/uclibc/, so Buildroot internal toolchains are working fine.

But older uClibc toolchains do not work, and are causing build failures such as
http://autobuild.buildroot.org/results/f7a/f7ae7ac2b5da9afc6314f1e813300597896e5ca6/build-end.log.

I believe the best solution for now is to mark this package as not available for uClibc toolchains.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 fio: new package

Quoted 16 lines · Thomas Petazzoni

Dear Ezequiel Garcia,

Quoted 6 lines · Ezequiel Garcia
Quoted 2 lines

Thanks, I've applied this, after making several changes.

All the changes look good to me, thanks for doing this and sorry for being lazy and not take better care to push this submission.

We still have the problem that fio uses posix_madvise(), which isn't supported in uClibc 0.9.33. It is supported in uClibc git, and we have backported the patch in package/uclibc/, so Buildroot internal toolchains are working fine.

Quoted 7 lines

But older uClibc toolchains do not work, and are causing build failures such as
http://autobuild.buildroot.org/results/f7a/f7ae7ac2b5da9afc6314f1e813300597896e5ca6/build-end.log.

I believe the best solution for now is to mark this package as not available for uClibc toolchains.

Right. And in parallel, we can also take care of upstreaming a patch which uses HAVE_POSIX_MADVISE to handle such case.

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 fio: new package

Dear Ezequiel Garcia,

Quoted 10 lines · Ezequiel Garcia
Quoted 7 lines

But older uClibc toolchains do not work, and are causing build failures such as
http://autobuild.buildroot.org/results/f7a/f7ae7ac2b5da9afc6314f1e813300597896e5ca6/build-end.log.

I believe the best solution for now is to mark this package as not available for uClibc toolchains.

Right. And in parallel, we can also take care of upstreaming a patch which uses HAVE_POSIX_MADVISE to handle such case.

The problem is what should we use in replacement of posix_madvise() when it is not available.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw

PATCH 1/1 fio: new package

Quoted 12 lines · Thomas Petazzoni

Dear Ezequiel Garcia,

Quoted 8 lines · Ezequiel Garcia
Quoted 7 lines

But older uClibc toolchains do not work, and are causing build failures such as
http://autobuild.buildroot.org/results/f7a/f7ae7ac2b5da9afc6314f1e813300597896e5ca6/build-end.log.

I believe the best solution for now is to mark this package as not available for uClibc toolchains.

Quoted 6 lines
Quoted 2 lines

Right. And in parallel, we can also take care of upstreaming a patch which uses HAVE_POSIX_MADVISE to handle such case.

The problem is what should we use in replacement of posix_madvise() when it is not available.

madvise()?

If you do:

  #define posix_madvise madvise

then I've managed to fix the build issues on uClibc v0.9.32.

Problem is, I'm not sure there's a clean way to detect posix_madvise / madvise presence; it must be done by hand in the configure script.

Anyway, it all sounds like too much work to fix such a small use case.

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#7 lore raw

PATCH 1/1 fio: new package

Dear Ezequiel Garcia,

Quoted 7 lines · Ezequiel Garcia
Quoted 6 lines
Quoted 2 lines

Right. And in parallel, we can also take care of upstreaming a patch which uses HAVE_POSIX_MADVISE to handle such case.

The problem is what should we use in replacement of posix_madvise() when it is not available.

Quoted 5 lines

madvise()?

If you do:

  #define posix_madvise madvise

Are they strictly equivalent? Also, the code uses some POSIX_MADV_* constants, while madvise() provides MADV_* constants.

Quoted 2 lines

Problem is, I'm not sure there's a clean way to detect posix_madvise / madvise presence; it must be done by hand in the configure script.

AC_CHECK_FUNCS([posix_madvise]) should do the trick.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com