mdio: unused ethtool functions
Subsystems (3)
PATCH 1/1 mdio: unused ethtool functions
Use it or lose it.
Signed-off-by Stephen Hemminger <[email protected]>
--- drivers/net/mdio.c | 28 ---------------------------- include/linux/mdio.h | 3 --- 2 files changed, 31 deletions(-)
drivers/net/mdio.c +0 -28
@@ -342,34 +342,6 @@ void mdio45_ethtool_gset_npage(const strEXPORT_SYMBOL (mdio45_ethtool_gset_npage);/** -* mdio45_ethtool_spauseparam_an - set auto-negotiated pause parameters -* @mdio: MDIO interface -* @ecmd: Ethtool request structure -* -* This function assumes that the PHY has an auto-negotiation MMD. It -* will enable and disable advertising of flow control as appropriate. -*/ -void mdio45_ethtool_spauseparam_an (const struct mdio_if_info *mdio, -const struct ethtool_pauseparam *ecmd) -{ -int adv, old_adv; - -WARN_ON (!(mdio->mmds &MDIO_DEVS_AN )); - - old_adv = mdio->mdio_read (mdio->dev, mdio->prtad,MDIO_MMD_AN , -MDIO_AN_ADVERTISE ); - adv = ((old_adv & ~(ADVERTISE_PAUSE_CAP |ADVERTISE_PAUSE_ASYM )) | -mii_advertise_flowctrl ((ecmd->rx_pause ?FLOW_CTRL_RX :0 ) | - (ecmd->tx_pause ?FLOW_CTRL_TX :0 ))); -if (adv != old_adv) { - mdio->mdio_write (mdio->dev, mdio->prtad,MDIO_MMD_AN , -MDIO_AN_ADVERTISE , adv); -mdio45_nway_restart (mdio); - } -} -EXPORT_SYMBOL (mdio45_ethtool_spauseparam_an); - -/** * mdio_mii_ioctl - MII ioctl interface for MDIO (clause 22 or 45) PHYs * @mdio: MDIO interface * @mii_data: MII ioctl data structure
include/linux/mdio.h +0 -3
@@ -70,9 +70,6 @@ extern int mdio45_nway_restart(const strextern void mdio45_ethtool_gset_npage (const struct mdio_if_info *mdio,struct ethtool_cmd *ecmd,u32 npage_adv,u32 npage_lpa); -extern void -mdio45_ethtool_spauseparam_an (const struct mdio_if_info *mdio, -const struct ethtool_pauseparam *ecmd);/** * mdio45_ethtool_gset - get settings for ETHTOOL_GSET
From: Stephen Hemminger <[email protected]>
Date: Thu, 26 Dec 2013 10:12:41 -0800
Quoted 3 lines
Use it or lose it.
Signed-off-by Stephen Hemminger <[email protected]>
Applied.
Quoted 3 lines · Stephen Hemminger
Use it or lose it.
Signed-off-by Stephen Hemminger <[email protected]>
Right, this was called by sfc for a while but not since 2.6.33 as we set all the autoneg bits at once.
Ben.
Quoted 54 lines
--- drivers/net/mdio.c | 28 ---------------------------- include/linux/mdio.h | 3 --- 2 files changed, 31 deletions(-)drivers/net/mdio.c +0
-28@@ -342,34 +342,6 @@ void mdio45_ethtool_gset_npage(const strEXPORT_SYMBOL (mdio45_ethtool_gset_npage);/** -* mdio45_ethtool_spauseparam_an - set auto-negotiated pause parameters -* @mdio: MDIO interface -* @ecmd: Ethtool request structure -* -* This function assumes that the PHY has an auto-negotiation MMD. It -* will enable and disable advertising of flow control as appropriate. -*/ -void mdio45_ethtool_spauseparam_an (const struct mdio_if_info *mdio, -const struct ethtool_pauseparam *ecmd) -{ -int adv, old_adv; - -WARN_ON (!(mdio->mmds &MDIO_DEVS_AN )); - - old_adv = mdio->mdio_read (mdio->dev, mdio->prtad,MDIO_MMD_AN , -MDIO_AN_ADVERTISE ); - adv = ((old_adv & ~(ADVERTISE_PAUSE_CAP |ADVERTISE_PAUSE_ASYM )) | -mii_advertise_flowctrl ((ecmd->rx_pause ?FLOW_CTRL_RX :0 ) | - (ecmd->tx_pause ?FLOW_CTRL_TX :0 ))); -if (adv != old_adv) { - mdio->mdio_write (mdio->dev, mdio->prtad,MDIO_MMD_AN , -MDIO_AN_ADVERTISE , adv); -mdio45_nway_restart (mdio); - } -} -EXPORT_SYMBOL (mdio45_ethtool_spauseparam_an); - -/** * mdio_mii_ioctl - MII ioctl interface for MDIO (clause 22 or 45) PHYs * @mdio: MDIO interface * @mii_data: MII ioctl data structure include/linux/mdio.h +0
-3@@ -70,9 +70,6 @@ extern int mdio45_nway_restart(const strextern void mdio45_ethtool_gset_npage (const struct mdio_if_info *mdio,struct ethtool_cmd *ecmd,u32 npage_adv,u32 npage_lpa); -extern void -mdio45_ethtool_spauseparam_an (const struct mdio_if_info *mdio, -const struct ethtool_pauseparam *ecmd);/** * mdio45_ethtool_gset - get settings for ETHTOOL_GSET
Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.