Skip to contentSkip to conversation

Staging: Android: Fixed coding issue return parenthesis in alarm_dev.c

PATCH In review Arthur Schwalbenberg 2 participants 2 messages Dec 28, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: Android: Fixed coding issue return parenthesis in alarm_dev.c

This is a patch to the alarm_dev.c file that fixes up a return is not a function warning found by the checkpatch.pl tool

---
 drivers/staging/android/alarm-dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/android/alarm-dev.c +2 -2
index 647694f..96b2f53 100644
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
  */
 static int is_wakeup(enum android_alarm_type type)
 {
-	return (type == ANDROID_ALARM_RTC_WAKEUP ||
-		type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+	return type == ANDROID_ALARM_RTC_WAKEUP ||
+	       type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
 }
 
 
Signature · 1 line
1.8.3.2
maintainer
#1 lore raw
Quoted 4 lines · Arthur Schwalbenberg

This is a patch to the alarm_dev.c file that fixes up a return is not a function warning found by the checkpatch.pl tool

Why the odd indentation?

Quoted 9 lines
---
 drivers/staging/android/alarm-dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/android/alarm-dev.c +0 -0
index 647694f..96b2f53 100644

drivers/staging/android/alarm-dev.c static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT]; · line 73

Quoted 8 lines
drivers/staging/android/alarm-dev.c +2 -2
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
  */
 static int is_wakeup(enum android_alarm_type type)
 {
-	return (type == ANDROID_ALARM_RTC_WAKEUP ||
-		type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+	return type == ANDROID_ALARM_RTC_WAKEUP ||
+	       type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
 }

This change is already in linux-next, right? I can't apply the same change more than once to the tree...

greg k-h