mlx5: remove dead code
Subsystems (4)
PATCH 1/1 mlx5: remove dead code
There are 3 functions in the mlx5 driver which are used and should be deleted. Upstream is not the repository to hold old dead code, or code which is used by outside drivers, or code intended for future undetermined features.
drivers/net/ethernet/mellanox/mlx5/core/cq.c +0 -7
@@ -199,13 +199,6 @@ int mlx5_core_query_cq(struct mlx5_core_ }EXPORT_SYMBOL (mlx5_core_query_cq); - -int mlx5_core_modify_cq (struct mlx5_core_dev *dev,struct mlx5_core_cq *cq, -int type,struct mlx5_cq_modify_params *params) -{ -return -ENOSYS ; -} -int mlx5_init_cq_table (struct mlx5_core_dev *dev) {struct mlx5_cq_table *table = &dev->priv.cq_table;
drivers/net/ethernet/mellanox/mlx5/core/mr.c +0 -46
49 lines not on this page · raw message
include/linux/mlx5/cq.h +0 -2
@@ -157,8 +157,6 @@ int mlx5_core_create_cq(struct mlx5_coreint mlx5_core_destroy_cq (struct mlx5_core_dev *dev,struct mlx5_core_cq *cq);int mlx5_core_query_cq (struct mlx5_core_dev *dev,struct mlx5_core_cq *cq,struct mlx5_query_cq_mbox_out *out); -int mlx5_core_modify_cq (struct mlx5_core_dev *dev,struct mlx5_core_cq *cq, -int type,struct mlx5_cq_modify_params *params);int mlx5_debug_cq_add (struct mlx5_core_dev *dev,struct mlx5_core_cq *cq);void mlx5_debug_cq_remove (struct mlx5_core_dev *dev,struct mlx5_core_cq *cq);
include/linux/mlx5/driver.h +0 -4
@@ -687,10 +687,6 @@ int mlx5_core_create_mkey(struct mlx5_co mlx5_cmd_cbk_t callback, void *context, struct mlx5_create_mkey_mbox_out *out);int mlx5_core_destroy_mkey (struct mlx5_core_dev *dev,struct mlx5_core_mr *mr); -int mlx5_core_query_mkey (struct mlx5_core_dev *dev,struct mlx5_core_mr *mr, -struct mlx5_query_mkey_mbox_out *out,int outlen); -int mlx5_core_dump_fill_mkey (struct mlx5_core_dev *dev,struct mlx5_core_mr *mr, -u32 *mkey);int mlx5_core_alloc_pd (struct mlx5_core_dev *dev,u32 *pdn);int mlx5_core_dealloc_pd (struct mlx5_core_dev *dev,u32 pdn); int mlx5_core_mad_ifc(struct mlx5_core_dev *dev, void *inb, void *outb,
Hello.
Quoted 1 line · Stephen Hemminger
There are 3 functions in the mlx5 driver which are used and should be
s/used/unused/, I think.
Quoted 5 lines
deleted. Upstream is not the repository to hold old dead code, or code which is used by outside drivers, or code intended for future undetermined features.
Signed-off-by Stephen Hemminger <[email protected]>
WBR, Sergei
Thanks. I noticed that and will address in the next patch set I plan to send.
Quoted 20 lines · Sergei Shtylyov
Hello.
Quoted 1 line · Stephen Hemminger
There are 3 functions in the mlx5 driver which are used and should be
s/used/unused/, I think.
Quoted 5 lines
deleted. Upstream is not the repository to hold old dead code, or code which is used by outside drivers, or code intended for future undetermined features.
Signed-off-by Stephen Hemminger <[email protected]>WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello.
Quoted 2 lines · Eli Cohen
Thanks. I noticed that and will address in the next patch set I plan to send.
Noticed what? Unused functions? They were removed by Stephen, not me.
Quoted 9 lines
Quoted 9 lines
Quoted 1 line
There are 3 functions in the mlx5 driver which are used and should be
s/used/unused/, I think.
Quoted 5 lines
deleted. Upstream is not the repository to hold old dead code, or code which is used by outside drivers, or code intended for future undetermined features.
Signed-off-by Stephen Hemminger <[email protected]>
WBR, Sergei