Skip to contentSkip to conversation

net: core functions cleanup

PATCH Applied Stephen Hemminger 2 participants 2 messages Dec 29, 2013 – Jan 2, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: core functions cleanup

The following functions are not used outside of net/core/dev.c and should be declared static.

call_netdevice_notifiers_info
__dev_remove_offload
netdev_has_any_upper_dev
__netdev_adjacent_dev_remove
__netdev_adjacent_dev_link_lists
__netdev_adjacent_dev_unlink_lists
__netdev_adjacent_dev_unlink
__netdev_adjacent_dev_link_neighbour
__netdev_adjacent_dev_unlink_neighbour

And the following are never used and should be deleted
netdev_lower_dev_get_private_rcu __netdev_find_adj_rcu

---
v2 - reindent call_netdevice_notifiers_info

 include/linux/netdevice.h |    6 ---
 net/core/dev.c            |   79 +++++++++++++---------------------------------
 2 files changed, 24 insertions(+), 61 deletions(-)
include/linux/netdevice.h +0 -6
@@ -1741,8 +1741,6 @@ netdev_notifier_info_to_dev(const struct
 	return info->dev;
 }
 
-int call_netdevice_notifiers_info(unsigned long val, struct net_device *dev,
-				  struct netdev_notifier_info *info);
 int call_netdevice_notifiers(unsigned long val, struct net_device *dev);
 
 
@@ -1809,7 +1807,6 @@ void dev_remove_pack(struct packet_type
 void __dev_remove_pack(struct packet_type *pt);
 void dev_add_offload(struct packet_offload *po);
 void dev_remove_offload(struct packet_offload *po);
-void __dev_remove_offload(struct packet_offload *po);
 
 struct net_device *dev_get_by_flags_rcu(struct net *net, unsigned short flags,
 					unsigned short mask);
@@ -2867,7 +2864,6 @@ extern int		weight_p;
 extern int		bpf_jit_enable;
 
 bool netdev_has_upper_dev(struct net_device *dev, struct net_device *upper_dev);
-bool netdev_has_any_upper_dev(struct net_device *dev);
 struct net_device *netdev_all_upper_get_next_dev_rcu(struct net_device *dev,
 						     struct list_head **iter);
 
@@ -2907,8 +2903,6 @@ int netdev_master_upper_dev_link_private
 					 void *private);
 void netdev_upper_dev_unlink(struct net_device *dev,
 			     struct net_device *upper_dev);
-void *netdev_lower_dev_get_private_rcu(struct net_device *dev,
-				       struct net_device *lower_dev);
 void *netdev_lower_dev_get_private(struct net_device *dev,
 				   struct net_device *lower_dev);
 int skb_checksum_help(struct sk_buff *skb);
net/core/dev.c +26 -56

169 lines not on this page · raw message

maintainer Applied
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Sun, 29 Dec 2013 14:01:29 -0800

Quoted 14 lines

The following functions are not used outside of net/core/dev.c and should be declared static.

call_netdevice_notifiers_info
__dev_remove_offload
netdev_has_any_upper_dev
__netdev_adjacent_dev_remove
__netdev_adjacent_dev_link_lists
__netdev_adjacent_dev_unlink_lists
__netdev_adjacent_dev_unlink
__netdev_adjacent_dev_link_neighbour
__netdev_adjacent_dev_unlink_neighbour

Quoted 6 lines

And the following are never used and should be deleted
netdev_lower_dev_get_private_rcu __netdev_find_adj_rcu

Applied.