Skip to contentSkip to conversation

clk: remove CONFIG_COMMON_CLK_DEBUG

PATCH In review Mike Turquette 2 participants 3 messages Dec 19, 2013 – Dec 29, 2013 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: remove CONFIG_COMMON_CLK_DEBUG

Populate ${DEBUGS_MOUNT_POINT}/clk if CONFIG_DEBUG_FS is set. This eliminates the extra (annoying) step of enabling the config option manually.

---
 drivers/clk/Kconfig         | 10 ----------
 drivers/clk/clk.c           |  2 +-
 include/linux/clk-private.h |  2 +-
 3 files changed, 2 insertions(+), 12 deletions(-)
drivers/clk/Kconfig +0 -10
index 3089f05..407cffb 100644
@@ -23,16 +23,6 @@ config COMMON_CLK
 menu "Common Clock Framework"
 	depends on COMMON_CLK
 
-config COMMON_CLK_DEBUG
-	bool "DebugFS representation of clock tree"
-	select DEBUG_FS
-	---help---
-	  Creates a directory hierarchy in debugfs for visualizing the clk
-	  tree structure.  Each directory contains read-only members
-	  that export information specific to that clk node: clk_rate,
-	  clk_flags, clk_prepare_count, clk_enable_count &
-	  clk_notifier_count.
-
 config COMMON_CLK_WM831X
 	tristate "Clock driver for WM831x/2x PMICs"
 	depends on MFD_WM831X
drivers/clk/clk.c +1 -1
index 8312736..41e46df 100644
@@ -92,7 +92,7 @@ static void clk_enable_unlock(unsigned long flags)
 
 /***        debugfs support        ***/
 
-#ifdef CONFIG_COMMON_CLK_DEBUG
+#ifdef CONFIG_DEBUG_FS
 #include <linux/debugfs.h>
 
 static struct dentry *rootdir;
include/linux/clk-private.h +1 -1
index 8138c94..98f8614 100644
@@ -44,7 +44,7 @@ struct clk {
 	struct hlist_head	children;
 	struct hlist_node	child_node;
 	unsigned int		notifier_count;
-#ifdef CONFIG_COMMON_CLK_DEBUG
+#ifdef CONFIG_DEBUG_FS
 	struct dentry		*dentry;
 #endif
 };
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 6 lines · Mike Turquette

Populate ${DEBUGS_MOUNT_POINT}/clk if CONFIG_DEBUG_FS is set. This eliminates the extra (annoying) step of enabling the config option manually.

Yes, please! The debugfs information is just too useful to hide behind another option that requires manual enabling. :)

virtually yours
Gerhard Sittig

Signature · 3 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
author Applied
#2 lore raw

PATCH 1/1 clk: remove CONFIG_COMMON_CLK_DEBUG

Quoting Gerhard Sittig (2013-12-19 13:15:33)

Quoted 10 lines · Mike Turquette
Quoted 6 lines

Populate ${DEBUGS_MOUNT_POINT}/clk if CONFIG_DEBUG_FS is set. This eliminates the extra (annoying) step of enabling the config option manually.

Yes, please! The debugfs information is just too useful to hide behind another option that requires manual enabling. :)

Applied to clk-next.

Regards,
Mike

Quoted 8 lines

virtually yours
Gerhard Sittig

Signature · 3 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de