Skip to contentSkip to conversation

nouveau: fix memory leak in nouveau_crtc_page_flip()

PATCH New Christian Engelmayer 1 participant 1 message Dec 29, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nouveau: fix memory leak in nouveau_crtc_page_flip()

Fix a memory leak in the nouveau_crtc_page_flip() error handling path.

---
This fixes a regression introduced in

commit eae389f9b1e08a6e6e8da68937706d89517b1796
Author: Ben Skeggs <[email protected]>
Date: Wed Nov 13 10:17:17 2013 +1000

drm/nouveau: always queue flips relative to kernel channel activity

---
 drivers/gpu/drm/nouveau/nouveau_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_display.c +1 -1
index 29c3efd..25ea82f 100644
@@ -610,7 +610,7 @@ nouveau_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb,
 	ret = nouveau_fence_sync(fence, chan);
 	nouveau_fence_unref(&fence);
 	if (ret)
-		return ret;
+		goto fail_free;
 
 	if (new_bo != old_bo) {
 		ret = nouveau_bo_pin(new_bo, TTM_PL_FLAG_VRAM);
Signature · 1 line
1.8.3.2