vt: fix potential dual con_driver register for conswitchp
PATCH v2 1/1 vt: fix potential dual con_driver register for conswitchp
We should check whether conswitchp is registered before add it to registered_con_driver in con_init, or it will cause dual con_driver register for conswitchp.
Although I haven't met it in reality, but I think it could happen for Embeded devices, who register platform con_driver earlier than call con_init.
---
Change v1-v2:
1: if conswitchp is registered, then
make it become "system driver" by
change value of first,last,flag.
drivers/tty/vt/vt.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/tty/vt/vt.c +6 -0
@@ -2876,6 +2876,12 @@ static int __init con_init(void)for (i =0 ; i <MAX_NR_CON_DRIVER ; i++) {struct con_driver *con_driver = ®istered_con_driver[i]; +if (con_driver->con == conswitchp) { + con_driver->flag =CON_DRIVER_FLAG_INIT ; + con_driver->first =0 ; + con_driver->last =MAX_NR_CONSOLES -1 ; +break ; + }if (con_driver->con ==NULL ) { con_driver->con = conswitchp; con_driver->desc = display_desc;
Signature · 1 line
1.8.3.4.8.g69490f3.dirty
Greg KH
maintainerQuoted 7 lines · Wang YanQing
We should check whether conswitchp is registered before add it to
registered_con_driverincon_init, or it will cause dualcon_driverregister for conswitchp.Although I haven't met it in reality, but I think it could happen for Embeded devices, who register platform
con_driverearlier than callcon_init.
Does that happen on those systems? Let's not add code that's never going to be use, and is not needed, right?
thanks,
greg k-h