Skip to contentSkip to conversation

fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time

PATCH In review Wang YanQing 3 participants 4 messages Dec 30, 2013 Framebuffer console

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time

FONT_8x8 and FONT_8x16 have the same default value line:
"default y if !SPARC && !FONTS"

I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at the same time.

This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so I decide to disable FONT_8x8, this patch will reduce size of kernel.

---
 lib/fonts/Kconfig | 1 -
 1 file changed, 1 deletion(-)
lib/fonts/Kconfig +0 -1
index 34fd931..11d3758 100644
@@ -23,7 +23,6 @@ config FONTS
 config FONT_8x8
 	bool "VGA 8x8 font" if FONTS
 	depends on FRAMEBUFFER_CONSOLE || STI_CONSOLE
-	default y if !SPARC && !FONTS
 	help
 	  This is the "high resolution" font for the VGA frame buffer (the one
 	  provided by the text console 80x50 (and higher) modes).
Signature · 1 line
1.8.3.4.8.g69490f3.dirty
#1 lore raw
Quoted 6 lines · Wang YanQing

FONT_8x8 and FONT_8x16 have the same default value line:
"default y if !SPARC && !FONTS"

I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at the same time.

Quoted 7 lines

This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so I decide to disable FONT_8x8, this patch will reduce size of kernel.

---
 lib/fonts/Kconfig | 1 -
 1 file changed, 1 deletion(-)

I am not the maintainer of this file, sorry. Also, I don't think it's correct, if you want, you can always disable this option on your own.

greg k-h

#2 lore raw
Quoted 10 lines · Greg KH
Quoted 9 lines · Wang YanQing

FONT_8x8 and FONT_8x16 have the same default value line:
"default y if !SPARC && !FONTS"

I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at the same time.

This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so I decide to disable FONT_8x8, this patch will reduce size of kernel.

Quoted 8 lines
Quoted 4 lines
---
 lib/fonts/Kconfig | 1 -
 1 file changed, 1 deletion(-)

I am not the maintainer of this file, sorry. Also, I don't think it's correct, if you want, you can always disable this option on your own.

Hi Greg KH.

Sorry for confusion, the default behavior enable FONT_8x8 and FONT_8x16, FONT_8x8 eat ~50KB memory, but kernel never use it. I think this is not good default behavior.

Thanks.

#3 lore raw
Quoted 16 lines · Wang YanQing
Quoted 15 lines · Greg KH
Quoted 13 lines · Wang YanQing

FONT_8x8 and FONT_8x16 have the same default value line:
"default y if !SPARC && !FONTS"

I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at the same time.

This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so I decide to disable FONT_8x8, this patch will reduce size of kernel.

---
 lib/fonts/Kconfig | 1 -
 1 file changed, 1 deletion(-)
Quoted 8 lines
Quoted 3 lines

I am not the maintainer of this file, sorry. Also, I don't think it's correct, if you want, you can always disable this option on your own.

Hi Greg KH.

Sorry for confusion, the default behavior enable FONT_8x8 and FONT_8x16, FONT_8x8 eat ~50KB memory, but kernel never use it. I think this is not good default behavior.

If framebuffer console is enabled, then the user can select which compiled-in font to use by using
fbcon=font:<name>
See Documentation/fb/fbcon.txt for more info.

Signature · 1 line
~Randy