fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
Subsystems (2)
PATCH 1/1 fonts:Kconfig: fix default enable FONT_8x8 and FONT_8x16 at the same time
FONT_8x8 and FONT_8x16 have the same default value line:
"default y if !SPARC && !FONTS"
I test run "make defconfig" for x86 will enable FONT_8x8 and FONT_8x16 at the same time.
This patch fix it, because FONT_AUTOSELECT choice FONT_8x16, so I decide to disable FONT_8x8, this patch will reduce size of kernel.
--- lib/fonts/Kconfig | 1 - 1 file changed, 1 deletion(-)
lib/fonts/Kconfig +0 -1
@@ -23,7 +23,6 @@ config FONTS config FONT_8x8 bool "VGA 8x8 font" if FONTS depends on FRAMEBUFFER_CONSOLE || STI_CONSOLE - default y if !SPARC && !FONTS help This is the "high resolution" font for the VGA frame buffer (the one provided by the text console 80x50 (and higher) modes).
Signature · 1 line
1.8.3.4.8.g69490f3.dirty
Quoted 8 lines · Wang YanQing
FONT_8x8andFONT_8x16have the same default value line:
"default y if !SPARC && !FONTS"I test run "make defconfig" for x86 will enable
FONT_8x8andFONT_8x16at the same time.This patch fix it, because
FONT_AUTOSELECTchoiceFONT_8x16, so I decide to disableFONT_8x8, this patch will reduce size of kernel.
... at the expense of losing FONT_8x8...
In another email, you wrote:
| Sorry for confusion, the default behavior enable FONT_8x8 and FONT_8x16, | FONT_8x8 eat ~50KB memory, but kernel never use it. I think this is not | good default behavior.
Whether FONT_8x8 or FONT_8x16 is used depends on your screen resolution, cfr. lib/fonts/font.c:get_default_font().
If you don't want to compile in FONT_8x8, then please enable CONFIG_FONTS, and disable CONFIG_FONT_8x8.
Quoted 18 lines
Signed-off-by Wang YanQing <[email protected]>--- lib/fonts/Kconfig | 1 - 1 file changed, 1 deletion(-)lib/fonts/Kconfig +0
-2@@ -23,7 +23,6 @@ config FONTS config FONT_8x8 bool "VGA 8x8 font" if FONTS depends on FRAMEBUFFER_CONSOLE || STI_CONSOLE - default y if !SPARC && !FONTS help This is the "high resolution" font for the VGA frame buffer (the one provided by the text console 80x50 (and higher) modes). --
Quoted 1 line
1.8.3.4.8.g69490f3.dirty
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 12 lines · Geert Uytterhoeven
Quoted 8 lines · Wang YanQing
FONT_8x8andFONT_8x16have the same default value line:
"default y if !SPARC && !FONTS"I test run "make defconfig" for x86 will enable
FONT_8x8andFONT_8x16at the same time.This patch fix it, because
FONT_AUTOSELECTchoiceFONT_8x16, so I decide to disableFONT_8x8, this patch will reduce size of kernel.... at the expense of losing
FONT_8x8...
Quoted 7 lines
In another email, you wrote:
| Sorry for confusion, the default behavior enable FONT_8x8 and FONT_8x16, | FONT_8x8 eat ~50KB memory, but kernel never use it. I think this is not | good default behavior.Whether
FONT_8x8orFONT_8x16is used depends on your screen resolution, cfr. lib/fonts/font.c:get_default_font().
Thanks for point out get_default_font, I know where I am wrong now :)