Minor bug in intel-gpu-tools
A message that is not in the archive (sent off-list or not yet received): CAKS+cu0pZMHKoR4wEuDdA9thHzqvnQbkDP2sEGOErDSBigXZhA@mail.gmail.com
Copying the appropriate mailing list. Thanks for the report!
Quoted 13 lines
From: Patrick McMunn [mailto:[email protected]]
Sent: Thursday, December 19, 2013 7:59 AM
To: Zanoni, Paulo R
Subject: Minor bug in intel-gpu-toolsI noticed that if I run "./configure --enable-shader-debugger", the configure script will fail if it does not find intel-gen4asm already installed on the system. This surely made sense when intel-gen4asm was a separate package, but now that intel-gen4asm is included with with intel-gpu-tools, it means that intel-gpu-tools must first be installed without the debugger so that the assembler is installed and then installed a second time with the shader debugger enabled so that the configure script doesn't
fail. It's a minor nuisance, but it should be fixed.
PATCH 1/1 shader-debugger: Use in tree gen4asm
--- configure.ac | 21 ++++++++++----------- debugger/system_routine/Makefile.am | 1 + 2 files changed, 11 insertions(+), 11 deletions(-)
configure.ac +10 -11
@@ -133,13 +133,20 @@ if test "x$DUMPER" == xyes; then fi AM_CONDITIONAL(HAVE_DUMPER, [test "x$DUMPER" = xyes]) -# Define a configure option for the shadder debugger +# Define a configure option for the shader debugger AC_ARG_ENABLE(shader-debugger, AS_HELP_STRING([--enable-shader-debugger], [Enable shader debugging support [autodetected]]), [BUILD_SHADER_DEBUGGER="$enableval"], [BUILD_SHADER_DEBUGGER=auto]) -# Shadder debugger depends on python3, intel-genasm and objcopy +# Shader debugger depends on python3, intel-genasm and objcopy if test "x$BUILD_SHADER_DEBUGGER" != xno; then + GEN4ASM = assembler/intel-gen4asm + # Check that the assembler is built + if test "$enable_assembler" = xno; then + AC_MSG_ERROR([Shader debugger requested, but assembler not build not found.]) + BUILD_SHADER_DEBUGGER=no + fi + # Check Python 3 is installed if test "$PYTHON" = ":" ; then if test "x$BUILD_SHADER_DEBUGGER" = xyes; then
@@ -148,15 +155,7 @@ if test "x$BUILD_SHADER_DEBUGGER" != xno; then BUILD_SHADER_DEBUGGER=no fi fi - # Check for the Intel Chipset assembler compiler - AC_PATH_PROGS([GEN4ASM], intel-gen4asm) - if test -z "$GEN4ASM" ; then - if test "x$BUILD_SHADER_DEBUGGER" = xyes; then - AC_MSG_ERROR([Shader debugger requested, but intel-gen4asm not found.]) - else - BUILD_SHADER_DEBUGGER=no - fi - fi + # Check for the objcopy GNU binary utiliy command AC_PATH_PROGS([OBJCOPY], objcopy) if test -z "$OBJCOPY" ; then
debugger/system_routine/Makefile.am +1 -0
@@ -3,6 +3,7 @@ noinst_PROGRAMS = eviction_macro sr tiny nodist_sr_SOURCES = sr.c nodist_tiny_SOURCES = tiny.c +GEN4ASM = $(top_builddir)/assembler/intel-gen4asm GEN4ASM_FLAGS = -g6 -a -b ASM_CPPFLAGS = \ -x assembler-with-cpp \
Signature · 1 line
1.8.5.2
Re: [PATCH] shader-debugger: Use in tree gen4asm
2013/12/21 Ben Widawsky <[email protected]>:
Quoted 2 lines
Reported-by Patrick McMunn <[email protected]>Signed-off-by Ben Widawsky <[email protected]>
I see this got merged. Now when I run autogen.sh I get:
./configure: line 20866: GEN4ASM: command not found
But the autogen command finishes successfully:
Intel GPU tools
• Tests:
Build tests : yes
Compile prime tests: yes
• Tools:
Assembler : no
Debugger : yes
Python dumper : yes
Overlay : X: yes, Xv: yesBut then when I type "make" I get this at some point:
Making all in system_routine
make[3]: Entering directory `/home/pzanoni/git/xorg/app/intel-gpu-tools/debugger/system_routine' gcc -E -x assembler-with-cpp -P -DGEN_ASM -DSANDYBRIDGE -I../../lib -I. -o sr.asm sr.cpp
../../assembler/intel-gen4asm -g6 -a -b sr.asm -o sr.c make[3]: ../../assembler/intel-gen4asm: Command not found make[3]: *** [sr.c] Error 127
And then compilation fails.
Quoted 64 lines
--- configure.ac | 21 ++++++++++----------- debugger/system_routine/Makefile.am | 1 + 2 files changed, 11 insertions(+), 11 deletions(-)configure.ac +10
-11@@ -133,13 +133,20 @@ if test "x$DUMPER" == xyes; then fi AM_CONDITIONAL(HAVE_DUMPER, [test "x$DUMPER" = xyes]) -# Define a configure option for the shadder debugger +# Define a configure option for the shader debugger AC_ARG_ENABLE(shader-debugger, AS_HELP_STRING([--enable-shader-debugger], [Enable shader debugging support [autodetected]]), [BUILD_SHADER_DEBUGGER="$enableval"], [BUILD_SHADER_DEBUGGER=auto]) -# Shadder debugger depends on python3, intel-genasm and objcopy +# Shader debugger depends on python3, intel-genasm and objcopy if test "x$BUILD_SHADER_DEBUGGER" != xno; then + GEN4ASM = assembler/intel-gen4asm + # Check that the assembler is built + if test "$enable_assembler" = xno; then + AC_MSG_ERROR([Shader debugger requested, but assembler not build not found.]) + BUILD_SHADER_DEBUGGER=no + fi + # Check Python 3 is installed if test "$PYTHON" = ":" ; then if test "x$BUILD_SHADER_DEBUGGER" = xyes; then@@ -148,15 +155,7 @@ if test "x$BUILD_SHADER_DEBUGGER" != xno; then BUILD_SHADER_DEBUGGER=no fi fi - # Check for the Intel Chipset assembler compiler - AC_PATH_PROGS([GEN4ASM], intel-gen4asm) - if test -z "$GEN4ASM" ; then - if test "x$BUILD_SHADER_DEBUGGER" = xyes; then - AC_MSG_ERROR([Shader debugger requested, but intel-gen4asm not found.]) - else - BUILD_SHADER_DEBUGGER=no - fi - fi + # Check for the objcopy GNU binary utiliy command AC_PATH_PROGS([OBJCOPY], objcopy) if test -z "$OBJCOPY" ; thendebugger/system_routine/Makefile.am +1
-1@@ -3,6 +3,7 @@ noinst_PROGRAMS = eviction_macro sr tiny nodist_sr_SOURCES = sr.c nodist_tiny_SOURCES = tiny.c +GEN4ASM = $(top_builddir)/assembler/intel-gen4asm GEN4ASM_FLAGS = -g6 -a -b ASM_CPPFLAGS = \ -x assembler-with-cpp \ --1.8.5.2
Signature · 1 line
Paulo Zanoni
Re: [PATCH] shader-debugger: Use in tree gen4asm
Should be fixed now. Sorry about that.
Quoted 105 lines · Paulo Zanoni
2013/12/21 Ben Widawsky <[email protected]>:
Quoted 2 lines
Reported-by Patrick McMunn <[email protected]>Signed-off-by Ben Widawsky <[email protected]>I see this got merged. Now when I run
autogen.shI get:
./configure: line 20866: GEN4ASM: command not foundBut the autogen command finishes successfully:
Intel GPU tools
• Tests:
Build tests : yes
Compile prime tests: yes• Tools:
Assembler : no Debugger : yes Python dumper : yes Overlay : X: yes, Xv: yesBut then when I type "make" I get this at some point:
Making all in
system_routine
make[3]: Entering directory `/home/pzanoni/git/xorg/app/intel-gpu-tools/debugger/system_routine' gcc -E -x assembler-with-cpp -P -DGEN_ASM -DSANDYBRIDGE -I../../lib -I. -o sr.asm sr.cpp
../../assembler/intel-gen4asm -g6 -a -b sr.asm -osr.cmake[3]: ../../assembler/intel-gen4asm: Command not found make[3]: *** [sr.c] Error 127And then compilation fails.
Quoted 64 lines
--- configure.ac | 21 ++++++++++----------- debugger/system_routine/Makefile.am | 1 + 2 files changed, 11 insertions(+), 11 deletions(-)configure.ac +10
-11@@ -133,13 +133,20 @@ if test "x$DUMPER" == xyes; then fi AM_CONDITIONAL(HAVE_DUMPER, [test "x$DUMPER" = xyes]) -# Define a configure option for the shadder debugger +# Define a configure option for the shader debugger AC_ARG_ENABLE(shader-debugger, AS_HELP_STRING([--enable-shader-debugger], [Enable shader debugging support [autodetected]]), [BUILD_SHADER_DEBUGGER="$enableval"], [BUILD_SHADER_DEBUGGER=auto]) -# Shadder debugger depends on python3, intel-genasm and objcopy +# Shader debugger depends on python3, intel-genasm and objcopy if test "x$BUILD_SHADER_DEBUGGER" != xno; then + GEN4ASM = assembler/intel-gen4asm + # Check that the assembler is built + if test "$enable_assembler" = xno; then + AC_MSG_ERROR([Shader debugger requested, but assembler not build not found.]) + BUILD_SHADER_DEBUGGER=no + fi + # Check Python 3 is installed if test "$PYTHON" = ":" ; then if test "x$BUILD_SHADER_DEBUGGER" = xyes; then@@ -148,15 +155,7 @@ if test "x$BUILD_SHADER_DEBUGGER" != xno; then BUILD_SHADER_DEBUGGER=no fi fi - # Check for the Intel Chipset assembler compiler - AC_PATH_PROGS([GEN4ASM], intel-gen4asm) - if test -z "$GEN4ASM" ; then - if test "x$BUILD_SHADER_DEBUGGER" = xyes; then - AC_MSG_ERROR([Shader debugger requested, but intel-gen4asm not found.]) - else - BUILD_SHADER_DEBUGGER=no - fi - fi + # Check for the objcopy GNU binary utiliy command AC_PATH_PROGS([OBJCOPY], objcopy) if test -z "$OBJCOPY" ; thendebugger/system_routine/Makefile.am +1
-1@@ -3,6 +3,7 @@ noinst_PROGRAMS = eviction_macro sr tiny nodist_sr_SOURCES = sr.c nodist_tiny_SOURCES = tiny.c +GEN4ASM = $(top_builddir)/assembler/intel-gen4asm GEN4ASM_FLAGS = -g6 -a -b ASM_CPPFLAGS = \ -x assembler-with-cpp \ --1.8.5.2
Signature · 1 line
Paulo Zanoni
Signature · 5 lines
Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx