Skip to contentSkip to conversation

xtensa build fixes using -mtext-section-literal

PATCH New Baruch Siach 2 participants 7 messages Dec 31, 2013

lore
Share & tools
lore
#0 lore raw

cover xtensa build fixes using -mtext-section-literal

These fixes are all similar. As the helpful linker error message says, xtensa needs -mtext-section-literal when building too large objects/libraries/binaries. So just do as we are told to.

Baruch Siach (3):
php: fix build for xtensa
lmbench: fix build for xtensa
civetweb: fix build for xtensa

 package/civetweb/civetweb.mk | 3 +++
 package/lmbench/lmbench.mk   | 4 ++++
 package/php/php.mk           | 4 ++++
 3 files changed, 11 insertions(+)
Signature · 1 line
1.8.5.2
#1 lore raw

PATCH 1/3 php: fix build for xtensa

The php package generates a binary that is too large for the xtensa default placement of literals in a dedicated section. Use -mtext-section-literal to place literals in the text section.

Fixes
http://autobuild.buildroot.net/results/a9a/a9a1063104402ec28e01560ec7c8f8a5b6d43dd5/.

---
 package/php/php.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/php/php.mk +4 -0
index 10c314f..f31217e 100644
@@ -36,6 +36,10 @@ ifneq ($(BR2_INET_IPV6),y)
 endif
 endif
 
+ifeq ($(BR2_xtensa),y)
+PHP_CFLAGS += -mtext-section-literals
+endif
+
 PHP_CONF_OPT += $(if $(BR2_PACKAGE_PHP_CLI),,--disable-cli)
 PHP_CONF_OPT += $(if $(BR2_PACKAGE_PHP_CGI),,--disable-cgi)
 
Signature · 1 line
1.8.5.2
#2 lore raw

PATCH 2/3 lmbench: fix build for xtensa

In reply to Baruch Siach

The lmbench package generates a binary that is too large for the xtensa default placement of literals in a dedicated section. Use -mtext-section-literal to place literals in the text section.

Fixes
http://autobuild.buildroot.net/results/afe/afe9f4550e6ac9a41e4ba338773c1d51034273f7/.

---
 package/lmbench/lmbench.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/lmbench/lmbench.mk +4 -0
index c3a6c09..529026f 100644
@@ -19,6 +19,10 @@ LMBENCH_CFLAGS += -I$(STAGING_DIR)/usr/include/tirpc/
 LMBENCH_LDFLAGS += -ltirpc
 endif
 
+ifeq ($(BR2_xtensa),y)
+LMBENCH_CFLAGS += -mtext-section-literals
+endif
+
 define LMBENCH_CONFIGURE_CMDS
 	$(call CONFIG_UPDATE,$(@D))
 	sed -i 's/CFLAGS=/CFLAGS+=/g' $(@D)/src/Makefile
Signature · 1 line
1.8.5.2
#3 lore raw

PATCH 3/3 civetweb: fix build for xtensa

In reply to Baruch Siach

The civetweb package bundled sqlite3 generates an object that is too large for the xtensa default placement of literals in a dedicated section. Use -mtext-section-literal to place literals in the text section.

Fixes
http://autobuild.buildroot.net/results/d14/d142f3ce17ab22cc39f9117c114318c1b5cadfc5/.

---
 package/civetweb/civetweb.mk | 3 +++
 1 file changed, 3 insertions(+)
package/civetweb/civetweb.mk +3 -0
index 4c8f4e8..b950890 100644
@@ -25,6 +25,9 @@ endif
 
 ifeq ($(BR2_CIVETWEB_WITH_LUA),y)
 	CIVETWEB_CONF_OPT += WITH_LUA=1
+ifeq ($(BR2_xtensa),y)
+	CIVETWEB_COPT += -mtext-section-literals
+endif
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
Signature · 1 line
1.8.5.2
#4 lore raw

cover xtensa build fixes using -mtext-section-literal

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 9 lines · Baruch Siach

These fixes are all similar. As the helpful linker error message says, xtensa needs -mtext-section-literal when building too large objects/libraries/binaries. So just do as we are told to.

Baruch Siach (3):
php: fix build for xtensa
lmbench: fix build for xtensa
civetweb: fix build for xtensa

Quoted 4 lines
 package/civetweb/civetweb.mk | 3 +++
 package/lmbench/lmbench.mk   | 4 ++++
 package/php/php.mk           | 4 ++++
 3 files changed, 11 insertions(+)

All three patches applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

cover xtensa build fixes using -mtext-section-literal

Hi Thomas,

Quoted 10 lines · Thomas Petazzoni
Quoted 9 lines · Baruch Siach

These fixes are all similar. As the helpful linker error message says, xtensa needs -mtext-section-literal when building too large objects/libraries/binaries. So just do as we are told to.

Baruch Siach (3):
php: fix build for xtensa
lmbench: fix build for xtensa
civetweb: fix build for xtensa

Quoted 6 lines
Quoted 4 lines
 package/civetweb/civetweb.mk | 3 +++
 package/lmbench/lmbench.mk   | 4 ++++
 package/php/php.mk           | 4 ++++
 3 files changed, 11 insertions(+)

All three patches applied, thanks.

Thanks.

Please also apply http://patchwork.ozlabs.org/patch/305647/ (iozone: add fix for missing pthread_setaffinity_np()). It fixes iozone build for xtensa as well
(http://autobuild.buildroot.net/results/d54/d54012d167dc7f70c796a109f7fc659690b5c548/).

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#6 lore raw

cover xtensa build fixes using -mtext-section-literal

Dear Baruch Siach,

Quoted 4 lines · Baruch Siach

Please also apply http://patchwork.ozlabs.org/patch/305647/ (iozone: add fix for missing pthread_setaffinity_np()). It fixes iozone build for xtensa as well
(http://autobuild.buildroot.net/results/d54/d54012d167dc7f70c796a109f7fc659690b5c548/).

Thanks, applied.

Note that if you want me to apply some patches that are pending, the best way is to give your formal Acked-by or Tested-by.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com