Skip to contentSkip to conversation

Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

PATCH Superseded Pali Rohár 5 participants 20 messages May 3, 2014 – Jul 8, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

This patch series add dell-smo8800.ko driver and update program hpfall.c

Pali Rohár (2):
platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI

    SMO8800/SMO8810)

Documentation: Rename hpfall.c => freefall.c, fixes for Dell

 Documentation/laptops/00-INDEX      |    4 +-
 Documentation/laptops/freefall.c    |  171 +++++++++++++++++++++++
 Documentation/laptops/hpfall.c      |  146 --------------------
 drivers/platform/x86/Kconfig        |   10 ++
 drivers/platform/x86/Makefile       |    1 +
 drivers/platform/x86/dell-smo8800.c |  253 +++++++++++++++++++++++++++++++++++
 6 files changed, 437 insertions(+), 148 deletions(-)
 create mode 100644 Documentation/laptops/freefall.c
 delete mode 100644 Documentation/laptops/hpfall.c
 create mode 100644 drivers/platform/x86/dell-smo8800.c
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/2 platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

This acpi driver provide supports for freefall sensors SMO8800/SMO8810 which can be found on Dell Latitude laptops. Driver register /dev/freefall misc device which has same interface as driver hp_accel freefall driver. So any existing applications for HP freefall sensor /dev/freefall will work for with this new driver for Dell Latitude laptops too.

---
 drivers/platform/x86/Kconfig        |   10 ++
 drivers/platform/x86/Makefile       |    1 +
 drivers/platform/x86/dell-smo8800.c |  253 +++++++++++++++++++++++++++++++++++
 3 files changed, 264 insertions(+)
 create mode 100644 drivers/platform/x86/dell-smo8800.c
drivers/platform/x86/Kconfig +10 -0
index 27df2c5..f0c2e45 100644
@@ -127,6 +127,16 @@ config DELL_WMI_AIO
 	  To compile this driver as a module, choose M here: the module will
 	  be called dell-wmi-aio.
 
+config DELL_SMO8800
+	tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+	depends ON ACPI
+	---help---
+	  Say Y here if you want to support SMO8800/SMO8810 freefall device
+	  on Dell Latitude laptops.
+
+	  To compile this driver as a module, choose M here: the module will
+	  be called dell-smo8800.
+
 
 config FUJITSU_LAPTOP
 	tristate "Fujitsu Laptop Extras"
drivers/platform/x86/Makefile +1 -0
index 1a2eafc..c4ca428 100644
@@ -13,6 +13,7 @@ obj-$(CONFIG_COMPAL_LAPTOP)	+= compal-laptop.o
 obj-$(CONFIG_DELL_LAPTOP)	+= dell-laptop.o
 obj-$(CONFIG_DELL_WMI)		+= dell-wmi.o
 obj-$(CONFIG_DELL_WMI_AIO)	+= dell-wmi-aio.o
+obj-$(CONFIG_DELL_SMO8800)	+= dell-smo8800.o
 obj-$(CONFIG_ACER_WMI)		+= acer-wmi.o
 obj-$(CONFIG_ACERHDF)		+= acerhdf.o
 obj-$(CONFIG_HP_ACCEL)		+= hp_accel.o
drivers/platform/x86/dell-smo8800.c new file +253 -0

253 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

drivers/platform/x86/dell-smo8800.c line 49

Quoted 12 lines
drivers/platform/x86/dell-smo8800.c new file +12 -0
+static irqreturn_t smo8800_interrupt_quick(int irq, void *data)
+{
+	struct smo8800_device *smo8800 = data;
+	atomic_inc(&smo8800->count);
+	wake_up_interruptible(&smo8800->misc_wait);
+	return IRQ_WAKE_THREAD;
+}
+
+static irqreturn_t smo8800_interrupt_thread(int irq, void *data)
+{
+	struct smo8800_device *smo8800 = data;
+	dev_info(smo8800->dev, "detected free fall\n");

printk should be fast enough not to justify a thread, in fact the threaded IRQ overhead is going to be higher than the printk IMHO.

I'm not entirely sure a printk is the useful response here either ?

drivers/platform/x86/dell-smo8800.c line 96

Quoted 13 lines
drivers/platform/x86/dell-smo8800.c new file +13 -0
+static ssize_t smo8800_misc_read(struct file *file, char __user *buf,
+				 size_t count, loff_t *pos)
+{
+	struct smo8800_device *smo8800 = container_of(file->private_data,
+					 struct smo8800_device, miscdev);
+
+	DECLARE_WAITQUEUE(wait, current);
+	u32 data;
+	unsigned char byte_data;
+	ssize_t retval = 1;
+
+	if (count < 1)
+		return -EINVAL;

How can this occur ??

Quoted 10 lines
drivers/platform/x86/dell-smo8800.c new file +10 -0
+
+	add_wait_queue(&smo8800->misc_wait, &wait);
+	while (true) {
+		set_current_state(TASK_INTERRUPTIBLE);
+		data = atomic_xchg(&smo8800->count, 0);
+		if (data)
+			break;
+
+		if (file->f_flags & O_NONBLOCK) {
+			retval = -EAGAIN;

drivers/platform/x86/dell-smo8800.c line 116

Quoted 10 lines
drivers/platform/x86/dell-smo8800.c new file +10 -0
+			goto out;
+		}
+
+		if (signal_pending(current)) {
+			retval = -ERESTARTSYS;
+			goto out;
+		}
+
+		schedule();
+	}

wait_event_interruptible ?

drivers/platform/x86/dell-smo8800.c line 127

Quoted 2 lines
drivers/platform/x86/dell-smo8800.c new file +2 -0
+	if (copy_to_user(buf, &byte_data, sizeof(byte_data)))
+		retval = -EFAULT;

put_user

drivers/platform/x86/dell-smo8800.c line 170

Quoted 7 lines
drivers/platform/x86/dell-smo8800.c new file +7 -0
+static int smo8800_add(struct acpi_device *device)
+{
+	int err;
+	struct smo8800_device *smo8800;
+
+	if (!device)
+		return -EINVAL;

How can this occur ??

Review

Quoted 1 line
(quoted diff) +1 -0
+	atomic_set(&smo8800->count, 0);

Not needed - you can't see a count until it is open

drivers/platform/x86/dell-smo8800.c line 213

Quoted 2 lines
drivers/platform/x86/dell-smo8800.c new file +2 -0
+	dev_info(&device->dev, "device /dev/freefall registered with IRQ %d\n",
+		 smo8800->irq);

dev_dbg would be more appropriate. If every driver reported its registration we'd drown in logs

drivers/platform/x86/dell-smo8800.c line 226

Quoted 1 line
drivers/platform/x86/dell-smo8800.c new file +1 -0
+	dev_info(&device->dev, "device /dev/freefall unregistered\n");

Ditto

Alan

Tested-by Acked-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

In reply to Pali Rohár
Quoted 5 lines · Pali Rohár

This acpi driver provide supports for freefall sensors SMO8800/SMO8810 which can be found on Dell Latitude laptops. Driver register /dev/freefall misc device which has same interface as driver hp_accel freefall driver. So any existing applications for HP freefall sensor /dev/freefall will work for with this new driver for Dell Latitude laptops too.

So just for grins, I tossed this patchset on top of next-20140519, and it actually works on my Dell Latitude E6530. Tested with a controlled drop of 3-4 inches, and I get the distinctive sound of a head park, and the following in /var/log/messages:

May 20 02:46:22 turing-police kernel: [18839.158926] smo8800 SMO8810:00: detected free fall
May 20 02:46:22 turing-police FREE FALL[1337]: Parked /dev/sda disk head
May 20 02:46:24 turing-police FREE FALL[1337]: Unparked /dev/sda disk head

I did a quick read-through of the code, looks OK. checkpatch complains about missing blank lines after declarations in 3-4 places. Sparse and gcc have no complaints. We've certainly merged much uglier code. And it certainly makes the world a better place for us Dell users.

So it's OK by me if Pali adds this to the signoffs after fixing the checkpatch and the one serious nit below....

One nit:

drivers/platform/x86/Kconfig config DELL_WMI_AIO · line 132

Quoted 9 lines
drivers/platform/x86/Kconfig +3 -0
@@ -127,6 +127,16 @@ config DELL_WMI_AIO
 	  To compile this driver as a module, choose M here: the module will
 	  be called dell-wmi-aio.
 
+config DELL_SMO8800
+	tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+	depends ON ACPI

Lowercase ON. Not sure how this escaped, Kbuild barfs on it.

#4 lore raw

Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

Quoted 20 lines · On Tuesday 20 May 2014 09:00:05 [email protected] wrote:
Quoted 7 lines · Pali Rohár

This acpi driver provide supports for freefall sensors SMO8800/SMO8810 which can be found on Dell Latitude laptops. Driver register /dev/freefall misc device which has same interface as driver hp_accel freefall driver. So any existing applications for HP freefall sensor /dev/freefall will work for with this new driver for Dell Latitude laptops too.

So just for grins, I tossed this patchset on top of next-20140519, and it actually works on my Dell Latitude E6530. Tested with a controlled drop of 3-4 inches, and I get the distinctive sound of a head park, and the following in /var/log/messages:

May 20 02:46:22 turing-police kernel: [18839.158926] smo8800

SMO8810:00: detected free fall May 20 02:46:22 turing-police FREE FALL[1337]: Parked /dev/sda disk head May 20 02:46:24 turing-police FREE FALL[1337]: Unparked /dev/sda disk head

Quoted 6 lines

I did a quick read-through of the code, looks OK. checkpatch complains about missing blank lines after declarations in 3-4 places. Sparse and gcc have no complaints. We've certainly merged much uglier code. And it certainly makes the world a better place for us Dell users.

Hm? Which errors? Here is output from checkpacth:

total: 0 errors, 0 warnings, 276 lines checked

0001-platform-x86-dell-smo8800-Dell-Latitude-freefall-dri.patch has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 181 lines checked

0002-Documentation-Rename-hpfall.c-freefall.c-fixes-for-D.patch has no obvious style problems and is ready for submission.

Quoted 11 lines

So it's OK by me if Pali adds this to the signoffs after fixing the checkpatch and the one serious nit below....

One nit:

Quoted 4 lines
drivers/platform/x86/Kconfig +0 -0
@@ -127,6 +127,16 @@ config DELL_WMI_AIO
 
Quoted 8 lines
Quoted 6 lines
drivers/platform/x86/Kconfig +2 -0
 	  To compile this driver as a module, choose M here: the
 	  module will be called dell-wmi-aio.
 
+config DELL_SMO8800
+	tristate "Dell Latitude freefall driver (ACPI

SMO8800/SMO8810)" + depends ON ACPI

Lowercase ON. Not sure how this escaped, Kbuild barfs on it.

I will send new version with some changes from Sonal.

Signature · 2 lines
Pali Rohár
[email protected]
#5 lore raw

Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

Quoted 11 lines · Pali Rohár

Hm? Which errors? Here is output from checkpacth:

total: 0 errors, 0 warnings, 276 lines checked

0001-platform-x86-dell-smo8800-Dell-Latitude-freefall-dri.patch has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 181 lines checked

0002-Documentation-Rename-hpfall.c-freefall.c-fixes-for-D.patch has no obvious style problems and is ready for submission.

Hmm.. what tree are you building against? I wonder if your checkpatch is a different version than mine (next-20140519). What I see:

[/usr/src/linux-next] scripts/checkpatch.pl patches/freefall.1
WARNING: Missing a blank line after declarations #135: FILE: drivers/platform/x86/dell-smo8800.c:41:
+ struct smo8800_device *smo8800 = data;
+ atomic_inc(&smo8800->count);

WARNING: Missing a blank line after declarations #143: FILE: drivers/platform/x86/dell-smo8800.c:49:
+ struct smo8800_device *smo8800 = data;
+ dev_info(smo8800->dev, "detected free fall\n");

WARNING: Missing a blank line after declarations #318: FILE: drivers/platform/x86/dell-smo8800.c:224:
+ struct smo8800_device *smo8800 = device->driver_data;
+ free_irq(smo8800->irq, smo8800);

total: 0 errors, 3 warnings, 276 lines checked

patches/freefall.1 has style problems, please review.

[/usr/src/linux-next] scripts/checkpatch.pl patches/freefall.2
WARNING: Missing a blank line after declarations #126: FILE: Documentation/laptops/freefall.c:47:
+ int fd = open(unload_heads_path, O_RDONLY);
+ if (fd < 0) {

WARNING: Missing a blank line after declarations
#139: FILE: Documentation/laptops/freefall.c:60:
+ int fd = open(path, O_RDWR);
+ if (fd < 0) {

WARNING: Missing a blank line after declarations
#161: FILE: Documentation/laptops/freefall.c:82:
+ const char *str = (seconds == 0) ? "Unparked" : "Parked";
+ write_int(unload_heads_path, seconds*1000);

total: 0 errors, 3 warnings, 181 lines checked

#6 lore raw

Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

Quoted 9 lines · On Tuesday 20 May 2014 20:02:41 [email protected] wrote:
Quoted 8 lines · Pali Rohár

Hm? Which errors? Here is output from checkpacth:

total: 0 errors, 0 warnings, 276 lines checked

0001-platform-x86-dell-smo8800-Dell-Latitude-freefall-dri.pa tch has no obvious style problems and is ready for submission.

Quoted 8 lines
Quoted 5 lines

total: 0 errors, 0 warnings, 181 lines checked

0002-Documentation-Rename-hpfall.c-freefall.c-fixes-for-D.pa tch has no obvious style problems and is ready for submission.

Hmm.. what tree are you building against? I wonder if your checkpatch is a different version than mine (next-20140519).

I'm using up-to-date linus tree, git rev
60b5f90d0fac7585f1a43ccdad06787b97eda0ab

$ sha1sum scripts/checkpatch.pl
979ad287faf59d84d78825595ec97513a9d46fba  scripts/checkpatch.pl
Signature · 2 lines
Pali Rohár
[email protected]
#7 lore raw

Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

Quoted 5 lines · Pali Rohár
Quoted 2 lines

Hmm.. what tree are you building against? I wonder if your checkpatch is a different version than mine (next-20140519).

I'm using up-to-date linus tree, git rev
60b5f90d0fac7585f1a43ccdad06787b97eda0ab

Ah, OK. Linux-next tree has a bunch of changes to checkpatch.pl that will probably go into the Linus tree during the next merge window, and several of them address the "blank line after declarations" warning - they roughly tripled the number of checks made for that case....

#8 lore raw

PATCH v2 1/1 platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

In reply to Pali Rohár

This acpi driver provide supports for freefall sensors SMO8800/SMO8810 which can be found on Dell Latitude laptops. Driver register /dev/freefall misc device which has same interface as driver hp_accel freefall driver. So any existing applications for HP freefall sensor /dev/freefall will work for with this new driver for Dell Latitude laptops too.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations
* Fixed Lowercase ON in Kconfig
* Fixed Alan's review problems by Sonal Santan

---
 drivers/platform/x86/Kconfig        |   10 ++
 drivers/platform/x86/Makefile       |    1 +
 drivers/platform/x86/dell-smo8800.c |  233 +++++++++++++++++++++++++++++++++++
 3 files changed, 244 insertions(+)
 create mode 100644 drivers/platform/x86/dell-smo8800.c
drivers/platform/x86/Kconfig +10 -0
index 27df2c5..0e80401 100644
@@ -127,6 +127,16 @@ config DELL_WMI_AIO
 	  To compile this driver as a module, choose M here: the module will
 	  be called dell-wmi-aio.
 
+config DELL_SMO8800
+	tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+	depends on ACPI
+	---help---
+	  Say Y here if you want to support SMO8800/SMO8810 freefall device
+	  on Dell Latitude laptops.
+
+	  To compile this driver as a module, choose M here: the module will
+	  be called dell-smo8800.
+
 
 config FUJITSU_LAPTOP
 	tristate "Fujitsu Laptop Extras"
drivers/platform/x86/Makefile +1 -0
index 1a2eafc..c4ca428 100644
@@ -13,6 +13,7 @@ obj-$(CONFIG_COMPAL_LAPTOP)	+= compal-laptop.o
 obj-$(CONFIG_DELL_LAPTOP)	+= dell-laptop.o
 obj-$(CONFIG_DELL_WMI)		+= dell-wmi.o
 obj-$(CONFIG_DELL_WMI_AIO)	+= dell-wmi-aio.o
+obj-$(CONFIG_DELL_SMO8800)	+= dell-smo8800.o
 obj-$(CONFIG_ACER_WMI)		+= acer-wmi.o
 obj-$(CONFIG_ACERHDF)		+= acerhdf.o
 obj-$(CONFIG_HP_ACCEL)		+= hp_accel.o
drivers/platform/x86/dell-smo8800.c new file +233 -0

233 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#9 lore raw

Re: [PATCH v2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

Quoted 16 lines · On Thursday 22 May 2014 13:15:48 Pali Rohár wrote:

This acpi driver provide supports for freefall sensors SMO8800/SMO8810 which can be found on Dell Latitude laptops. Driver register /dev/freefall misc device which has same interface as driver hp_accel freefall driver. So any existing applications for HP freefall sensor /dev/freefall will work for with this new driver for Dell Latitude laptops too.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations
* Fixed Lowercase ON in Kconfig
* Fixed Alan's review problems by Sonal Santan

Quoted 8 lines
---
 drivers/platform/x86/Kconfig        |   10 ++
 drivers/platform/x86/Makefile       |    1 +
 drivers/platform/x86/dell-smo8800.c |  233
+++++++++++++++++++++++++++++++++++ 3 files changed, 244
insertions(+)
 create mode 100644 drivers/platform/x86/dell-smo8800.c

After week there are no other objections.

Matthew Garrett, can you apply driver into platform tree?

Signature · 2 lines
Pali Rohár
[email protected]
#10 lore raw

Re: [PATCH v2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

Quoted 24 lines · On Wednesday 28 May 2014 15:31:30 Pali Rohár wrote:
Quoted 23 lines · On Thursday 22 May 2014 13:15:48 Pali Rohár wrote:

This acpi driver provide supports for freefall sensors SMO8800/SMO8810 which can be found on Dell Latitude laptops. Driver register /dev/freefall misc device which has same interface as driver hp_accel freefall driver. So any existing applications for HP freefall sensor /dev/freefall will work for with this new driver for Dell Latitude laptops too.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations
* Fixed Lowercase ON in Kconfig
* Fixed Alan's review problems by Sonal Santan
---

 drivers/platform/x86/Kconfig        |   10 ++
 drivers/platform/x86/Makefile       |    1 +
 drivers/platform/x86/dell-smo8800.c |  233
Quoted 8 lines
Quoted 4 lines

+++++++++++++++++++++++++++++++++++ 3 files changed, 244 insertions(+)

 create mode 100644 drivers/platform/x86/dell-smo8800.c

After week there are no other objections.

Matthew Garrett, can you apply driver into platform tree?

PING.

Signature · 2 lines
Pali Rohár
[email protected]
#11 lore raw

PATCH 2/2 Documentation: Rename hpfall.c => freefall.c, fixes for Dell

In reply to Pali Rohár

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  171 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146 --------------------------------
 3 files changed, 173 insertions(+), 148 deletions(-)
 create mode 100644 Documentation/laptops/freefall.c
 delete mode 100644 Documentation/laptops/hpfall.c
Documentation/laptops/00-INDEX +2 -2
index d13b9a9..d399ae1 100644
@@ -8,8 +8,8 @@ disk-shock-protection.txt
 	- information on hard disk shock protection.
 dslm.c
 	- Simple Disk Sleep Monitor program
-hpfall.c
-	- (HP) laptop accelerometer program for disk protection.
+freefall.c
+	- (HP/DELL) laptop accelerometer program for disk protection.
 laptop-mode.txt
 	- how to conserve battery power using laptop-mode.
 sony-laptop.txt
Documentation/laptops/freefall.c new file +171 -0

171 lines not on this page · raw message

Documentation/laptops/hpfall.c deleted +0 -146

146 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#12 lore raw

PATCH v2 1/1 Documentation: Rename hpfall.c => freefall.c, fixes for Dell

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations

---
 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  177 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146 -------------------------------
 3 files changed, 179 insertions(+), 148 deletions(-)
 create mode 100644 Documentation/laptops/freefall.c
 delete mode 100644 Documentation/laptops/hpfall.c
Documentation/laptops/00-INDEX +2 -2
index d13b9a9..d399ae1 100644
@@ -8,8 +8,8 @@ disk-shock-protection.txt
 	- information on hard disk shock protection.
 dslm.c
 	- Simple Disk Sleep Monitor program
-hpfall.c
-	- (HP) laptop accelerometer program for disk protection.
+freefall.c
+	- (HP/DELL) laptop accelerometer program for disk protection.
 laptop-mode.txt
 	- how to conserve battery power using laptop-mode.
 sony-laptop.txt
Documentation/laptops/freefall.c new file +177 -0

177 lines not on this page · raw message

Documentation/laptops/hpfall.c deleted +0 -146

146 lines not on this page · raw message

Signature · 1 line
1.7.9.5
Acked-by on v2 1/1
#13 lore raw

Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell

Quoted 13 lines · Pali Roh?r

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations

Quoted 7 lines
---
 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  177 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146 -------------------------------
 3 files changed, 179 insertions(+), 148 deletions(-)
 create mode 100644 Documentation/laptops/freefall.c
 delete mode 100644 Documentation/laptops/hpfall.c

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#14 lore raw

Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell

Quoted 27 lines · On Saturday 14 June 2014 10:53:29 Pavel Machek wrote:
Quoted 17 lines · Pali Roh?r

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations
---

Quoted 8 lines
 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  177
 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146

------------------------------- 3 files changed, 179 insertions(+), 148 deletions(-) create mode 100644 Documentation/laptops/freefall.c delete mode 100644 Documentation/laptops/hpfall.c

Quoted 3 lines

Pavel

Randy, Matthew: PING

first patch which implementing dell-smo8800.ko was merged, but this patch which updating documentation and fall daemon *not*.

Signature · 2 lines
Pali Rohár
[email protected]
#15 lore raw

Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell

Quoted 28 lines · On Monday 16 June 2014 13:55:03 Pali Rohár wrote:
Quoted 27 lines · On Saturday 14 June 2014 10:53:29 Pavel Machek wrote:
Quoted 25 lines · Pali Roh?r

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations
---

 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  177
 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146

------------------------------- 3 files changed, 179 insertions(+), 148 deletions(-) create mode 100644 Documentation/laptops/freefall.c delete mode 100644 Documentation/laptops/hpfall.c

Quoted 8 lines
Quoted 3 lines

Pavel

Randy, Matthew: PING

first patch which implementing dell-smo8800.ko was merged, but this patch which updating documentation and fall daemon *not*.

PING.

What is with this patch? Why was still not set to Linus in doc or platform pull request?

Signature · 2 lines
Pali Rohár
[email protected]
reviewer
#16 lore raw

Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell

Quoted 35 lines · Pali Rohár
Quoted 34 lines · On Monday 16 June 2014 13:55:03 Pali Rohár wrote:
Quoted 27 lines · On Saturday 14 June 2014 10:53:29 Pavel Machek wrote:
Quoted 17 lines · Pali Roh?r

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations
---

Quoted 8 lines
 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  177
 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146

------------------------------- 3 files changed, 179 insertions(+), 148 deletions(-) create mode 100644 Documentation/laptops/freefall.c delete mode 100644 Documentation/laptops/hpfall.c

Quoted 3 lines

Pavel

Randy, Matthew: PING

Quoted 8 lines
Quoted 2 lines

first patch which implementing dell-smo8800.ko was merged, but this patch which updating documentation and fall daemon *not*.

PING.

What is with this patch? Why was still not set to Linus in doc or platform pull request?

Sorry, I was on vacation this week, but that does not explain the previous delays.

I'll merge it sometime this weekend.

Thanks.

Signature · 1 line
~Randy
reviewer
#17 lore raw

Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell

In reply to Pali Rohár

Hi,

This should really be done as 2 separate patches:
One to move/rename the file and one to make the changes/additions to it for DELL.

Can you resend it as 2 patches like that, please?

Thanks... and sorry for the delay.

Quoted 20 lines · Pali Rohár

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations

---
 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  177 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146 -------------------------------
 3 files changed, 179 insertions(+), 148 deletions(-)
 create mode 100644 Documentation/laptops/freefall.c
 delete mode 100644 Documentation/laptops/hpfall.c
Signature · 1 line
~Randy
#18 lore raw

Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell

Hello Randy, sorry but now I do not have any free time...

Quoted 36 lines · On Sunday 29 June 2014 04:12:17 Randy Dunlap wrote:

Hi,

This should really be done as 2 separate patches:
One to move/rename the file and one to make the
changes/additions to it for DELL.

Can you resend it as 2 patches like that, please?

Thanks... and sorry for the delay.

Quoted 25 lines · Pali Rohár

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations
---

 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  177
 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146

------------------------------- 3 files changed, 179 insertions(+), 148 deletions(-) create mode 100644 Documentation/laptops/freefall.c delete mode 100644 Documentation/laptops/hpfall.c

Signature · 2 lines
Pali Rohár
[email protected]
reviewer
#19 lore raw

Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell

Quoted 1 line · Pali Rohár

Hello Randy, sorry but now I do not have any free time...

a. It took me 7 minutes to split the patch into 2 patches as I requested.

b. In the future please do it like that.

c. Pavel asked me to go ahead and apply the patch. I will do that since I have a few other patches to hpfall.c (freefall.c) that need to be applied.

Quoted 38 lines · On Sunday 29 June 2014 04:12:17 Randy Dunlap wrote:
Quoted 36 lines

Hi,

This should really be done as 2 separate patches:
One to move/rename the file and one to make the
changes/additions to it for DELL.

Can you resend it as 2 patches like that, please?

Thanks... and sorry for the delay.

Quoted 25 lines · Pali Rohár

Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c.

Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if hp::hddprotect does not exist in sysfs.

Additionally write info to syslog.

---
Changes since v1:
* Fixed warnings: Missing a blank line after declarations
---

 Documentation/laptops/00-INDEX   |    4 +-
 Documentation/laptops/freefall.c |  177
 ++++++++++++++++++++++++++++++++++++++
 Documentation/laptops/hpfall.c   |  146

------------------------------- 3 files changed, 179 insertions(+), 148 deletions(-) create mode 100644 Documentation/laptops/freefall.c delete mode 100644 Documentation/laptops/hpfall.c

Signature · 1 line
~Randy