Skip to contentSkip to conversation

uclibc: snapshot: add BSD obsolete signal functions

PATCH New Baruch Siach 3 participants 4 messages Jan 2, 2014 – Jan 10, 2014

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 uclibc: snapshot: add BSD obsolete signal functions

Fixes
http://autobuild.buildroot.net/results/70b/70b79ca0aa97ed451a5679029955ed3709c84b67/.

Signed-off-by Baruch Siach <[email protected]>
---
 package/uclibc/uClibc-snapshot.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/uclibc/uClibc-snapshot.config +1 -1
index 9ca3f9ea983d..890aefd8ec59 100644
@@ -152,7 +152,7 @@ UCLIBC_LINUX_SPECIFIC=y
 UCLIBC_HAS_GNU_ERROR=y
 UCLIBC_BSD_SPECIFIC=y
 UCLIBC_HAS_BSD_ERR=y
-# UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is not set
+UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y
 # UCLIBC_HAS_OBSOLETE_SYSV_SIGNAL is not set
 # UCLIBC_NTP_LEGACY is not set
 # UCLIBC_SV4_DEPRECATED is not set
Signature · 1 line
1.8.5.2
#1 lore raw

PATCH 1/1 uclibc: snapshot: add BSD obsolete signal functions

Dear Baruch Siach,

Quoted 13 lines · Baruch Siach

Fixes
http://autobuild.buildroot.net/results/70b/70b79ca0aa97ed451a5679029955ed3709c84b67/.

Signed-off-by Baruch Siach <[email protected]>
---
 package/uclibc/uClibc-snapshot.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/uclibc/uClibc-snapshot.config +0 -0
index 9ca3f9ea983d..890aefd8ec59 100644

package/uclibc/uClibc-snapshot.config UCLIBC_LINUX_SPECIFIC=y · line 155

Quoted 5 lines
package/uclibc/uClibc-snapshot.config +1 -1
@@ -152,7 +152,7 @@ UCLIBC_LINUX_SPECIFIC=y
 UCLIBC_HAS_GNU_ERROR=y
 UCLIBC_BSD_SPECIFIC=y
 UCLIBC_HAS_BSD_ERR=y
-# UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is not set
+UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y

We don't have this option enabled in the uClibc-0.9.33.config. Is there a reason why it should be enabled for the uClibc-snapshot.config and not for uClibc-0.9.33.config ? Does netsnmp builds with uClibc 0.9.33 on some other architecture?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 uclibc: snapshot: add BSD obsolete signal functions

Hi Thomas,

Quoted 9 lines · Thomas Petazzoni
Quoted 8 lines · Baruch Siach

Fixes
http://autobuild.buildroot.net/results/70b/70b79ca0aa97ed451a5679029955ed3709c84b67/.

Signed-off-by Baruch Siach <[email protected]>
---
 package/uclibc/uClibc-snapshot.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

package/uclibc/uClibc-snapshot.config UCLIBC_LINUX_SPECIFIC=y · line 155

Quoted 10 lines
package/uclibc/uClibc-snapshot.config +1 -1
index 9ca3f9ea983d..890aefd8ec59 100644
@@ -152,7 +152,7 @@ UCLIBC_LINUX_SPECIFIC=y
 UCLIBC_HAS_GNU_ERROR=y
 UCLIBC_BSD_SPECIFIC=y
 UCLIBC_HAS_BSD_ERR=y
-# UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is not set
+UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y

We don't have this option enabled in the uClibc-0.9.33.config. Is there a reason why it should be enabled for the uClibc-snapshot.config and not for uClibc-0.9.33.config ? Does netsnmp builds with uClibc 0.9.33 on some other architecture?

The netsnmp configure scripts tests for sighold(). This test fails when UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is disabled. In this case the code in apps/snmpnetstat/if.c uses the alternative sigblock() API. This has been removed completely from uClibc after 0.9.33 with commit 5aa7aa7fa7ec2a (signal: remove sigblock, siggetmask and sigsetmask). That's why we need UCLIBC_HAS_OBSOLETE_BSD_SIGNAL for netsnmp to build only when uClibc snapshot is selected.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -