Skip to contentSkip to conversation

ASoC: imx: Allow using sound with DT descriptions only

PATCH Superseded Alexander Shiyan 3 participants 5 messages Jan 5, 2014 – Jan 6, 2014

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: imx: Allow using sound with DT descriptions only

This patch adds new Kconfig symbol to allow using generic sound cards/codecs based on DT description.

---
 sound/soc/fsl/Kconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)
sound/soc/fsl/Kconfig +10 -0
index bb4ab96..51fabc6 100644
@@ -126,6 +126,16 @@ config SND_SOC_IMX_PCM_DMA
 config SND_SOC_IMX_AUDMUX
 	tristate
 
+config SND_SOC_IMX_DT
+	tristate "SoC Audio support for i.MX DT boards"
+	depends on OF
+	select SND_SOC_FSL_SSI
+	select SND_SOC_IMX_AUDMUX
+	select SND_SOC_IMX_PCM_DMA
+	help
+	  Say Y if you want to add support for SoC audio on an i.MX boards
+	  described in devicetree.
+
 config SND_MXC_SOC_WM1133_EV1
 	tristate "Audio on the i.MX31ADS with WM1133-EV1 fitted"
 	depends on MACH_MX31ADS_WM1133_EV1
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 13 lines · Alexander Shiyan

This patch adds new Kconfig symbol to allow using generic sound cards/codecs based on DT description.

---
 sound/soc/fsl/Kconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)
sound/soc/fsl/Kconfig +0 -0
index bb4ab96..51fabc6 100644

sound/soc/fsl/Kconfig config SND_SOC_IMX_PCM_DMA · line 130

Quoted 5 lines
sound/soc/fsl/Kconfig +2 -0
@@ -126,6 +126,16 @@ config SND_SOC_IMX_PCM_DMA
 config SND_SOC_IMX_AUDMUX
 	tristate
 
+config SND_SOC_IMX_DT
+	tristate "SoC Audio support for i.MX DT boards"

"i.MX ASoC generic sound card support" would be better?

sound/soc/fsl/Kconfig config SND_SOC_IMX_PCM_DMA · line 131

Quoted 1 line
sound/soc/fsl/Kconfig +1 -0
+	depends on OF

It seems to me that we should depend on SND_SIMPLE_CARD and add OF dependency for SND_SIMPLE_CARD symbol?

Shawn

Quoted 13 lines
sound/soc/fsl/Kconfig +7 -0
+	select SND_SOC_FSL_SSI
+	select SND_SOC_IMX_AUDMUX
+	select SND_SOC_IMX_PCM_DMA
+	help
+	  Say Y if you want to add support for SoC audio on an i.MX boards
+	  described in devicetree.
+
 config SND_MXC_SOC_WM1133_EV1
 	tristate "Audio on the i.MX31ADS with WM1133-EV1 fitted"
 	depends on MACH_MX31ADS_WM1133_EV1
Signature · 1 line
1.8.3.2
#2 lore raw

Hello.

Quoted 21 lines
Quoted 13 lines

This patch adds new Kconfig symbol to allow using generic sound cards/codecs based on DT description.

---
 sound/soc/fsl/Kconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)
sound/soc/fsl/Kconfig +0 -0
index bb4ab96..51fabc6 100644

sound/soc/fsl/Kconfig config SND_SOC_IMX_PCM_DMA · line 130

Quoted 5 lines
sound/soc/fsl/Kconfig +2 -0
@@ -126,6 +126,16 @@ config SND_SOC_IMX_PCM_DMA
 config SND_SOC_IMX_AUDMUX
 	tristate
 
+config SND_SOC_IMX_DT
+	tristate "SoC Audio support for i.MX DT boards"

"i.MX ASoC generic sound card support" would be better?

Quoted 4 lines

sound/soc/fsl/Kconfig config SND_SOC_IMX_PCM_DMA · line 131

Quoted 1 line
sound/soc/fsl/Kconfig +1 -0
+	depends on OF

It seems to me that we should depend on SND_SIMPLE_CARD and add OF dependency for SND_SIMPLE_CARD symbol?

SND_SIMPLE_CARD can be used with pdata.
For i.MX non-DT boards the imx-ssi driver is used, but for OF - fsl-ssi only, so I think OF dependency should be still here.
Thanks.

---

maintainer
#3 lore raw
In reply to Alexander Shiyan

sound/soc/fsl/Kconfig config SND_SOC_IMX_PCM_DMA · line 138

Quoted 10 lines · Alexander Shiyan
sound/soc/fsl/Kconfig +10 -0
+config SND_SOC_IMX_DT
+	tristate "SoC Audio support for i.MX DT boards"
+	depends on OF
+	select SND_SOC_FSL_SSI
+	select SND_SOC_IMX_AUDMUX
+	select SND_SOC_IMX_PCM_DMA
+	help
+	  Say Y if you want to add support for SoC audio on an i.MX boards
+	  described in devicetree.
+

Rather than adding a separate Kconfig option it seems better to just move these to being selected by SND_IMX_SOC and delete all the extra selects from the individual machine drivers - I don't think it's worth worrying about building the extra driver for S/PDIF only systems and it's easier for users to work out what they need to set.

#4 lore raw

Hello.

Quoted 8 lines
Quoted 8 lines
sound/soc/fsl/Kconfig +8 -0
+config SND_SOC_IMX_DT
+	tristate "SoC Audio support for i.MX DT boards"
+	depends on OF
+	select SND_SOC_FSL_SSI
+	select SND_SOC_IMX_AUDMUX
+	select SND_SOC_IMX_PCM_DMA
+	help
+	  Say Y if you want to add support for SoC audio on an i.MX boards
Quoted 8 lines

sound/soc/fsl/Kconfig config SND_SOC_IMX_PCM_DMA · line 138

Quoted 2 lines
sound/soc/fsl/Kconfig +2 -0
+	  described in devicetree.
+

Rather than adding a separate Kconfig option it seems better to just move these to being selected by SND_IMX_SOC and delete all the extra selects from the individual machine drivers - I don't think it's worth worrying about building the extra driver for S/PDIF only systems and it's easier for users to work out what they need to set.

OK, probably this will be better.
Thanks.

---