Skip to contentSkip to conversation

ARM: shmobile: emev2: Use __initconst for const init definition

PATCH New Simon Horman 2 participants 2 messages Dec 27, 2013 – Jan 6, 2014

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Simon Horman

author
#0 lore raw

PATCH 1/1 ARM: shmobile: emev2: Use __initconst for const init definition

__initconst must be used instead of __initdata for const init definitions.

This problem was introduced by 3d5de27174955702 ("mach-shmobile: Emma Mobile EV2 DT support V3") in v3.4-rc7.

Reported-by Fengguang Wu <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/mach-shmobile/setup-emev2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-shmobile/setup-emev2.c +1 -1
index c8f2a1a..c71d667 100644
@@ -58,7 +58,7 @@ static void __init emev2_add_standard_devices_dt(void)
 	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
-static const char *emev2_boards_compat_dt[] __initdata = {
+static const char *emev2_boards_compat_dt[] __initconst = {
 	"renesas,emev2",
 	NULL,
 };
Signature · 1 line
1.8.4
#1 lore raw

PATCH 1/1 ARM: shmobile: emev2: Use __initconst for const init definition

Quoted 5 lines · Simon Horman

__initconst must be used instead of __initdata for const init definitions.

This problem was introduced by 3d5de27174955702 ("mach-shmobile: Emma Mobile EV2 DT support V3") in v3.4-rc7.

I have queued this up.

Quoted 23 lines
Reported-by Fengguang Wu <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/mach-shmobile/setup-emev2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-shmobile/setup-emev2.c +1 -1
index c8f2a1a..c71d667 100644
@@ -58,7 +58,7 @@ static void __init emev2_add_standard_devices_dt(void)
 	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
-static const char *emev2_boards_compat_dt[] __initdata = {
+static const char *emev2_boards_compat_dt[] __initconst = {
 	"renesas,emev2",
 	NULL,
 };
Signature · 1 line
1.8.4