added python unicode selection to menu
PATCH v2 1/1 added python unicode selection to menu
From: Matthew Weber <[email protected]>
This patch is based on the original new pkg patch submitted last Jan and is part of the "Patchwork oldest patches cleanup #5".
--
Changes v1 -> v2:
- None, resubmit after testing against current tip.
--- package/python/Config.in | 18 ++++++++++++++++++ package/python/python.mk | 6 ++++++ 2 files changed, 24 insertions(+), 0 deletions(-)
package/python/Config.in +18 -0
@@ -84,6 +84,24 @@ config BR2_PACKAGE_PYTHON_UNICODEDATA help Unicode character database (used by stringprep module) (large). +if BR2_PACKAGE_PYTHON_UNICODEDATA + +choice + prompt "Python unicode database format" + default BR2_PACKAGE_PYTHON_UCS2 + help + Select Python unicode database format for target + +config BR2_PACKAGE_PYTHON_UCS2 + bool "Universal Character Set 2-byte (UCS2)" + +config BR2_PACKAGE_PYTHON_UCS4 + bool "Universal Character Set 4-byte (UCS4)" + +endchoice + +endif + config BR2_PACKAGE_PYTHON_SQLITE bool "sqlite module" select BR2_PACKAGE_SQLITE
package/python/python.mk +6 -0
@@ -102,6 +102,12 @@ ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y) PYTHON_CONF_OPT += --disable-unicodedata endif +# Default is UCS2 w/o a conf opt +ifeq ($(BR2_PACKAGE_PYTHON_UCS4),y) +HOST_PYTHON_CONF_OPT += --enable-unicode=ucs4 +PYTHON_CONF_OPT += --enable-unicode=ucs4 +endif + ifeq ($(BR2_PACKAGE_PYTHON_BZIP2),y) PYTHON_DEPENDENCIES += bzip2 else
Signature · 1 line
1.7.1
PATCH v2 1/1 added python unicode selection to menu
Dear Matt Weber,
package/python/python.mk ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y) · line 109
Quoted 5 lines · Matt Weber
package/python/python.mk +5
-0+# Default is UCS2 w/o a conf opt +ifeq ($(BR2_PACKAGE_PYTHON_UCS4),y) +HOST_PYTHON_CONF_OPT += --enable-unicode=ucs4 +PYTHON_CONF_OPT += --enable-unicode=ucs4 +endif
Why is the selection of UCS4 for the target tied to the usage of UCS4 on the host?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 added python unicode selection to menu
Hi Thomas,
Thomas Petazzoni <[email protected]> wrote on 01/06/2014 11:23:16 PM:
Quoted 5 lines
From: Thomas Petazzoni <[email protected]>
To: Matt Weber <[email protected]>
Cc: buildroot at busybox.net
Date: 01/06/2014 11:23 PM
Subject: Re: [Buildroot] [PATCH v2] added python unicode selection to
menu
Quoted 5 lines
Dear Matt Weber,
On Mon, 6 Jan 2014 15:17:42 -0600, Matt Weber wrote:
Quoted 8 lines
package/python/python.mk ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y) · line 109
Quoted 5 lines
package/python/python.mk +5
-0+# Default is UCS2 w/o a conf opt +ifeq ($(BR2_PACKAGE_PYTHON_UCS4),y) +HOST_PYTHON_CONF_OPT += --enable-unicode=ucs4 +PYTHON_CONF_OPT += --enable-unicode=ucs4 +endifWhy is the selection of UCS4 for the target tied to the usage of UCS4 on the host?
No specific reason, other then we couldn't come up with a case where you could want the host different from the target.
Thanks!
Matt Weber
mlweber1 at rockwellcollins.com
Quoted 6 lines
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 added python unicode selection to menu
Dear Matthew Weber,
Quoted 5 lines · Matthew Weber
Quoted 2 lines
Why is the selection of UCS4 for the target tied to the usage of UCS4 on the host?
No specific reason, other then we couldn't come up with a case where you could want the host different from the target.
Normally, BR2_PACKAGE_<foo>_<bar> options are not supposed to affect the configuration of host packages.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 added python unicode selection to menu
Hi Thomas,
Thomas Petazzoni <[email protected]> wrote on 01/07/2014 09:13:36 AM:
Quoted 5 lines
From: Thomas Petazzoni <[email protected]>
To: "Matthew Weber" <[email protected]>
Cc: buildroot at busybox.net
Date: 01/07/2014 09:13 AM
Subject: Re: [Buildroot] [PATCH v2] added python unicode selection to
menu
Quoted 6 lines
Dear Matthew Weber,
Quoted 1 line · Matthew Weber
Quoted 1 line
Why is the selection of UCS4 for the target tied to the usage of
UCS4
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
on the host?
No specific reason, other then we couldn't come up with a case where you could want the host different from the target.
Normally, BR2_PACKAGE_<foo>_<bar> options are not supposed to affect the configuration of host packages.
Ok, we don't currently need support for that option in the host. So I'll remove it until someone has a use case.
Thanks
Matt
mlweber1 at rockwellcollins.com
Quoted 6 lines
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com