Skip to contentSkip to conversation

powerpc 8xx: defconfig: slice by 4 is more efficient than the default slice by 8 on Powerpc 8xx.

PATCH In review Christophe Leroy 2 participants 2 messages Nov 22, 2013 – Jan 8, 2014 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 powerpc 8xx: defconfig: slice by 4 is more efficient than the default slice by 8 on Powerpc 8xx.

On PPC_8xx, CRC32_SLICEBY4 is more efficient (almost twice) than CRC32_SLICEBY8, as shown below:

With CRC32_SLICEBY8:

[    1.109204] crc32: CRC_LE_BITS = 64, CRC_BE BITS = 64
[    1.114401] crc32: self tests passed, processed 225944 bytes in 15118910 nsec
[    1.130655] crc32c: CRC_LE_BITS = 64
[    1.134235] crc32c: self tests passed, processed 225944 bytes in 4479879 nsec

With CRC32_SLICEBY4:

[    1.097129] crc32: CRC_LE_BITS = 32, CRC_BE BITS = 32
[    1.101878] crc32: self tests passed, processed 225944 bytes in 8616242 nsec
[    1.116298] crc32c: CRC_LE_BITS = 32
[    1.119607] crc32c: self tests passed, processed 225944 bytes in 3289576 nsec
arch/powerpc/configs.new/adder875_defconfig renamed from arch/powerpc/configs/adder875_defconfig +1 -0
diff -ur a/arch/powerpc/configs/adder875_defconfig b/arch/powerpc/configs.new/adder875_defconfig
@@ -70,3 +70,4 @@
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_DEBUG_INFO=y
 # CONFIG_RCU_CPU_STALL_DETECTOR is not set
+CONFIG_CRC32_SLICEBY4=y
arch/powerpc/configs.new/ep88xc_defconfig renamed from arch/powerpc/configs/ep88xc_defconfig +1 -0
diff -ur a/arch/powerpc/configs/ep88xc_defconfig b/arch/powerpc/configs.new/ep88xc_defconfig
@@ -72,3 +72,4 @@
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_DEBUG_INFO=y
 # CONFIG_RCU_CPU_STALL_DETECTOR is not set
+CONFIG_CRC32_SLICEBY4=y
arch/powerpc/configs.new/mpc866_ads_defconfig renamed from arch/powerpc/configs/mpc866_ads_defconfig +1 -0
diff -ur a/arch/powerpc/configs/mpc866_ads_defconfig b/arch/powerpc/configs.new/mpc866_ads_defconfig
@@ -55,3 +55,4 @@
 CONFIG_CRC_CCITT=y
 # CONFIG_RCU_CPU_STALL_DETECTOR is not set
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
+CONFIG_CRC32_SLICEBY4=y
arch/powerpc/configs.new/mpc885_ads_defconfig renamed from arch/powerpc/configs/mpc885_ads_defconfig +1 -0
diff -ur a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs.new/mpc885_ads_defconfig
@@ -78,3 +78,4 @@
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_DEBUG_INFO=y
 # CONFIG_RCU_CPU_STALL_DETECTOR is not set
+CONFIG_CRC32_SLICEBY4=y
arch/powerpc/configs.new/tqm8xx_defconfig renamed from arch/powerpc/configs/tqm8xx_defconfig +1 -0
diff -ur a/arch/powerpc/configs/tqm8xx_defconfig b/arch/powerpc/configs.new/tqm8xx_defconfig
@@ -84,3 +84,4 @@
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_DEBUG_INFO=y
 # CONFIG_RCU_CPU_STALL_DETECTOR is not set
+CONFIG_CRC32_SLICEBY4=y
#1 lore raw
Quoted 22 lines · LEROY Christophe

On PPC_8xx, CRC32_SLICEBY4 is more efficient (almost twice) than CRC32_SLICEBY8, as shown below:

With CRC32_SLICEBY8:

[    1.109204] crc32: CRC_LE_BITS = 64, CRC_BE BITS = 64
[    1.114401] crc32: self tests passed, processed 225944 bytes in 15118910 nsec
[    1.130655] crc32c: CRC_LE_BITS = 64
[    1.134235] crc32c: self tests passed, processed 225944 bytes in 4479879 nsec

With CRC32_SLICEBY4:

[    1.097129] crc32: CRC_LE_BITS = 32, CRC_BE BITS = 32
[    1.101878] crc32: self tests passed, processed 225944 bytes in 8616242 nsec
[    1.116298] crc32c: CRC_LE_BITS = 32
[    1.119607] crc32c: self tests passed, processed 225944 bytes in 3289576 nsec

diff -ur a/arch/powerpc/configs/adder875_defconfig b/arch/powerpc/configs.new/adder875_defconfig

arch/powerpc/configs.new/adder875_defconfig line 73

Quoted 4 lines
arch/powerpc/configs.new/adder875_defconfig renamed from arch/powerpc/configs/adder875_defconfig +1 -0
@@ -70,3 +70,4 @@
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_DEBUG_INFO=y
 # CONFIG_RCU_CPU_STALL_DETECTOR is not set
+CONFIG_CRC32_SLICEBY4=y

When applying I got this:
error: arch/powerpc/configs.new/adder875_defconfig: does not exist in index
error: arch/powerpc/configs.new/ep88xc_defconfig: does not exist in index
error: arch/powerpc/configs.new/mpc866_ads_defconfig: does not exist in index
error: arch/powerpc/configs.new/mpc885_ads_defconfig: does not exist in index
error: arch/powerpc/configs.new/tqm8xx_defconfig: does not exist in index

I've fixed it, but please ensure that patches can be applied using "git am". I recommend using git to generate patches, but if you don't want to do so be sure that it's the "b" filename, not the "a" filename, that matches the tree.

-Scott