drivers/tty: ehv_bytechan fails to build as a module
PATCH 1/1 drivers/tty: ehv_bytechan fails to build as a module
ehv_bytechan is marked tristate but fails to build as a module:
drivers/tty/ehv_bytechan.c:363:1: error: type defaults to =E2=80=98int=E2= =80=99 in declaration of =E2=80=98console_initcall=E2=80=99 [-Werror=3Dimpl= icit-int]
It doesn't make much sense for a console driver to be built as a module, so change it to a bool.
---
Index: b/drivers/tty/Kconfig =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
drivers/tty/Kconfig +0 -0
@@ -366,7 +366,7 @@ config TRACE_SINK "Trace data router for MIPI P1149.7 cJTAG standard".
=20
config PPC_EPAPR_HV_BYTECHAN
- tristate "ePAPR hypervisor byte channel driver"
+ bool "ePAPR hypervisor byte channel driver"
depends on PPC
select EPAPR_PARAVIRT
help
Quoted 9 lines · Anton Blanchard
ehv_bytechanis marked tristate but fails to build as a module:
drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int]It doesn't make much sense for a console driver to be built as a module, so change it to a bool.
Signed-off-by Anton Blanchard <[email protected]>
Any comments on this patch ? The problem still causes powerpc:allmodconfig to fail.
Guenter
Quoted 16 lines
---
Index: b/drivers/tty/Kconfig
===================================================================drivers/tty/Kconfig +1
-1@@ -366,7 +366,7 @@ config TRACE_SINK "Trace data router for MIPI P1149.7 cJTAG standard". config PPC_EPAPR_HV_BYTECHAN - tristate "ePAPR hypervisor byte channel driver" + bool "ePAPR hypervisor byte channel driver" depends on PPC select EPAPR_PARAVIRT help
Quoted 5 lines · Guenter Roeck
Quoted 4 lines · Anton Blanchard
ehv_bytechanis marked tristate but fails to build as a module:
drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int]
Quoted 8 lines
Quoted 5 lines
It doesn't make much sense for a console driver to be built as a module, so change it to a bool.
Signed-off-by Anton Blanchard <[email protected]>Any comments on this patch ? The problem still causes powerpc:allmodconfig to fail.
It's fine with me...
Greg, are you going to take this via tty.git or do you want it to go via PPC?
-Scott
Quoted 23 lines
Guenter
Quoted 8 lines
---
Index: b/drivers/tty/Kconfig
===================================================================drivers/tty/Kconfig config TRACE_SINK · line 372
Quoted 8 lines
drivers/tty/Kconfig +1
-1@@ -366,7 +366,7 @@ config TRACE_SINK "Trace data router for MIPI P1149.7 cJTAG standard". config PPC_EPAPR_HV_BYTECHAN - tristate "ePAPR hypervisor byte channel driver" + bool "ePAPR hypervisor byte channel driver" depends on PPC select EPAPR_PARAVIRT help_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
Quoted 12 lines · Scott Wood
Quoted 11 lines · Guenter Roeck
Quoted 9 lines · Anton Blanchard
ehv_bytechanis marked tristate but fails to build as a module:
drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int]It doesn't make much sense for a console driver to be built as a module, so change it to a bool.
Signed-off-by Anton Blanchard <[email protected]>
Quoted 7 lines
Quoted 2 lines
Any comments on this patch ? The problem still causes powerpc:allmodconfig to fail.
It's fine with me...
Greg, are you going to take this via tty.git or do you want it to go via PPC?
Feel free to take it through PPC.