force devtmpfs and inotify kernel option when udev is used as dev handler
PATCH 1/1 force devtmpfs and inotify kernel option when udev is used as dev handler
---
patch suggested by Thomas Petazzoni
I also added devtmpfs because it's documented as needed but wasn't enforced
--- linux/linux.mk | 4 ++++ 1 file changed, 4 insertions(+)
linux/linux.mk +4 -0
@@ -185,6 +185,10 @@ define LINUX_CONFIGURE_CMDS $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)) $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV), $(call KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config)) + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV), + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)) $(if $(BR2_PACKAGE_KTAP), $(call KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config) $(call KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config)
Signature · 1 line
1.8.5.2
PATCH 1/1 force devtmpfs and inotify kernel option when udev is used as dev handler
J?r?my,
Quoted 15 lines · J?r?my Rosen
Signed-off-by J?r?my Rosen <[email protected]>---
patch suggested by Thomas PetazzoniI also added devtmpfs because it's documented as needed but wasn't enforced
--- linux/linux.mk | 4 ++++ 1 file changed, 4 insertions(+)linux/linux.mk +0
-0
linux/linux.mk define LINUX_CONFIGURE_CMDS · line 189
Quoted 5 lines
linux/linux.mk +2
-0@@ -185,6 +185,10 @@ define LINUX_CONFIGURE_CMDS $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)) $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV), $(call KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config)) + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV), + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
The above INOTIFY line has an extra leading space compared with the other lines.
Danomi -
Quoted 12 lines
linux/linux.mk +2
-1+ $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)) $(if $(BR2_PACKAGE_KTAP), $(call KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config) $(call KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config) --1.8.5.2
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 force devtmpfs and inotify kernel option when udev is used as dev handler
good catch, i'll wait for more feedback (if any) and then resend
Cordialement
J?r?my Rosen
+33 (0)1 42 68 28 04
fight key loggers : write some perl using vim
Open Wide Ingenierie
23, rue Daviel
75012 Paris - France
www.openwide.fr
----- Mail original -----
Quoted 51 lines
J?r?my,
Quoted 16 lines · J?r?my Rosen
Signed-off-by J?r?my Rosen <[email protected]>---
patch suggested by Thomas PetazzoniI also added devtmpfs because it's documented as needed but wasn't enforced
--- linux/linux.mk | 4 ++++ 1 file changed, 4 insertions(+)linux/linux.mk +0
-0linux/linux.mk define LINUX_CONFIGURE_CMDS · line 192
Quoted 8 lines
linux/linux.mk +2
-0@@ -185,6 +185,10 @@ define LINUX_CONFIGURE_CMDS $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)) $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV), $(call KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config)) + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV), + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)The above INOTIFY line has an extra leading space compared with the other lines.
Danomi -
Quoted 16 lines
linux/linux.mk +1
-0+ $(callKCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
+ $(call
KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))$(if $(BR2_PACKAGE_KTAP), $(call KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config) $(call KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config)--
1.8.5.2_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 force devtmpfs and inotify kernel option when udev is used as dev handler
In reply to Jérémy RosenDear J?r?my Rosen,
linux/linux.mk define LINUX_CONFIGURE_CMDS · line 191
Quoted 4 lines · J?r?my Rosen
linux/linux.mk +4
-0+ $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV), + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
These two last lines are not needed, we already have:
$(if $(BR2_ROOTFS_DEVICE_CREATION_STATIC),,
$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))Note the two commas at the end of the first line. It means that when BR2_ROOTFS_DEVICE_CREATION_STATIC is *NOT* enabled, then we enabled devtmpfs and devtmpfs_mount.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 force devtmpfs and inotify kernel option when udev is used as dev handler
----- Mail original -----
Quoted 18 lines
Dear J?r?my Rosen,
linux/linux.mk define LINUX_CONFIGURE_CMDS · line 191
Quoted 5 lines · J?r?my Rosen
(quoted diff) +2
-0+ $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV), + $(callKCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
linux/linux.mk +2
-0+ $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))These two last lines are not needed, we already have:
$(if $(BR2_ROOTFS_DEVICE_CREATION_STATIC),, $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config) $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
Quoted 4 lines
Note the two commas at the end of the first line. It means that when
BR2_ROOTFS_DEVICE_CREATION_STATICis *NOT* enabled, then we enabled devtmpfs anddevtmpfs_mount.
geez, I hate make syntax :(
thx for the catch, someday i'll learn.
Quoted 6 lines
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
PATCH 1/1 force devtmpfs and inotify kernel option when udev is used as dev handler
In reply to Jérémy RosenQuoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"J?r?my" == J?r?my Rosen <[email protected]> writes:
Signed-off-by J?r?my Rosen <[email protected]>---
patch suggested by Thomas PetazzoniI also added devtmpfs because it's documented as needed but wasn't enforced
--- linux/linux.mk | 4 ++++ 1 file changed, 4 insertions(+)linux/linux.mk +0
-0
linux/linux.mk define LINUX_CONFIGURE_CMDS · line 191
Quoted 7 lines
linux/linux.mk +4
-0@@ -185,6 +185,10 @@ define LINUX_CONFIGURE_CMDS $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)) $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV), $(call KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config)) + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV), + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
Committed with the indentation fixed and the unneeded devtmpfs handling removed, thanks.
Signature · 1 line
Bye, Peter Korsgaard