libnfc-llcp: rename to libllcp and bump version

PATCH Superseded Vicente Olivert Riera 5 participants 8 messages Jan 9, 2014 – Jan 11, 2014

Share & tools

Vicente Olivert Riera

author

2014-01-09 17:07 UTC #0 lore raw

PATCH 1/1 libnfc-llcp: rename to libllcp and bump version

This package has been renamed upstream to libllcp. Also, the current package we have in Buildroot fails to compile due to a version bump of it's main dependence, libnfc. A version bump is required because this package has been adapted upstream to work with libnfc-1.7.0-rc6.

Signed-off-by Vicente Olivert Riera <[email protected]>

---
 package/Config.in                          |    2 +-
 package/{libnfc-llcp => libllcp}/Config.in |    6 +++---
 package/libllcp/libllcp.mk                 |   15 +++++++++++++++
 package/libnfc-llcp/libnfc-llcp.mk         |   15 ---------------
 4 files changed, 19 insertions(+), 19 deletions(-)
 rename package/{libnfc-llcp => libllcp}/Config.in (56%)
 create mode 100644 package/libllcp/libllcp.mk
 delete mode 100644 package/libnfc-llcp/libnfc-llcp.mk

package/Config.in +1 -1

index 8af6a1e..ce9a130 100644
@@ -567,7 +567,7 @@ source "package/libhid/Config.in"
 source "package/libiqrf/Config.in"
 source "package/libmbim/Config.in"
 source "package/libnfc/Config.in"
-source "package/libnfc-llcp/Config.in"
+source "package/libllcp/Config.in"
 source "package/libqmi/Config.in"
 source "package/libraw1394/Config.in"
 source "package/libserial/Config.in"

package/libllcp/Config.in renamed from package/libnfc-llcp/Config.in +3 -3

similarity index 56%
rename from package/libnfc-llcp/Config.in
rename to package/libllcp/Config.in
index f557926..e5b2108 100644
@@ -1,9 +1,9 @@
-config BR2_PACKAGE_LIBNFC_LLCP
-	bool "libnfc-llcp"
+config BR2_PACKAGE_LIBLLCP
+	bool "libllcp"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
 	select BR2_PACKAGE_LIBNFC
 	help
 	  Library extending libnfc with support for Logical Link Control
 	  Protocol.
 
-	  http://code.google.com/p/nfc-tools/source/browse/trunk/libnfc-llcp/
+	  https://code.google.com/p/libllcp/

package/libllcp/libllcp.mk new file +15 -0

new file mode 100644
index 0000000..4a3c2c4
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libllcp
+#
+################################################################################
+
+LIBLLCP_VERSION = cf0c4b3c9df98851c6092c130192130c3f5a46bd
+LIBLLCP_SITE = https://libllcp.googlecode.com/git/
+LIBLLCP_SITE_METHOD = git
+LIBLLCP_DEPENDENCIES = libnfc
+LIBLLCP_AUTORECONF = YES
+LIBLLCP_AUTORECONF_OPT = --install --force --verbose
+LIBLLCP_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))

package/libnfc-llcp/libnfc-llcp.mk deleted +0 ~~-15~~

deleted file mode 100644
index d410b55..0000000
@@ -1,15 +0,0 @@
-################################################################################
-#
-# libnfc-llcp
-#
-################################################################################
-
-LIBNFC_LLCP_VERSION = 1103
-LIBNFC_LLCP_SITE = http://nfc-tools.googlecode.com/svn/trunk/libnfc-llcp/
-LIBNFC_LLCP_SITE_METHOD = svn
-LIBNFC_LLCP_DEPENDENCIES = libnfc
-LIBNFC_LLCP_AUTORECONF = YES
-LIBNFC_LLCP_AUTORECONF_OPT = --install --force --verbose
-LIBNFC_LLCP_INSTALL_STAGING = YES
-
-$(eval $(autotools-package))

Signature · 1 line

1.7.1

Yann E. MORIN

2014-01-09 17:42 UTC #1 lore raw

PATCH 1/1 libnfc-llcp: rename to libllcp and bump version

Vicente, All,

On 2014-01-09 17:07 +0000, Vicente Olivert Riera spake thusly:

Quoted 21 lines

This package has been renamed upstream to libllcp. Also, the current package we have in Buildroot fails to compile due to a version bump of it's main dependence, libnfc. A version bump is required because this package has been adapted upstream to work with libnfc-1.7.0-rc6.
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/Config.in                          |    2 +-
 package/{libnfc-llcp => libllcp}/Config.in |    6 +++---
 package/libllcp/libllcp.mk                 |   15 +++++++++++++++
 package/libnfc-llcp/libnfc-llcp.mk         |   15 ---------------
 4 files changed, 19 insertions(+), 19 deletions(-)
 rename package/{libnfc-llcp => libllcp}/Config.in (56%)
 create mode 100644 package/libllcp/libllcp.mk
 delete mode 100644 package/libnfc-llcp/libnfc-llcp.mk
package/Config.in +0 -0
index 8af6a1e..ce9a130 100644

package/Config.in source "package/libhid/Config.in" · line 570

Quoted 5 lines

package/Config.in +1 -1

@@ -567,7 +567,7 @@ source "package/libhid/Config.in"
 source "package/libiqrf/Config.in"
 source "package/libmbim/Config.in"
 source "package/libnfc/Config.in"
-source "package/libnfc-llcp/Config.in"
+source "package/libllcp/Config.in"

Keep the alphabetical order (ie. move it between libiqrf and libmbim).

Quoted 7 lines

package/libllcp/libllcp.mk new file +1 -0

new file mode 100644
index 0000000..4a3c2c4
@@ -0,0 +1,15 @@
+################################################################################

package/libllcp/libllcp.mk line 11

Quoted 10 lines

package/libllcp/libllcp.mk new file +10 -0

+#
+# libllcp
+#
+################################################################################
+
+LIBLLCP_VERSION = cf0c4b3c9df98851c6092c130192130c3f5a46bd
+LIBLLCP_SITE = https://libllcp.googlecode.com/git/
+LIBLLCP_SITE_METHOD = git
+LIBLLCP_DEPENDENCIES = libnfc
+LIBLLCP_AUTORECONF = YES

It's not obvious why AUTORECONF is needed, so just add a small note, like:
# There's no ./configure is the repository, so we need to autoreconf LIBLLCP_AUTORECONF = YES

package/libllcp/libllcp.mk line 12

Quoted 1 line

package/libllcp/libllcp.mk new file +1 -0
+LIBLLCP_AUTORECONF_OPT = --install --force --verbose

Are those autoreconf opts still needed with this new version?

Also, please add the licensing terms while you are at it:
LIBLLCP_LICENSE = GPLv3+ LIBLLCP_LICENSE_FILES = COPYING

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Baruch Siach

2014-01-09 17:43 UTC #2 lore raw

PATCH 1/1 libnfc-llcp: rename to libllcp and bump version

In reply to Vicente Olivert Riera

Hi Vicente,

Quoted 21 lines · Vicente Olivert Riera

This package has been renamed upstream to libllcp. Also, the current package we have in Buildroot fails to compile due to a version bump of it's main dependence, libnfc. A version bump is required because this package has been adapted upstream to work with libnfc-1.7.0-rc6.
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/Config.in                          |    2 +-
 package/{libnfc-llcp => libllcp}/Config.in |    6 +++---
 package/libllcp/libllcp.mk                 |   15 +++++++++++++++
 package/libnfc-llcp/libnfc-llcp.mk         |   15 ---------------
 4 files changed, 19 insertions(+), 19 deletions(-)
 rename package/{libnfc-llcp => libllcp}/Config.in (56%)
 create mode 100644 package/libllcp/libllcp.mk
 delete mode 100644 package/libnfc-llcp/libnfc-llcp.mk
package/Config.in +0 -0
index 8af6a1e..ce9a130 100644

package/Config.in source "package/libhid/Config.in" · line 570

Quoted 5 lines

package/Config.in +1 -1

@@ -567,7 +567,7 @@ source "package/libhid/Config.in"
 source "package/libiqrf/Config.in"
 source "package/libmbim/Config.in"
 source "package/libnfc/Config.in"
-source "package/libnfc-llcp/Config.in"
+source "package/libllcp/Config.in"

It seems that the order should change as well to keep the list alphabetically ordered.

baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Thomas Petazzoni

2014-01-09 23:23 UTC #3 lore raw

PATCH 1/1 libnfc-llcp: rename to libllcp and bump version

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

package/libllcp/Config.in line 2

Quoted 4 lines · Vicente Olivert Riera

package/libllcp/Config.in renamed from package/libnfc-llcp/Config.in +2 -2
-config BR2_PACKAGE_LIBNFC_LLCP
-	bool "libnfc-llcp"
+config BR2_PACKAGE_LIBLLCP
+	bool "libllcp"

You're renaming an option which I believe was part of a Buildroot release, so please add the necessary Config.in.legacy stuff to ensure that users upgrading are notified of this change.

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Vicente Olivert Riera

author

2014-01-10 10:07 UTC #4 lore raw

PATCH 1/1 libnfc-llcp: rename to libllcp and bump version

Quoted 13 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,
package/libllcp/Config.in line 2
Quoted 4 lines · Vicente Olivert Riera
package/libllcp/Config.in renamed from package/libnfc-llcp/Config.in +2 -2
-config BR2_PACKAGE_LIBNFC_LLCP
-	bool "libnfc-llcp"
+config BR2_PACKAGE_LIBLLCP
+	bool "libllcp"
You're renaming an option which I believe was part of a Buildroot release, so please add the necessary Config.in.legacy stuff to ensure that users upgrading are notified of this change.

Quoted 4 lines

Thanks!
Thomas

v3 sent. Thanks for your comments.

Signature · 1 line

Vincent

Arnout Vandecappelle

2014-01-10 06:04 UTC #5 lore raw

PATCH 1/1 libnfc-llcp: rename to libllcp and bump version

In reply to Vicente Olivert Riera

Quoted 1 line · Vicente Olivert Riera

This package has been renamed upstream to libllcp.

This is not sufficient reason to rename the package in buildroot as
well. Renaming makes it difficult for people to follow buildroot upstream with their configurations.

Also, if any existing symbol is removed (or renamed), entries have to
be added to Config.in.legacy. This makes is slightly easier for users to maintain buildroot configurations, but it's still annoying so renaming of symbols should be done with care.

It _is_ an option to still rename it in the menu. I'm not entirely sure
what should be done with the alphabetical ordering in that case - probably follow the visible name, not the internal name.

Regards,
Arnout

Quoted 15 lines

Also, the current
package we have in Buildroot fails to compile due to a version bump of it's main dependence, libnfc. A version bump is required because this package has been adapted upstream to work with libnfc-1.7.0-rc6.
Signed-off-by Vicente Olivert Riera<[email protected]>
---
  package/Config.in                          |    2 +-
  package/{libnfc-llcp => libllcp}/Config.in |    6 +++---
  package/libllcp/libllcp.mk                 |   15 +++++++++++++++
  package/libnfc-llcp/libnfc-llcp.mk         |   15 ---------------
  4 files changed, 19 insertions(+), 19 deletions(-)
rename package/{libnfc-llcp => libllcp}/Config.in (56%) create mode 100644 package/libllcp/libllcp.mk delete mode 100644 package/libnfc-llcp/libnfc-llcp.mk

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Vicente Olivert Riera

author

2014-01-10 13:19 UTC #6 lore raw

PATCH 1/1 libnfc-llcp: rename to libllcp and bump version

Quoted 6 lines · Arnout Vandecappelle

Quoted 1 line · Vicente Olivert Riera
This package has been renamed upstream to libllcp.
This is not sufficient reason to rename the package in buildroot as
well. Renaming makes it difficult for people to follow buildroot upstream with their configurations.

The real reason to do this is because doing a version bump you will fix a compilation error due to libnfc-llcp not being compatible with libnfc. So, when you try to do a version bump, you notice that upstream has renamed the package, so..., why not do it altogether?

Quoted 4 lines

Also, if any existing symbol is removed (or renamed), entries have to
be added to Config.in.legacy. This makes is slightly easier for users to maintain buildroot configurations, but it's still annoying so renaming of symbols should be done with care.

You are writing a comment for the first version patch. The last one is the V3 patch which already modifies Config.in.legacy to do this.

Quoted 25 lines

It _is_ an option to still rename it in the menu. I'm not entirely
sure what should be done with the alphabetical ordering in that case - probably follow the visible name, not the internal name.
Regards,
Arnout
Quoted 15 lines
Also, the current
package we have in Buildroot fails to compile due to a version bump of it's main dependence, libnfc. A version bump is required because this package has been adapted upstream to work with libnfc-1.7.0-rc6.
Signed-off-by Vicente Olivert Riera<[email protected]>
---
  package/Config.in                          |    2 +-
  package/{libnfc-llcp => libllcp}/Config.in |    6 +++---
  package/libllcp/libllcp.mk                 |   15 +++++++++++++++
  package/libnfc-llcp/libnfc-llcp.mk         |   15 ---------------
  4 files changed, 19 insertions(+), 19 deletions(-)
rename package/{libnfc-llcp => libllcp}/Config.in (56%) create mode 100644 package/libllcp/libllcp.mk delete mode 100644 package/libnfc-llcp/libnfc-llcp.mk

Signature · 1 line

Vincent

Thomas Petazzoni

2014-01-11 00:47 UTC #7 lore raw

PATCH 1/1 libnfc-llcp: rename to libllcp and bump version

In reply to Arnout Vandecappelle

Hello,

Quoted 6 lines · Arnout Vandecappelle

Quoted 1 line · Vicente Olivert Riera
This package has been renamed upstream to libllcp.
This is not sufficient reason to rename the package in buildroot as
well. Renaming makes it difficult for people to follow buildroot upstream with their configurations.

True, but having packages in Buildroot that progressively do not follow the upstream names of the packages is also going to be big mess, as we are going to have more and more of such packages.

Since we have the Config.in.legacy thing in place, I'd very much prefer to rename packages to follow upstream decisions.

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com