Skip to contentSkip to conversation

arm: make 'MAKEALL -a' distinguish between arm and aarch64

PATCH New Albert ARIBAUD 3 participants 5 messages Jan 10, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: make 'MAKEALL -a' distinguish between arm and aarch64

The vexpress_aemv8a is the first aarch64 board in U-Boot. As it was introduced, it gets built when "MAKEALL -a arm" is invoked, and fails as this command is run with a 32-bit, not 64-bit, toolchain as the cross-compiler.

Introduce 'arch64' as a valid 'MAKEALL -a' argument, treated as 'arm' for all other intents, and change the architecture of the vexpress_aemv8a entry in boards.cfg from 'arm' to 'aarch64'.

---
This patch must be applied above the arm64 series and Tom's (amended) patch re config.h.

It has been tested and verified to:
- correctly exclude vexpress_aemv8a from MAKEALL -a arm
- correctly include only vexpress_aemv8a from MAKEALL -a aarch64
- correctly build vexpress_aemv8a from MAKEALL -a aarch64

 boards.cfg | 3 +--
 mkconfig   | 7 +++++++
 2 files changed, 8 insertions(+), 2 deletions(-)
boards.cfg +1 -2
index e168590..029553d 100644
@@ -397,7 +397,7 @@ Active  arm         pxa            -           -               vpac270
 Active  arm         pxa            -           icpdas          lp8x4x              lp8x4x                               -                                                                                                                                 Sergey Yanovich <[email protected]>
 Active  arm         pxa            -           toradex         -                   colibri_pxa270                       -                                                                                                                                 Marek Vasut <[email protected]>
 Active  arm         sa1100         -           -               -                   jornada                              -                                                                                                                                 Kristoffer Ericson <[email protected]>
-Active  arm         armv8          -           armltd          vexpress64          vexpress_aemv8a                      vexpress_aemv8a:ARM64                                                                                                             David Feng <[email protected]>
+Active  aarch64     armv8          -           armltd          vexpress64          vexpress_aemv8a                      vexpress_aemv8a:ARM64                                                                                                             David Feng <[email protected]>
 Active  avr32       at32ap         at32ap700x  atmel           -                   atngw100                             -                                                                                                                                 Haavard Skinnemoen <[email protected]>
 Active  avr32       at32ap         at32ap700x  atmel           -                   atngw100mkii                         -                                                                                                                                 Andreas Bie?mann <[email protected]>
 Active  avr32       at32ap         at32ap700x  atmel           atstk1000           atstk1002                            -                                                                                                                                 Haavard Skinnemoen <[email protected]>
@@ -1242,4 +1242,3 @@ Orphan  powerpc     mpc8xx         -           -               genietv
 Orphan  powerpc     mpc8xx         -           -               mbx8xx              MBX                                  -                                                                                                                                 -
 Orphan  powerpc     mpc8xx         -           -               mbx8xx              MBX860T                              -                                                                                                                                 -
 Orphan  powerpc     mpc8xx         -           -               nx823               NX823                                -                                                                                                                                 -
-
mkconfig +7 -0
index 40db991..b96c81f 100755
@@ -85,6 +85,13 @@ if [ "${ARCH}" -a "${ARCH}" != "${arch}" ]; then
 	exit 1
 fi
 
+#
+# Test above needed aarch64, now we need arm
+#
+if [ "${arch}" = "aarch64" ]; then
+	arch="arm"
+fi
+
 if [ "$options" ] ; then
 	echo "Configuring for ${BOARD_NAME} - Board: ${CONFIG_NAME}, Options: ${options}"
 else
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 arm: make 'MAKEALL -a' distinguish between arm and aarch64

Dear Albert,

Quoted 6 lines · In message <[email protected]> you…

The vexpress_aemv8a is the first aarch64 board in U-Boot. As it was introduced, it gets built when "MAKEALL -a arm" is invoked, and fails as this command is run with a 32-bit, not 64-bit, toolchain as the cross-compiler.

Introduce 'arch64' as a valid 'MAKEALL -a' argument, treated

I think this is a typo, and you mean 'aarch64' (double-'a') ?

[This can be fixed when applying the patch, me thinks.]

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
1000 pains                                              = 1 Megahertz
#2 lore raw

PATCH 1/1 arm: make 'MAKEALL -a' distinguish between arm and aarch64

Hi Wolfgang,

Quoted 11 lines · Wolfgang Denk

Dear Albert,

Quoted 6 lines · In message <[email protected]> you…

The vexpress_aemv8a is the first aarch64 board in U-Boot. As it was introduced, it gets built when "MAKEALL -a arm" is invoked, and fails as this command is run with a 32-bit, not 64-bit, toolchain as the cross-compiler.

Introduce 'arch64' as a valid 'MAKEALL -a' argument, treated

I think this is a typo, and you mean 'aarch64' (double-'a') ?

Correct -- and the typo is not in the patch itself, phew. :)

Quoted 1 line

[This can be fixed when applying the patch, me thinks.]

Will do. Thanks for catching it.

Quoted 3 lines

Best regards,

Wolfgang Denk

Amicalement,

Signature · 1 line
Albert.
#3 lore raw

PATCH 1/1 arm: make 'MAKEALL -a' distinguish between arm and aarch64

In reply to Albert ARIBAUD
Quoted 10 lines · Albert ARIBAUD

The vexpress_aemv8a is the first aarch64 board in U-Boot. As it was introduced, it gets built when "MAKEALL -a arm" is invoked, and fails as this command is run with a 32-bit, not 64-bit, toolchain as the cross-compiler.

Introduce 'arch64' as a valid 'MAKEALL -a' argument, treated as 'arm' for all other intents, and change the architecture of the vexpress_aemv8a entry in boards.cfg from 'arm' to 'aarch64'.

s/arch64/aarch64/ at the first occurence in this paragraph?

Quoted 3 lines

virtually yours
Gerhard Sittig

Signature · 3 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
#4 lore raw

PATCH 1/1 arm: make 'MAKEALL -a' distinguish between arm and aarch64

In reply to Albert ARIBAUD

Hi Albert,

Quoted 9 lines · Albert ARIBAUD

The vexpress_aemv8a is the first aarch64 board in U-Boot. As it was introduced, it gets built when "MAKEALL -a arm" is invoked, and fails as this command is run with a 32-bit, not 64-bit, toolchain as the cross-compiler.

Introduce 'arch64' as a valid 'MAKEALL -a' argument, treated as 'arm' for all other intents, and change the architecture of the vexpress_aemv8a entry in boards.cfg from 'arm' to 'aarch64'.

Applied, with the typo found by Wolfgang fixed, to u-boot-arm/master.

Amicalement,

Signature · 1 line
Albert.