Skip to contentSkip to conversation

video: ipu reg: Correct some reserved array sizes

PATCH New Liu Ying 2 participants 4 messages Dec 22, 2013 – Jan 12, 2014 Framebuffer layer

lore
Share & tools
lore

Liu Ying

author
#0 lore raw

v2 cover video: ipu reg: Correct some reserved array sizes

The structures ipu_cm and ipu_idmac contain some reserved arrays as placeholders to make sure the trailing entries may point to the relevant IPU registers. This patch corrects the size of the reserved arrays.

Changes in v2:
Added Robin Gong's ack.

Liu Ying (2):
video: ipu reg: Correct reserved1 array size in struct ipu_cm
video: ipu reg: Correct reserved array size in struct ipu_idmac

 drivers/video/ipu_regs.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH v2 1/2 video: ipu reg: Correct reserved1 array size in struct ipu_cm

The array reserved1 as a placeholder in the structure ipu_cm should contain 4 32bit unsigned integer entries instead of 16 ones, because the placeholder is located bewteen the register IPU_CH_DB_MODE_SEL_1 and the register IPU_ALT_CH_DB_MODE_SEL_0 with the address offsets of 0x154 and 0x168 respectively.

---
Changes in v2:
-Added Robin Gong's ack.

 drivers/video/ipu_regs.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/ipu_regs.h +1 -1
index 73e57ea..b2481a4 100644
@@ -171,7 +171,7 @@ struct ipu_cm {
 	u32 gpr;
 	u32 reserved0[26];
 	u32 ch_db_mode_sel[2];
-	u32 reserved1[16];
+	u32 reserved1[4];
 	u32 alt_ch_db_mode_sel[2];
 	u32 reserved2[2];
 	u32 ch_trb_mode_sel[2];
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH v2 2/2 video: ipu reg: Correct reserved array size in struct ipu_idmac

In reply to Liu Ying

The array reserved as a placeholder in the structure ipu_idmac should contain 44 32bit unsigned integer entries instead of 45 ones, because the placeholder is located bewteen the register IDMAC_SC_CORD1 and the register IDMAC_CH_BUSY_1 with the address offsets of 0x804c and 0x8100 respectively.

---
Changes in v2:
-Added Robin Gong's ack.

 drivers/video/ipu_regs.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/ipu_regs.h +1 -1
index b2481a4..21e9c99 100644
@@ -188,7 +188,7 @@ struct ipu_idmac {
 	u32 sub_addr[5];
 	u32 bndm_en[2];
 	u32 sc_cord[2];
-	u32 reserved[45];
+	u32 reserved[44];
 	u32 ch_busy[2];
 };
 
Signature · 1 line
1.7.9.5
#3 lore raw

v2 cover video: ipu reg: Correct some reserved array sizes

In reply to Liu Ying

Hi,

Quoted 7 lines · On Sun, 22 Dec 2013 13:02:40 +0800 Liu Ying <[email protected]> wrote:

The structures ipu_cm and ipu_idmac contain some reserved arrays as placeholders to make sure the trailing entries may point to the relevant IPU registers. This patch corrects the size of the reserved arrays.

Changes in v2:
Added Robin Gong's ack.

Quoted 6 lines

Liu Ying (2):
video: ipu reg: Correct reserved1 array size in struct ipu_cm
video: ipu reg: Correct reserved array size in struct ipu_idmac

 drivers/video/ipu_regs.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

applied both patches, thanks!

Anatolij