uclibc: build fixes for xtensa snapshot version

PATCH Superseded Baruch Siach 3 participants 10 messages Jan 13, 2014 – Jan 20, 2014

Share & tools

Baruch Siach

author

2014-01-13 06:26 UTC #0 lore raw

v2 cover uclibc: build fixes for xtensa snapshot version

This series bumps xtensa default uclibc version to add upstream fixes to autobuild failures. This series also adds a uclibc patch to fix posix_spawn autoconf detection.

The last patch in this series reverts a previous e2fsprogs fix that is both wrong and is superseded by the xtensa posix_fadvise fix in upstream uclibc.

v2:
* Bump uclibc version
* Remove patches applied upstream

Baruch Siach (3):
uclibc: bump xtensa snapshot version
uclibc: xtensa: fix posix_spawn autoconf detection Revert "e2fsprogs: fix posix_fadvise() signature mismatch"

 ...g-fix-build-when-posix_fadvise-is-missing.patch |  42 ------
 .../0001-spawn-move-from-librt-to-libc.patch       | 142 +++++++++++++++++++++
 package/uclibc/Config.in                           |   2 +-
 3 files changed, 143 insertions(+), 43 deletions(-)
 delete mode 100644 package/e2fsprogs/e2fsprogs-0002-e4defrag-fix-build-when-posix_fadvise-is-missing.patch
 create mode 100644 package/uclibc/7bf35c8b7d4a1f97174eb49f47f33946b282114c/0001-spawn-move-from-librt-to-libc.patch

Signature · 1 line

1.8.5.2

Baruch Siach

author

2014-01-13 06:26 UTC #1 lore raw

PATCH v2 1/3 uclibc: bump xtensa snapshot version

This new version includes two xtensa fixes:

00571b43df2e libc: posix_fadvise: restore implementation for xtensa de6561f66693 xtensa: use common ptrace.h

The first fixes (correctly)
http://autobuild.buildroot.net/results/ab1/ab1250c3d402ec3fbaf22eeffd07de218ffafb22/.

The second fixes
http://autobuild.buildroot.net/results/84f/84fb918efbcbf1312a228a9c11608edf096b3c40/.

The unifdef regression (the original motivation for the fixed xtensa snapshot version introduced in commit cecaf09cd6) should now be fixed.

Signed-off-by Baruch Siach <[email protected]>

---

This supersedes http://patchwork.ozlabs.org/patch/305872/.

---
 package/uclibc/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/uclibc/Config.in +1 -1

index cc23f769b087..079a15c98909 100644
@@ -43,7 +43,7 @@ config BR2_UCLIBC_VERSION_STRING
 	default 0.9.32.1	if BR2_UCLIBC_VERSION_0_9_32
 	default 0.9.33.2	if BR2_UCLIBC_VERSION_0_9_33
 	default "9f0f466d3b17181ce88be36ce24a775774fe686c" if BR2_arc
-	default "3a3ad3dfc10876b3648369f22df8fc06661ddef0" if BR2_UCLIBC_VERSION_XTENSA_GIT
+	default "7bf35c8b7d4a1f97174eb49f47f33946b282114c" if BR2_UCLIBC_VERSION_XTENSA_GIT
 	default BR2_USE_UCLIBC_SNAPSHOT	if BR2_UCLIBC_VERSION_SNAPSHOT
 
 config BR2_UCLIBC_CONFIG

Signature · 1 line

1.8.5.2

Peter Korsgaard

2014-01-20 21:37 UTC #2 lore raw

PATCH v2 1/3 uclibc: bump xtensa snapshot version

Quoted 9 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
This new version includes two xtensa fixes:
00571b43df2e libc: posix_fadvise: restore implementation for xtensa de6561f66693 xtensa: use common ptrace.h
The first fixes (correctly)
http://autobuild.buildroot.net/results/ab1/ab1250c3d402ec3fbaf22eeffd07de218ffafb22/.

Quoted 7 lines

The second fixes
http://autobuild.buildroot.net/results/84f/84fb918efbcbf1312a228a9c11608edf096b3c40/.
The unifdef regression (the original motivation for the fixed xtensa snapshot version introduced in commit cecaf09cd6) should now be fixed.
Signed-off-by Baruch Siach <[email protected]>

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard

Baruch Siach

author

2014-01-13 06:26 UTC #3 lore raw

PATCH v2 2/3 uclibc: xtensa: fix posix_spawn autoconf detection

In reply to Baruch Siach

posix_spawn is a new feature in uClibc development branch. Move posix_spawn implementation from librt to libc so that gnulib can detect it correctly.

Fixes
http://autobuild.buildroot.net/results/ab1/ab1250c3d402ec3fbaf22eeffd07de218ffafb22/.

Signed-off-by Baruch Siach <[email protected]>

---

This a more correct alternative to http://patchwork.ozlabs.org/patch/305872/.

---
 .../0001-spawn-move-from-librt-to-libc.patch       | 142 +++++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100644 package/uclibc/7bf35c8b7d4a1f97174eb49f47f33946b282114c/0001-spawn-move-from-librt-to-libc.patch

package/uclibc/7bf35c8b7d4a1f97174eb49f47f33946b282114c/0001-spawn-move-from-librt-to-libc.patch new file +142 -0

new file mode 100644
index 000000000000..d47a06fa4768
@@ -0,0 +1,142 @@
+From 7dbb2e43f34f53305d7807018865691c430efe5e Mon Sep 17 00:00:00 2001
+Message-Id: <7dbb2e43f34f53305d7807018865691c430efe5e.1389164521.git.baruch@tkos.co.il>
+From: Baruch Siach <[email protected]>
+Date: Wed, 8 Jan 2014 07:43:49 +0200
+Subject: [PATCH 1/3] spawn: move from librt to libc
+
+This makes uClibc compatible with glibc, and allows gnulib autoconf macros to
+correctly detect posix_spawn support.
+
+Patch status: posted upstream
+(http://lists.uclibc.org/pipermail/uclibc/2014-January/048160.html)
+
+Cc: Ismael Luceno <[email protected]>
+Signed-off-by: Baruch Siach <[email protected]>
+---
+ libc/Makefile.in                               |  1 +
+ libc/spawn/Makefile                            | 13 +++++++++++++
+ libc/spawn/Makefile.in                         | 25 +++++++++++++++++++++++++
+ {librt => libc/spawn}/spawn.c                  |  0
+ {librt => libc/spawn}/spawn_faction_addclose.c |  0
+ {librt => libc/spawn}/spawn_faction_adddup2.c  |  0
+ {librt => libc/spawn}/spawn_faction_addopen.c  |  0
+ {librt => libc/spawn}/spawn_faction_init.c     |  0
+ {librt => libc/spawn}/spawn_int.h              |  0
+ librt/Makefile.in                              |  7 -------
+ 10 files changed, 39 insertions(+), 7 deletions(-)
+ create mode 100644 libc/spawn/Makefile
+ create mode 100644 libc/spawn/Makefile.in
+ rename {librt => libc/spawn}/spawn.c (100%)
+ rename {librt => libc/spawn}/spawn_faction_addclose.c (100%)
+ rename {librt => libc/spawn}/spawn_faction_adddup2.c (100%)
+ rename {librt => libc/spawn}/spawn_faction_addopen.c (100%)
+ rename {librt => libc/spawn}/spawn_faction_init.c (100%)
+ rename {librt => libc/spawn}/spawn_int.h (100%)
+
+diff --git a/libc/Makefile.in b/libc/Makefile.in
+index 3b6a17b..4dd980b 100644
+--- a/libc/Makefile.in
++++ b/libc/Makefile.in
+@@ -37,6 +37,7 @@ include $(libc_DIR)/inet/Makefile.in
+ include $(libc_DIR)/signal/Makefile.in
+ include $(libc_DIR)/stdlib/Makefile.in
+ include $(libc_DIR)/unistd/Makefile.in
++include $(libc_DIR)/spawn/Makefile.in
+ 
+ ifeq ($(DOPIC),y)
+ libc-a-y = $(libc-y:.o=.os) $(libc-static-y:.o=.os)
+diff --git a/libc/spawn/Makefile b/libc/spawn/Makefile
+new file mode 100644
+index 0000000..11f362a
+--- /dev/null
++++ b/libc/spawn/Makefile
+@@ -0,0 +1,13 @@
++# Makefile for uClibc
++#
++# Copyright (C) 2000-2005 Erik Andersen <[email protected]>
++#
++# Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball.
++#
++
++top_srcdir=../../
++top_builddir=../../
++all: objs
++include $(top_builddir)Rules.mak
++include Makefile.in
++include $(top_srcdir)Makerules
+diff --git a/libc/spawn/Makefile.in b/libc/spawn/Makefile.in
+new file mode 100644
+index 0000000..8a06309
+--- /dev/null
++++ b/libc/spawn/Makefile.in
+@@ -0,0 +1,25 @@
++# Makefile for uClibc
++#
++# Copyright (C) 2000-2008 Erik Andersen <[email protected]>
++#
++# Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball.
++#
++
++subdirs += libc/spawn
++
++CSRC-y :=
++CSRC-$(UCLIBC_HAS_ADVANCED_REALTIME) := spawn.c spawn_faction_addclose.c \
++	spawn_faction_adddup2.c spawn_faction_addopen.c spawn_faction_init.c
++
++SPAWN_DIR := $(top_srcdir)libc/spawn
++SPAWN_OUT := $(top_builddir)libc/spawn
++
++SPAWN_SRC := $(patsubst %.c,$(SPAWN_DIR)/%.c,$(CSRC-y))
++SPAWN_OBJ := $(patsubst %.c,$(SPAWN_OUT)/%.o,$(CSRC-y))
++
++libc-y += $(SPAWN_OBJ)
++
++objclean-y += CLEAN_libc/spawn
++
++CLEAN_libc/spawn:
++	$(do_rm) $(addprefix $(SPAWN_OUT)/*., o os)
+diff --git a/librt/spawn.c b/libc/spawn/spawn.c
+similarity index 100%
+rename from librt/spawn.c
+rename to libc/spawn/spawn.c
+diff --git a/librt/spawn_faction_addclose.c b/libc/spawn/spawn_faction_addclose.c
+similarity index 100%
+rename from librt/spawn_faction_addclose.c
+rename to libc/spawn/spawn_faction_addclose.c
+diff --git a/librt/spawn_faction_adddup2.c b/libc/spawn/spawn_faction_adddup2.c
+similarity index 100%
+rename from librt/spawn_faction_adddup2.c
+rename to libc/spawn/spawn_faction_adddup2.c
+diff --git a/librt/spawn_faction_addopen.c b/libc/spawn/spawn_faction_addopen.c
+similarity index 100%
+rename from librt/spawn_faction_addopen.c
+rename to libc/spawn/spawn_faction_addopen.c
+diff --git a/librt/spawn_faction_init.c b/libc/spawn/spawn_faction_init.c
+similarity index 100%
+rename from librt/spawn_faction_init.c
+rename to libc/spawn/spawn_faction_init.c
+diff --git a/librt/spawn_int.h b/libc/spawn/spawn_int.h
+similarity index 100%
+rename from librt/spawn_int.h
+rename to libc/spawn/spawn_int.h
+diff --git a/librt/Makefile.in b/librt/Makefile.in
+index 8555e94..abaa8ca 100644
+--- a/librt/Makefile.in
++++ b/librt/Makefile.in
+@@ -35,13 +35,6 @@ librt_filter_SRC += clock_nanosleep.c clock_getcpuclockid.c clock_gettime.c
+ librt_SSRC :=
+ endif
+ 
+-librt_filter_SRC += $(if $(UCLIBC_HAS_ADVANCED_REALTIME),, \
+-	spawn.c \
+-	spawn_faction_addclose.c \
+-	spawn_faction_adddup2.c \
+-	spawn_faction_addopen.c \
+-	spawn_faction_init.c)
+-
+ librt_SRC := $(filter-out $(librt_filter_SRC),$(librt_SRC))
+ 
+ librt_OBJ := $(patsubst %.c,$(librt_OUT)/%.o,$(librt_SRC))
+-- 
+1.8.5.2
+

Signature · 1 line

1.8.5.2

Baruch Siach

author

2014-01-15 13:31 UTC #4 lore raw

PATCH v2 2/3 uclibc: xtensa: fix posix_spawn autoconf detection

Hi buildroot list,

Quoted 7 lines · Baruch Siach

posix_spawn is a new feature in uClibc development branch. Move posix_spawn implementation from librt to libc so that gnulib can detect it correctly.
Fixes
http://autobuild.buildroot.net/results/ab1/ab1250c3d402ec3fbaf22eeffd07de218ffafb22/.
Signed-off-by Baruch Siach <[email protected]>

Mike Frysinger has rejected this uclibc patch
(http://article.gmane.org/gmane.comp.lib.gnulib.bugs/33613), but there is a different solution suggested for the coreutils build problem
(http://article.gmane.org/gmane.comp.gnu.coreutils.general/4995). In the mean time I'm marking this patch as rejected in patchwork.

baruch

Quoted 156 lines

---

This a more correct alternative to http://patchwork.ozlabs.org/patch/305872/.

---
 .../0001-spawn-move-from-librt-to-libc.patch       | 142 +++++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100644 package/uclibc/7bf35c8b7d4a1f97174eb49f47f33946b282114c/0001-spawn-move-from-librt-to-libc.patch

package/uclibc/7bf35c8b7d4a1f97174eb49f47f33946b282114c/0001-spawn-move-from-librt-to-libc.patch new file +142 -0

new file mode 100644
index 000000000000..d47a06fa4768
@@ -0,0 +1,142 @@
+From 7dbb2e43f34f53305d7807018865691c430efe5e Mon Sep 17 00:00:00 2001
+Message-Id: <7dbb2e43f34f53305d7807018865691c430efe5e.1389164521.git.baruch@tkos.co.il>
+From: Baruch Siach <[email protected]>
+Date: Wed, 8 Jan 2014 07:43:49 +0200
+Subject: [PATCH 1/3] spawn: move from librt to libc
+
+This makes uClibc compatible with glibc, and allows gnulib autoconf macros to
+correctly detect posix_spawn support.
+
+Patch status: posted upstream
+(http://lists.uclibc.org/pipermail/uclibc/2014-January/048160.html)
+
+Cc: Ismael Luceno <[email protected]>
+Signed-off-by: Baruch Siach <[email protected]>
+---
+ libc/Makefile.in                               |  1 +
+ libc/spawn/Makefile                            | 13 +++++++++++++
+ libc/spawn/Makefile.in                         | 25 +++++++++++++++++++++++++
+ {librt => libc/spawn}/spawn.c                  |  0
+ {librt => libc/spawn}/spawn_faction_addclose.c |  0
+ {librt => libc/spawn}/spawn_faction_adddup2.c  |  0
+ {librt => libc/spawn}/spawn_faction_addopen.c  |  0
+ {librt => libc/spawn}/spawn_faction_init.c     |  0
+ {librt => libc/spawn}/spawn_int.h              |  0
+ librt/Makefile.in                              |  7 -------
+ 10 files changed, 39 insertions(+), 7 deletions(-)
+ create mode 100644 libc/spawn/Makefile
+ create mode 100644 libc/spawn/Makefile.in
+ rename {librt => libc/spawn}/spawn.c (100%)
+ rename {librt => libc/spawn}/spawn_faction_addclose.c (100%)
+ rename {librt => libc/spawn}/spawn_faction_adddup2.c (100%)
+ rename {librt => libc/spawn}/spawn_faction_addopen.c (100%)
+ rename {librt => libc/spawn}/spawn_faction_init.c (100%)
+ rename {librt => libc/spawn}/spawn_int.h (100%)
+
+diff --git a/libc/Makefile.in b/libc/Makefile.in
+index 3b6a17b..4dd980b 100644
+--- a/libc/Makefile.in
++++ b/libc/Makefile.in
+@@ -37,6 +37,7 @@ include $(libc_DIR)/inet/Makefile.in
+ include $(libc_DIR)/signal/Makefile.in
+ include $(libc_DIR)/stdlib/Makefile.in
+ include $(libc_DIR)/unistd/Makefile.in
++include $(libc_DIR)/spawn/Makefile.in
+ 
+ ifeq ($(DOPIC),y)
+ libc-a-y = $(libc-y:.o=.os) $(libc-static-y:.o=.os)
+diff --git a/libc/spawn/Makefile b/libc/spawn/Makefile
+new file mode 100644
+index 0000000..11f362a
+--- /dev/null
++++ b/libc/spawn/Makefile
+@@ -0,0 +1,13 @@
++# Makefile for uClibc
++#
++# Copyright (C) 2000-2005 Erik Andersen <[email protected]>
++#
++# Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball.
++#
++
++top_srcdir=../../
++top_builddir=../../
++all: objs
++include $(top_builddir)Rules.mak
++include Makefile.in
++include $(top_srcdir)Makerules
+diff --git a/libc/spawn/Makefile.in b/libc/spawn/Makefile.in
+new file mode 100644
+index 0000000..8a06309
+--- /dev/null
++++ b/libc/spawn/Makefile.in
+@@ -0,0 +1,25 @@
++# Makefile for uClibc
++#
++# Copyright (C) 2000-2008 Erik Andersen <[email protected]>
++#
++# Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball.
++#
++
++subdirs += libc/spawn
++
++CSRC-y :=
++CSRC-$(UCLIBC_HAS_ADVANCED_REALTIME) := spawn.c spawn_faction_addclose.c \
++	spawn_faction_adddup2.c spawn_faction_addopen.c spawn_faction_init.c
++
++SPAWN_DIR := $(top_srcdir)libc/spawn
++SPAWN_OUT := $(top_builddir)libc/spawn
++
++SPAWN_SRC := $(patsubst %.c,$(SPAWN_DIR)/%.c,$(CSRC-y))
++SPAWN_OBJ := $(patsubst %.c,$(SPAWN_OUT)/%.o,$(CSRC-y))
++
++libc-y += $(SPAWN_OBJ)
++
++objclean-y += CLEAN_libc/spawn
++
++CLEAN_libc/spawn:
++	$(do_rm) $(addprefix $(SPAWN_OUT)/*., o os)
+diff --git a/librt/spawn.c b/libc/spawn/spawn.c
+similarity index 100%
+rename from librt/spawn.c
+rename to libc/spawn/spawn.c
+diff --git a/librt/spawn_faction_addclose.c b/libc/spawn/spawn_faction_addclose.c
+similarity index 100%
+rename from librt/spawn_faction_addclose.c
+rename to libc/spawn/spawn_faction_addclose.c
+diff --git a/librt/spawn_faction_adddup2.c b/libc/spawn/spawn_faction_adddup2.c
+similarity index 100%
+rename from librt/spawn_faction_adddup2.c
+rename to libc/spawn/spawn_faction_adddup2.c
+diff --git a/librt/spawn_faction_addopen.c b/libc/spawn/spawn_faction_addopen.c
+similarity index 100%
+rename from librt/spawn_faction_addopen.c
+rename to libc/spawn/spawn_faction_addopen.c
+diff --git a/librt/spawn_faction_init.c b/libc/spawn/spawn_faction_init.c
+similarity index 100%
+rename from librt/spawn_faction_init.c
+rename to libc/spawn/spawn_faction_init.c
+diff --git a/librt/spawn_int.h b/libc/spawn/spawn_int.h
+similarity index 100%
+rename from librt/spawn_int.h
+rename to libc/spawn/spawn_int.h
+diff --git a/librt/Makefile.in b/librt/Makefile.in
+index 8555e94..abaa8ca 100644
+--- a/librt/Makefile.in
++++ b/librt/Makefile.in
+@@ -35,13 +35,6 @@ librt_filter_SRC += clock_nanosleep.c clock_getcpuclockid.c clock_gettime.c
+ librt_SSRC :=
+ endif
+ 
+-librt_filter_SRC += $(if $(UCLIBC_HAS_ADVANCED_REALTIME),, \
+-	spawn.c \
+-	spawn_faction_addclose.c \
+-	spawn_faction_adddup2.c \
+-	spawn_faction_addopen.c \
+-	spawn_faction_init.c)
+-
+ librt_SRC := $(filter-out $(librt_filter_SRC),$(librt_SRC))
+ 
+ librt_OBJ := $(patsubst %.c,$(librt_OUT)/%.o,$(librt_SRC))
+-- 
+1.8.5.2
+

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Peter Korsgaard

2014-01-15 14:30 UTC #5 lore raw

PATCH v2 2/3 uclibc: xtensa: fix posix_spawn autoconf detection

Quoted 10 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
Hi buildroot list,
Quoted 6 lines · Baruch Siach
posix_spawn is a new feature in uClibc development branch. Move posix_spawn implementation from librt to libc so that gnulib can detect it correctly.
Fixes
http://autobuild.buildroot.net/results/ab1/ab1250c3d402ec3fbaf22eeffd07de218ffafb22/.

Quoted 7 lines

Quoted 1 line
Signed-off-by Baruch Siach <[email protected]>
Mike Frysinger has rejected this uclibc patch
(http://article.gmane.org/gmane.comp.lib.gnulib.bugs/33613), but there is a different solution suggested for the coreutils build problem
(http://article.gmane.org/gmane.comp.gnu.coreutils.general/4995). In the mean time I'm marking this patch as rejected in patchwork.

Ok, thanks for following up on it.

Signature · 1 line

Bye, Peter Korsgaard

Baruch Siach

author

2014-01-13 06:26 UTC #6 lore raw

PATCH v2 3/3 Revert "e2fsprogs: fix posix_fadvise() signature mismatch"

In reply to Baruch Siach

This reverts commit c3d690166c4533bc83500a22a43783193fbc27f9.

The real cause of problem is missing posix_fadvise() implementation in uClibc for xtensa. This has now been fixed with the uclibc version bump. The internal e2fsprogs posix_fadvise() implementation is broken on 32bit systems anyway, and upstream has removed it.

Signed-off-by Baruch Siach <[email protected]>

---
 ...g-fix-build-when-posix_fadvise-is-missing.patch | 42 ----------------------
 1 file changed, 42 deletions(-)
 delete mode 100644 package/e2fsprogs/e2fsprogs-0002-e4defrag-fix-build-when-posix_fadvise-is-missing.patch

package/e2fsprogs/e2fsprogs-0002-e4defrag-fix-build-when-posix_fadvise-is-missing.patch deleted +0 ~~-42~~

deleted file mode 100644
index 2fa828ff6be2..000000000000
@@ -1,42 +0,0 @@
-From 33245e3808058c72b66931ac14aea8d5dc6d1ba5 Mon Sep 17 00:00:00 2001
-Message-Id: <33245e3808058c72b66931ac14aea8d5dc6d1ba5.1388571601.git.baruch@tkos.co.il>
-From: Baruch Siach <[email protected]>
-Date: Wed, 1 Jan 2014 08:48:17 +0200
-Subject: [PATCH] e4defrag: fix build when posix_fadvise is missing
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-uClibc declares posix_fadvise() even when the architecture does not provide
-one. The static posix_fadvise() signature is not compatible with POSIX. Rename
-the internal implementation to fix this. Fixes the following build failure
-when building against uClibc:
-
-e4defrag.c:189:2: warning: #warning Using locally defined posix_fadvise interface. [-Wcpp]
-e4defrag.c:203:12: error: conflicting types for ?posix_fadvise?
-
-Patch status: sent upstream 
-(http://marc.info/?l=linux-ext4&m=138857218522054&w=2)
-
-Signed-off-by: Baruch Siach <[email protected]>
----
- misc/e4defrag.c | 3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
-
-diff --git a/misc/e4defrag.c b/misc/e4defrag.c
-index c6a5f0d..4e84a74 100644
---- a/misc/e4defrag.c
-+++ b/misc/e4defrag.c
-@@ -200,7 +200,8 @@ static struct frag_statistic_ino	frag_rank[SHOW_FRAG_FILES];
-  * @len:		area length.
-  * @advise:		process flag.
-  */
--static int posix_fadvise(int fd, loff_t offset, size_t len, int advise)
-+#define posix_fadvise	__posix_fadvise
-+static int __posix_fadvise(int fd, loff_t offset, size_t len, int advise)
- {
- 	return syscall(__NR_fadvise64_64, fd, offset, len, advise);
- }
--- 
-1.8.5.2
-

Signature · 1 line

1.8.5.2

Peter Korsgaard

2014-01-20 21:37 UTC #7 lore raw

PATCH v2 3/3 Revert "e2fsprogs: fix posix_fadvise() signature mismatch"

Quoted 9 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
This reverts commit c3d690166c4533bc83500a22a43783193fbc27f9.
The real cause of problem is missing posix_fadvise() implementation in uClibc for xtensa. This has now been fixed with the uclibc version bump. The internal e2fsprogs posix_fadvise() implementation is broken on 32bit systems anyway, and upstream has removed it.
Signed-off-by Baruch Siach <[email protected]>

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard

Thomas Petazzoni

2014-01-13 08:13 UTC #8 lore raw

v2 cover uclibc: build fixes for xtensa snapshot version

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 3 lines · Baruch Siach

Baruch Siach (3):
uclibc: bump xtensa snapshot version
uclibc: xtensa: fix posix_spawn autoconf detection

Why is this patch xtensa specific?

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Baruch Siach

author

2014-01-13 08:23 UTC #9 lore raw

v2 cover uclibc: build fixes for xtensa snapshot version

Hi Thomas,

Quoted 7 lines · Thomas Petazzoni

Quoted 3 lines · Baruch Siach
Baruch Siach (3):
uclibc: bump xtensa snapshot version
uclibc: xtensa: fix posix_spawn autoconf detection
Why is this patch xtensa specific?

It it not. It's uClibc snapshot specific, and I don't think that blindly applying this patch to any random snapshot version is a good idea. Only xtensa and arc have a fixed default uClibc snapshot version. arc uses its own uClibc git tree, so this patch can be applied there if it's considered useful (adding Mischa to Cc).

baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -