Skip to contentSkip to conversation

sf: Add support for quad and dual_flash

PATCH New Jagannadha Sutradharudu Teki 3 participants 3 messages Jan 12, 2014 – Jan 13, 2014

lore
Share & tools
lore
#0 lore raw

v7 cover sf: Add support for quad and dual_flash

This series is a combo of quad cmds and dual_flash support Refer [1] and [2] for more functional description about this changes.

[1] http://u-boot.10912.n7.nabble.com/PATCH-v6-00-12-sf-Add-Extended-read-and-quad-read-write-commands-support-td170645.html
[2] http://u-boot.10912.n7.nabble.com/PATCH-v3-0-4-sf-Add-support-to-access-dual-flash-memory-td170760.html

Tested on sst, stmicro and spansion flash.
Testing branch:

$ git clone git://git.denx.de/u-boot-spi.git
$ cd u-boot-spi
$ git checkout -b master-quad origin/master-quad

REQUEST FOR ALL SPI CODE CONTRIBUTORS/USERS, PLEASE TEST THESE CHANGES W.R.T YOUR HW IF POSSIBLE.

Please let me know for any issues/concerns/questions.

Signature · 60 lines
Thanks,
Jagan. 

Changes for v7:
	- cmdsz on read_ops
	- sf param flags are placed spi_flash.h
	- code cleanup
	- updated dual_flash with BAR support
Changes for v6:
        - Divided flash reg ops code
        - sf_ops.c clean
Changes for v5:
        - Re-implemented write command log - not trying to discover the fastest write
        - Added SPI RX/TX operation modes
        - SPI flash parts are moved into sf_params.c file
        - Added QUAD_IO_FAST read support
        - Discovred the read dummy_cycles based on configured read cmd
        - Added set QEB support for macronix flash
        - Enabled quad read/write cmd support for macronix flash
Changes for v4:
Changes for v3:
Changes for v2:
        - none 

Jagannadha Sutradharudu Teki (17):
  sf: Add extended read commands support
  sf: Add quad read/write commands support
  sf: ops: Add configuration register writing support
  sf: Set quad enable bit support
  sf: probe: Enable RD_FULL and WR_QPP
  sf: Separate the flash params table
  sf: Add QUAD_IO_FAST read support
  sf: Discover read dummy_byte
  sf: Add macronix set QEB support
  sf: probe: Enable macronix quad read/write cmds support
  sf: Divide flash register ops from QEB code
  sf: Code cleanups
  sf: ops: Unify read_ops bank configuration
  sf: Add dual memories support - DUAL_STACKED
  sf: Add dual memories support - DUAL_PARALLEL
  sf: Add CONFIG_SF_DUAL_FLASH
  doc: SPI: Update status.txt

 README                        |   6 +
 doc/SPI/README.dual-flash     |  92 ++++++++++++++
 doc/SPI/status.txt            |  11 +-
 drivers/mtd/spi/Makefile      |   4 +-
 drivers/mtd/spi/sf.c          |   4 +
 drivers/mtd/spi/sf_internal.h |  34 ++++--
 drivers/mtd/spi/sf_ops.c      | 157 +++++++++++++++++++-----
 drivers/mtd/spi/sf_params.c   | 130 ++++++++++++++++++++
 drivers/mtd/spi/sf_probe.c    | 274 +++++++++++++++++++++---------------------
 include/spi.h                 |  26 ++++
 include/spi_flash.h           |  57 +++++++++
 11 files changed, 610 insertions(+), 185 deletions(-)
 create mode 100644 doc/SPI/README.dual-flash
 create mode 100644 drivers/mtd/spi/sf_params.c

-- 
1.8.3
#1 lore raw

v7 cover sf: Add support for quad and dual_flash

Quoted 18 lines · Jagannadha Sutradharudu Teki

This series is a combo of quad cmds and dual_flash support Refer [1] and [2] for more functional description about this changes.

[ ... ]

Please let me know for any issues/concerns/questions.

Signature · 9 lines
Thanks,
Jagan. 

Changes for v7:
	- cmdsz on read_ops
	- sf param flags are placed spi_flash.h
	- code cleanup
	- updated dual_flash with BAR support
[ ... ]

Mail setup related nits:

Please don't do this. The dash line correctly separates your signature, which is good (and not a given either). But putting more context below that line will make it look like it's part of the signature, and thus probably will get lost (either by automatic trimming, or folding, or colorization and/or mental filtering).

Then I noticed that the series and your cover letter aren't "connected". The series should be a reply to the cover letter, while you seem to create and send them out in separate steps. Which breaks their relation, and has them appear in random order and with other messages in between them.

And the recipient list suggests that there is an issue with inappropriately quoted entries, there's another nonexistent @theia address as has been in the past. Please fix this (I did upon reply, check your original message).

virtually yours
Gerhard Sittig

Signature · 3 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
#2 lore raw

v7 cover sf: Add support for quad and dual_flash

Hi,

Quoted 20 lines · Gerhard Sittig
Quoted 12 lines · Jagannadha Sutradharudu Teki

This series is a combo of quad cmds and dual_flash support Refer [1] and [2] for more functional description about this changes.

[ ... ]

Please let me know for any issues/concerns/questions.

--
Thanks,
Jagan.

Quoted 6 lines

Changes for v7:
- cmdsz on read_ops
- sf param flags are placed spi_flash.h
- code cleanup
- updated dual_flash with BAR support
[ ... ]

Quoted 8 lines

Mail setup related nits:

Please don't do this. The dash line correctly separates your signature, which is good (and not a given either). But putting more context below that line will make it look like it's part of the signature, and thus probably will get lost (either by automatic trimming, or folding, or colorization and/or mental filtering).

Yes - will take this input.

Quoted 6 lines

Then I noticed that the series and your cover letter aren't "connected". The series should be a reply to the cover letter, while you seem to create and send them out in separate steps. Which breaks their relation, and has them appear in random order and with other messages in between them.

Probably the random order appearance is some issue on my host server side. Will fix to encounter all the mails properly.

Quoted 5 lines

And the recipient list suggests that there is an issue with inappropriately quoted entries, there's another nonexistent @theia address as has been in the past. Please fix this (I did upon reply, check your original message).

Try many times to fix this, any idea would appreciate.

Signature · 2 lines
Thanks,
Jagan.