rt-tests: disable NPTL is missing
PATCH v2 1/1 rt-tests: disable NPTL is missing
Fixes
http://autobuild.buildroot.net/results/8aa/8aaa4b56a53241b7342fede568fbc72a7656cc38/.
---
v2: exclude linuxthreads-{old,new} for internal toolchains (Peter Korsgaard)
--- package/rt-tests/Config.in | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
package/rt-tests/Config.in +6 -4
@@ -1,9 +1,10 @@ config BR2_PACKAGE_RT_TESTS bool "rt-tests" depends on BR2_TOOLCHAIN_HAS_THREADS - # Too old uClibc, does not provide priority-inheritance - # mutexes - depends on !BR2_avr32 + # priority-inheritance mutex needs NPTL + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD + # no NPTL for these archs + depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc help Set of utilities for testing the real-time behaviour of a Linux system.
@@ -23,5 +24,6 @@ config BR2_PACKAGE_RT_TESTS http://rt.wiki.kernel.org comment "rt-tests needs a toolchain w/ threads" - depends on !BR2_avr32 + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD + depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.8.5.2
PATCH v2 1/1 rt-tests: disable NPTL is missing
Dear Baruch Siach,
package/rt-tests/Config.in line 5
Quoted 2 lines · Baruch Siach
package/rt-tests/Config.in +2
-0+ # priority-inheritance mutex needs NPTL + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
No, these symbols are specific to the internal toolchain backend, and do not make sense for external toolchains. Therefore, they shouldn't be used for package dependencies.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 rt-tests: disable NPTL is missing
Hi Thomas,
Quoted 8 lines · Thomas Petazzoni
package/rt-tests/Config.in line 5
Quoted 2 lines · Baruch Siach
package/rt-tests/Config.in +2
-0+ # priority-inheritance mutex needs NPTL + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLDNo, these symbols are specific to the internal toolchain backend, and do not make sense for external toolchains. Therefore, they shouldn't be used for package dependencies.
Well, my v1 patch didn't have this dependency. Do you have any better suggestion for the NPTL situation?
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH v2 1/1 rt-tests: disable NPTL is missing
In reply to Thomas PetazzoniQuoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Dear Baruch Siach,
package/rt-tests/Config.in line 5
Quoted 2 lines · Baruch Siach
package/rt-tests/Config.in +2
-0+ # priority-inheritance mutex needs NPTL + depends on !BR2_PTHREADS && !BR2_PTHREADS_OLDNo, these symbols are specific to the internal toolchain backend, and do not make sense for external toolchains. Therefore, they shouldn't be used for package dependencies.
Notice that the dependency is !BR_THREADS, E.G. only hide if using the internal uClibc toolchain with linuxthreads. That I believe is OK.
For external uClibc toolchains we don't know the threads variant, which is why the 2nd line disables it for the specific archs where we know NPTL isn't available.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/1 rt-tests: disable NPTL is missing
In reply to Baruch SiachQuoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
Fixes
http://autobuild.buildroot.net/results/8aa/8aaa4b56a53241b7342fede568fbc72a7656cc38/.Signed-off-by Baruch Siach <[email protected]>---
v2: exclude linuxthreads-{old,new} for internal toolchains (Peter Korsgaard)
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard