Skip to contentSkip to conversation

p54: clamp properly instead of just truncating

PATCH New Dan Carpenter 1 participant 1 message Jan 13, 2014

Subsystems (2)
Kernel janitors Networking drivers (wireless)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 p54: clamp properly instead of just truncating

The call to clamp_t() first truncates the variable signed 8 bit and as a result, the actual clamp is a no-op.

Fixes 0d78156eef1d ('p54: improve site survey')
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/p54/txrx.c +1 -1
index 9c96831c0b5c..153c61539ec8 100644
@@ -586,7 +586,7 @@ static void p54_rx_stats(struct p54_common *priv, struct sk_buff *skb)
 	chan = priv->curchan;
 	if (chan) {
 		struct survey_info *survey = &priv->survey[chan->hw_value];
-		survey->noise = clamp_t(s8, priv->noise, -128, 127);
+		survey->noise = clamp(priv->noise, -128, 127);
 		survey->channel_time = priv->survey_raw.active;
 		survey->channel_time_tx = priv->survey_raw.tx;
 		survey->channel_time_busy = priv->survey_raw.tx +