Patch for TechnoTrend S2-4600
Hi guys,
i'm sending you a patch that adds support for the TechnoTrend S2-4600 DVB-S2 device to a 3.12 (5e01dc7b26d9f24f39abace5da98ccbd6a5ceb52) mainline kernel.
I just extracted the drivers for the two frontends (ds3103 and ts2202) from [1] and added them to a mainline kernel. Furthermore, i modified the dw2102 driver to support the new frontends (= copied the necessary lines of code from the origin dw2102) . In addition, i attached a firmware for the dw2102 extracted from [3]. I appreciate, if you review my patch and may integrate it into the mainline tree.
Thank you!
Greetings
Alex
[1] https://bitbucket.org/liplianin/s2-liplianin-v37/get/67ce08afdbe7.tar.bz2
[2] http://www.tt-downloads.de/Linux/s2-TT4600-linux-20120815.tgz
[3] http://www.tt-downloads.de/Linux/linux_tt-connect_s2-4600.pdf
drivers/media/dvb-frontends/Kconfig +14 -0
@@ -207,6 +207,13 @@ config DVB_SI21XX help A DVB-S tuner module. Say Y when you want to support this frontend. +config DVB_TS2022 + tristate "Montage TS2022 silicon tuner" + depends on DVB_CORE && I2C + default m if DVB_FE_CUSTOMISE + help + A DVB-S silicon tuner module. Say Y when you want to support this tuner. + config DVB_TS2020 tristate "Montage Tehnology TS2020 based tuners" depends on DVB_CORE && I2C
@@ -214,6 +221,13 @@ config DVB_TS2020 help A DVB-S/S2 silicon tuner. Say Y when you want to support this tuner. +config DVB_DS3103 + tristate "Montage DS3103 based" + depends on DVB_CORE && I2C + default m if DVB_FE_CUSTOMISE + help + A DVB-S/S2 tuner module. Say Y when you want to support this frontend. + config DVB_DS3000 tristate "Montage Tehnology DS3000 based" depends on DVB_CORE && I2C
drivers/media/dvb-frontends/ds3103.c new file +1304 -0
1,304 lines not on this page · raw message
drivers/media/dvb-frontends/ds3103.h new file +47 -0
47 lines not on this page · raw message
drivers/media/dvb-frontends/ts2022.c new file +453 -0
453 lines not on this page · raw message
drivers/media/dvb-frontends/ts2022.h new file +51 -0
51 lines not on this page · raw message
drivers/media/usb/dvb-usb/dw2102.c +92 -7
162 lines not on this page · raw message
Em Sun, 05 Jan 2014 18:33:14 +0100
Alexander Lochmann <[email protected]> escreveu:
Quoted 12 lines
Hi guys,
i'm sending you a patch that adds support for the TechnoTrend S2-4600 DVB-S2 device to a 3.12 (
5e01dc7b26d9f24f39abace5da98ccbd6a5ceb52) mainline kernel.
I just extracted the drivers for the two frontends (ds3103 and ts2202) from [1] and added them to a mainline kernel. Furthermore, i modified the dw2102 driver to support the new frontends (= copied the necessary lines of code from the origin dw2102) . In addition, i attached a firmware for the dw2102 extracted from [3].
I appreciate, if you review my patch and may integrate it into the mainline tree.
Hi Alexander,
You can't simply extract those patches from some other tree and send, without the driver's author ack.
Also, recently a driver for ts2202 and ds3103 was merged in the Kernel. It may not have the IDs for your device, but it shouldn't likely be hard to add support for it, if you have some programming skills.
Regards,
Mauro
Quoted 9 lines
Thank you!
Greetings
Alex[1]
https://bitbucket.org/liplianin/s2-liplianin-v37/get/67ce08afdbe7.tar.bz2
[2] http://www.tt-downloads.de/Linux/s2-TT4600-linux-20120815.tgz
[3] http://www.tt-downloads.de/Linux/linux_tt-connect_s2-4600.pdf
Signature · 2 lines
Cheers, Mauro
Hi Mauro,
thanks for you reply.
Sorry, i was not aware of the fact that i have to ask the author. :-( They published it at bitbucket. Thus i thought it is okay to propose a patch. In which kernel tree was it merged? The mainline one at kernel.org?
Regards,
Alex
Quoted 36 lines · Mauro Carvalho Chehab
Em Sun, 05 Jan 2014 18:33:14 +0100
Alexander Lochmann <[email protected]> escreveu:Quoted 12 lines
Hi guys,
i'm sending you a patch that adds support for the TechnoTrend S2-4600 DVB-S2 device to a 3.12 (
5e01dc7b26d9f24f39abace5da98ccbd6a5ceb52) mainline kernel.
I just extracted the drivers for the two frontends (ds3103 and ts2202) from [1] and added them to a mainline kernel. Furthermore, i modified the dw2102 driver to support the new frontends (= copied the necessary lines of code from the origin dw2102) . In addition, i attached a firmware for the dw2102 extracted from [3].
I appreciate, if you review my patch and may integrate it into the mainline tree.Hi Alexander,
You can't simply extract those patches from some other tree and send, without the driver's author ack.
Also, recently a driver for ts2202 and ds3103 was merged in the Kernel. It may not have the IDs for your device, but it shouldn't likely be hard to add support for it, if you have some programming skills.
Regards,
Mauro
Em Wed, 15 Jan 2014 22:55:46 +0100
Alexander Lochmann <[email protected]> escreveu:
Quoted 8 lines
Hi Mauro,
thanks for you reply.
Sorry, i was not aware of the fact that i have to ask the author. :-( They published it at bitbucket. Thus i thought it is okay to propose a patch.
In which kernel tree was it merged? The mainline one at kernel.org?
The patch is already at the media tree, at git.linuxtv.org. It should be sent upstream likely next week, when the merge window for Kernel 3.14 opens.
Regards,
Mauro
Quoted 42 lines
Regards,
AlexQuoted 36 lines · Mauro Carvalho Chehab
Em Sun, 05 Jan 2014 18:33:14 +0100
Alexander Lochmann <[email protected]> escreveu:Quoted 12 lines
Hi guys,
i'm sending you a patch that adds support for the TechnoTrend S2-4600 DVB-S2 device to a 3.12 (
5e01dc7b26d9f24f39abace5da98ccbd6a5ceb52) mainline kernel.
I just extracted the drivers for the two frontends (ds3103 and ts2202) from [1] and added them to a mainline kernel. Furthermore, i modified the dw2102 driver to support the new frontends (= copied the necessary lines of code from the origin dw2102) . In addition, i attached a firmware for the dw2102 extracted from [3].
I appreciate, if you review my patch and may integrate it into the mainline tree.Hi Alexander,
You can't simply extract those patches from some other tree and send, without the driver's author ack.
Also, recently a driver for ts2202 and ds3103 was merged in the Kernel. It may not have the IDs for your device, but it shouldn't likely be hard to add support for it, if you have some programming skills.
Regards,
Mauro
Signature · 2 lines
Cheers, Mauro
Am 15.01.2014 17:42, schrieb Mauro Carvalho Chehab:
Quoted 4 lines
You can't simply extract those patches from some other tree and send, without the driver's author ack.
Lines 24, 25: "GNU GENERAL PUBLIC LICENSE", "Version 2 [...]
==> Yes, he can.
Mauro, it seems you have some general misconceptions about the license you are working with.
The GPL is copyleft. This means you may not change the license. But you may change the code as much as you like and redistribute it under the terms of the original license.
Btw, this also applies to additional "Copyright"-notices by authors of new parts of a driver, as far as it does not change the copyright of any original autors or the license terms of the GPL v2:
Quoted 1 line
http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/47411
==> Yes, the GPL /is/ copyleft.