5769cf63: LTP semget02 TFAILs
Hi Davidlohr,
We noticed LTP test failures
ltp.msgget02.1.TFAIL
ltp.semget02.2.TFAIL
ltp.semget02.3.TFAILand the first bad commit is
commit 5769cf6355d87f63906b3e51887eff7017c39217
Author: Davidlohr Bueso <[email protected]> AuthorDate: Wed Jan 15 16:56:01 2014 +1100 Commit: Stephen Rothwell <[email protected]> CommitDate: Wed Jan 15 16:56:01 2014 +1100
ipc: share ids rwsem when possible in ipcget_public
... and rewrite the function. For scenarios where the key is found and we end up just doing different routinary checks, we can downgrade the ids->rwsem and share it among concurrent readers. These checks include the following, which are all safe to share the lock:
ops->more_checks() >> sem_more_checks(), shm_more_checks() ipc_check_perms() >> ipcperms(),ops->associate() >> [lsm]_[ipctype]_associate()
ipc/util.c | 60 +++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 33 insertions(+), 27 deletions(-)
Thanks,
Fengguang
[ Just adding Andrew to the cc list ]
Quoted 39 lines · On Fri, 17 Jan 2014 18:24:28 +0800 Fengguang Wu <[email protected]> wrote:
Hi Davidlohr,
We noticed LTP test failures
ltp.msgget02.1.TFAIL ltp.semget02.2.TFAIL ltp.semget02.3.TFAILand the first bad commit is
commit
5769cf6355d87f63906b3e51887eff7017c39217Author: Davidlohr Bueso <[email protected]> AuthorDate: Wed Jan 15 16:56:01 2014 +1100 Commit: Stephen Rothwell <[email protected]> CommitDate: Wed Jan 15 16:56:01 2014 +1100ipc: share ids rwsem when possible in
ipcget_public... and rewrite the function. For scenarios where the key is found and we end up just doing different routinary checks, we can downgrade the
ids->rwsemand share it among concurrent readers. These checks include the following, which are all safe to share the lock:
ops->more_checks()>>sem_more_checks(),shm_more_checks()ipc_check_perms()>> ipcperms(),ops->associate() >> [lsm]_[ipctype]_associate()Signed-off-by Davidlohr Bueso <[email protected]>Cc Aswin Chandramouleeswaran <[email protected]>Cc Rik van Riel <[email protected]>Cc Manfred Spraul <[email protected]>Signed-off-by Andrew Morton <[email protected]>ipc/util.c | 60 +++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 33 insertions(+), 27 deletions(-)Thanks,
Fengguang
Signature · 2 lines
Cheers, Stephen Rothwell [email protected]
Quoted 10 lines · On Fri, 17 Jan 2014 18:24:28 +0800 Fengguang Wu <[email protected]> wrote:
Hi Davidlohr,
We noticed LTP test failures
ltp.msgget02.1.TFAIL ltp.semget02.2.TFAIL ltp.semget02.3.TFAILand the first bad commit is
Quoted 8 lines
commit
5769cf6355d87f63906b3e51887eff7017c39217Author: Davidlohr Bueso <[email protected]> AuthorDate: Wed Jan 15 16:56:01 2014 +1100 Commit: Stephen Rothwell <[email protected]> CommitDate: Wed Jan 15 16:56:01 2014 +1100ipc: share ids rwsem when possible in
ipcget_public
Thanks (a lot). I'll disable that patch for now.