Skip to contentSkip to conversation

usb: gadget: gr_udc: remove some unneeded error handling

PATCH New Dan Carpenter 1 participant 1 message Jan 17, 2014

Subsystems (2)
USB Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH v2 1/1 usb: gadget: gr_udc: remove some unneeded error handling

Debugfs function return an ERR_PTR if they compiled out. We don't need to test for that here because if the debugfs file are compiled out then it is ok to pass an ERR_PTR to debugfs_create_file() since it will just be a no-op stub.

Debugfs return NULLs on error, but we don't need to test for that either because debugfs_create_file() will accept NULL pointers.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: remove the error handling. It's not needed

drivers/usb/gadget/gr_udc.c +2 -8
index 914cbd84ee40..f984ee75324d 100644
@@ -225,14 +225,8 @@ static void gr_dfs_create(struct gr_udc *dev)
 	const char *name = "gr_udc_state";
 
 	dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL);
-	if (IS_ERR(dev->dfs_root)) {
-		dev_err(dev->dev, "Failed to create debugfs directory\n");
-		return;
-	}
-	dev->dfs_state = debugfs_create_file(name, 0444, dev->dfs_root,
-					     dev, &gr_dfs_fops);
-	if (IS_ERR(dev->dfs_state))
-		dev_err(dev->dev, "Failed to create debugfs file %s\n", name);
+	dev->dfs_state = debugfs_create_file(name, 0444, dev->dfs_root, dev,
+					     &gr_dfs_fops);
 }
 
 static void gr_dfs_delete(struct gr_udc *dev)