Skip to contentSkip to conversation

Nomadik clk not MULTI_V5 friendly

DISCUSSION Andrew Lunn 2 participants 2 messages Jan 20, 2014 – Jan 21, 2014

lore
Share & tools
lore
#0 lore raw

Hi Linus

drivers/clk/clk-nomadik.c:

static int __init nomadik_src_clk_init_debugfs(void)

{
        src_pcksr0_boot = readl(src_base + SRC_PCKSR0);
        src_pcksr1_boot = readl(src_base + SRC_PCKSR1);
        debugfs_create_file("nomadik-src-clk", S_IFREG | S_IRUGO,
                            NULL, NULL, &nomadik_src_clk_debugfs_ops);
        return 0;
}

module_init(nomadik_src_clk_init_debugfs);

It does not check if it is actually running on a Nomadik, so when this module_init() is executed on kirkwood as part of a MULTI_V5 kernel, bad things happen. Please could you add the necessary check.

Thanks
Andrew

#1 lore raw
Quoted 3 lines · Andrew Lunn

It does not check if it is actually running on a Nomadik, so when this module_init() is executed on kirkwood as part of a MULTI_V5 kernel, bad things happen. Please could you add the necessary check.

Sure, fixed it, can you test and provide your Tested-by tag to Mike so he can merge it?

Yours,
Linus Walleij