ipi_redirect vs rq_affinity
Hi Jens,
it seems like blk-mq uses the ipi_redirect attribute in pretty much the same way as the old blk-softirq code used the rq_affinity one, except that the old code has an additional option to direct into any core in the current package.
Is there any good reason to not reuse the old name and semantics?
Quoted 8 lines · Christoph Hellwig
Hi Jens,
it seems like blk-mq uses the
ipi_redirectattribute in pretty much the same way as the old blk-softirq code used therq_affinityone, except that the old code has an additional option to direct into any core in the current package.Is there any good reason to not reuse the old name and semantics?
It is pretty much the same. I don't like the semantics of the old one, where it's 0/1/2 for off/on/different-on, though. Seems like now would be a good time to clean it up.
Signature · 1 line
Jens Axboe
Quoted 3 lines · Jens Axboe
It is pretty much the same. I don't like the semantics of the old one, where it's 0/1/2 for off/on/different-on, though. Seems like now would be a good time to clean it up.
I don't think arbitrarily breaking this fairly widely used interface when a driver is moving to blk-mq sounds like a good idea. Maybe we should allow for setting descriptive strings as well?
Also the different on semantics do matter for some use cases, and we should support both for blk-mq.
Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · Jens Axboe
It is pretty much the same. I don't like the semantics of the old one, where it's 0/1/2 for off/on/different-on, though. Seems like now would be a good time to clean it up.
I don't think arbitrarily breaking this fairly widely used interface when a driver is moving to blk-mq sounds like a good idea. Maybe we should allow for setting descriptive strings as well?
Yeah, that's a good idea. We could retain the 0/1/2 for compat reasons, but have it present strings instead.
Quoted 2 lines
Also the different on semantics do matter for some use cases, and we should support both for blk-mq.
Certainly, not disagreeing with that.
Signature · 1 line
Jens Axboe