hung_task: Display every hung task warning
Subsystems (3)
v5 cover hung_task: Display every hung task warning
When khungtaskd detects hung tasks, it prints out backtraces from a number of those tasks. Limiting the number of backtraces being printed out can result in the user not seeing the information necessary to debug the issue. The hung_task_warnings sysctl controls this feature.
This patch makes it possible for hung_task_warnings to accept a special value to print an unlimited number of backtraces when khungtaskd detects hung tasks.
The special value is -1. To use this value it is necessary to change types from ulong to int.
Rebased against v3.13-rc8.
Changes since v4:
- Improve the documentation on hung_task_warnings
Changes since v3:
- Simplify the commit message (Rik van Riel and David Rientjes)
- Document hung_task_* sysctl parameters (David Rientjes)
Aaron Tomlin (2):
sysctl: Make neg_one a standard constraint
hung_task: Display every hung task warning
Documentation/sysctl/kernel.txt | 42 +++++++++++++++++++++++++++++++++++++++++ include/linux/sched/sysctl.h | 2 +- kernel/hung_task.c | 6 ++++-- kernel/sysctl.c | 6 ++++-- 4 files changed, 51 insertions(+), 5 deletions(-)
Signature · 1 line
1.8.4.2
RFC PATCH v5 1/2 sysctl: Make neg_one a standard constraint
Add neg_one to the list of standard constraints.
--- kernel/sysctl.c | 1 + 1 file changed, 1 insertion(+)
kernel/sysctl.c +1 -0
@@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;static int sixty =60 ;#endif +static int neg_one =-1 ;static int zero;static int __maybe_unused one =1 ;static int __maybe_unused two =2 ;
Signature · 1 line
1.8.4.2
Re: [RFC PATCH v5 1/2] sysctl: Make neg_one a standard constraint
Quoted 14 lines · Aaron Tomlin
Add
neg_oneto the list of standard constraints.Signed-off-by Aaron Tomlin <[email protected]>Acked-by Rik van Riel <[email protected]>Acked-by David Rientjes <[email protected]>--- kernel/sysctl.c | 1 + 1 file changed, 1 insertion(+)kernel/sysctl.c +0
-0
kernel/sysctl.c extern int blk_iopoll_enabled; · line 128
Quoted 7 lines
kernel/sysctl.c +1
-0@@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;static int sixty =60 ;#endif +static int neg_one =-1 ;static int zero;static int __maybe_unused one =1 ;static int __maybe_unused two =2 ;
So what happens if CONFIG_DETECT_HUNG_TASK is not defined and neg_one is unused? The compiler generates an unused variable warning.
Thanks,
Ingo
Re: [RFC PATCH v5 1/2] sysctl: Make neg_one a standard constraint
Quoted 20 lines · Ingo Molnar
Quoted 17 lines · Aaron Tomlin
Add
neg_oneto the list of standard constraints.Signed-off-by Aaron Tomlin <[email protected]>Acked-by Rik van Riel <[email protected]>Acked-by David Rientjes <[email protected]>--- kernel/sysctl.c | 1 + 1 file changed, 1 insertion(+)kernel/sysctl.c +0
-0@@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;static int sixty =60 ;#endif
Quoted 8 lines
kernel/sysctl.c extern int blk_iopoll_enabled; · line 128
Quoted 4 lines
kernel/sysctl.c +1
-0+static int neg_one =-1 ;static int zero;static int __maybe_unused one =1 ;static int __maybe_unused two =2 ;So what happens if
CONFIG_DETECT_HUNG_TASKis not defined andneg_oneis unused? The compiler generates an unused variable warning.
Note, I fixed this up in your patch, no need to resend.
Thanks,
Ingo
RFC PATCH v5 2/2 hung_task: Display every hung task warning
In reply to Aaron TomlinWhen khungtaskd detects hung tasks, it prints out backtraces from a number of those tasks. Limiting the number of backtraces being printed out can result in the user not seeing the information necessary to debug the issue. The hung_task_warnings sysctl controls this feature.
This patch makes it possible for hung_task_warnings to accept a special value to print an unlimited number of backtraces when khungtaskd detects hung tasks.
The special value is -1. To use this value it is necessary to change types from ulong to int.
--- Documentation/sysctl/kernel.txt | 43 +++++++++++++++++++++++++++++++++++++++++ include/linux/sched/sysctl.h | 2 +- kernel/hung_task.c | 6 ++++-- kernel/sysctl.c | 5 +++-- 4 files changed, 51 insertions(+), 5 deletions(-)
Documentation/sysctl/kernel.txt +43 -0
@@ -33,6 +33,10 @@ show up in /proc/sys/kernel: - domainname - hostname - hotplug +- hung_task_panic +- hung_task_check_count +- hung_task_timeout_secs +- hung_task_warnings - kptr_restrict - kstack_depth_to_print [ X86 only ] - l2cr [ PPC only ]
@@ -287,6 +291,45 @@ Default value is "/sbin/hotplug". ============================================================== +hung_task_panic: + +Controls the kernel's behavior when a hung task is detected. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +0: continue operation. This is the default behavior. + +1: panic immediately. + +============================================================== + +hung_task_check_count: + +The upper bound on the number of tasks that are checked. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +============================================================== + +hung_task_timeout_secs: + +Check interval. When a task in D state did not get scheduled +for more than this value report a warning. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +0: means infinite timeout - no checking done. + +============================================================== + +hung_task_warning: + +The maximum number of warnings to report. During a check interval +if a hung task is detected, this value is decreased by 1. +When this value reaches 0, no more warnings will be reported. +This file shows up if CONFIG_DETECT_HUNG_TASK is enabled. + +-1: report an infinite number of warnings. + +============================================================== + kptr_restrict: This toggle indicates whether restrictions are placed on
include/linux/sched/sysctl.h +1 -1
@@ -5,7 +5,7 @@extern int sysctl_hung_task_check_count;extern unsigned int sysctl_hung_task_panic;extern unsigned long sysctl_hung_task_timeout_secs; -extern unsigned long sysctl_hung_task_warnings; +extern int sysctl_hung_task_warnings;extern int proc_dohung_task_timeout_secs (struct ctl_table *table,int write,void __user *buffer,size_t *lenp,loff_t *ppos);
kernel/hung_task.c +4 -2
@@ -37,7 +37,7 @@ int __read_mostly sysctl_hung_task_check_count = PID_MAX_LIMIT;*/ unsigned long __read_mostly sysctl_hung_task_timeout_secs =CONFIG_DEFAULT_HUNG_TASK_TIMEOUT ; -unsigned long __read_mostly sysctl_hung_task_warnings =10 ; +int __read_mostly sysctl_hung_task_warnings =10 ;static int __read_mostly did_panic;
@@ -98,7 +98,9 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)if (!sysctl_hung_task_warnings)return ; - sysctl_hung_task_warnings--; + +if (sysctl_hung_task_warnings >0 ) + sysctl_hung_task_warnings--;/* * Ok, the task did not get scheduled for more than 2 minutes,
kernel/sysctl.c +3 -2
@@ -985,9 +985,10 @@ static struct ctl_table kern_table[] = { { .procname = "hung_task_warnings", .data = &sysctl_hung_task_warnings, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_doulongvec_minmax, + .proc_handler = proc_dointvec_minmax, + .extra1 = &neg_one, }, #endif #ifdef CONFIG_COMPAT
Signature · 1 line
1.8.4.2