Skip to contentSkip to conversation

efi: Add newline to cper DIMM location messages

PATCH In review Luck, Tony 2 participants 4 messages Jan 24, 2014 – Jan 27, 2014 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Luck, Tony

author
#0 lore raw

PATCH 1/1 efi: Add newline to cper DIMM location messages

We forgot the newline at the end of two messages. Add it.

---

drivers/firmware/efi/cper.c +2 -2
index 1491dd4f08f9..9f59f6ba271a 100644
@@ -240,9 +240,9 @@ static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem)
 		const char *bank = NULL, *device = NULL;
 		dmi_memdev_name(mem->mem_dev_handle, &bank, &device);
 		if (bank != NULL && device != NULL)
-			printk("%s""DIMM location: %s %s", pfx, bank, device);
+			printk("%s""DIMM location: %s %s\n", pfx, bank, device);
 		else
-			printk("%s""DIMM DMI handle: 0x%.4x",
+			printk("%s""DIMM DMI handle: 0x%.4x\n",
 			       pfx, mem->mem_dev_handle);
 	}
 }

A message that is not in the archive (sent off-list or not yet received): 52e2e98e64494f92-E6Nu+q68HHTI/KE9syI0vLvm/[email protected]

#2 lore raw
Quoted 3 lines · Tony

We forgot the newline at the end of two messages. Add it.

Looks fine to me. Are you going to take this or should I?

Signature · 1 line
Matt Fleming, Intel Open Source Technology Center

A message that is not in the archive (sent off-list or not yet received): 20140125094653.GE17297-HNK1S37rvNbeXh+fF434Mdi2O/[email protected]

author
#4 lore raw
Quoted 5 lines
Quoted 3 lines

We forgot the newline at the end of two messages. Add it.

Looks fine to me. Are you going to take this or should I?

If that's a "Ack" - then I can send it up.

-Tony

A message that is not in the archive (sent off-list or not yet received): 3908561D78D1C84285E8C5FCA982C28F31DB9FA6-P5GAC/[email protected]

#6 lore raw
Quoted 7 lines · Tony
Quoted 5 lines
Quoted 3 lines

We forgot the newline at the end of two messages. Add it.

Looks fine to me. Are you going to take this or should I?

If that's a "Ack" - then I can send it up.

Yep, that's an ACK.

Signature · 1 line
Matt Fleming, Intel Open Source Technology Center