Skip to contentSkip to conversation

MAINTAINERS: add self as virtio co-maintainer

PATCH In review Michael S. Tsirkin 3 participants 6 messages Jan 26, 2014 – Jan 27, 2014

lore
Share & tools
lore
#1 lore raw

Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben:

Quoted 1 line

This will help make sure I get Cc'd on patches.

You wish...

This won't change the actual responsibility, i.e. patches to virtio-blk are still meant to be merged through the block tree, right? It's just so you get a chance to comment?

Kevin

Quoted 19 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index fb53242..adc5973 100644
@@ -610,6 +610,7 @@ F: hw/*/*vhost*
 
 virtio
 M: Anthony Liguori <[email protected]>
+M: Michael S. Tsirkin <[email protected]>
 S: Supported
 F: hw/*/virtio*
 
Signature · 1 line
MST
#2 lore raw
Quoted 10 lines · Kevin Wolf

Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben:

Quoted 1 line

This will help make sure I get Cc'd on patches.

You wish...

This won't change the actual responsibility, i.e. patches to virtio-blk are still meant to be merged through the block tree, right? It's just so you get a chance to comment?

Kevin

Right - not different from Anthony really.
Well for things completely unrelated to block, like virtio 1.0 support it might make sense to merged them through my tree.

Quoted 19 lines
Quoted 19 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index fb53242..adc5973 100644
@@ -610,6 +610,7 @@ F: hw/*/*vhost*
 
 virtio
 M: Anthony Liguori <[email protected]>
+M: Michael S. Tsirkin <[email protected]>
 S: Supported
 F: hw/*/virtio*
 
Signature · 1 line
MST
Acked-by
#3 lore raw

Am 27.01.2014 um 11:53 hat Michael S. Tsirkin geschrieben:

Quoted 10 lines · Kevin Wolf
Quoted 9 lines

Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben:

Quoted 1 line

This will help make sure I get Cc'd on patches.

You wish...

This won't change the actual responsibility, i.e. patches to virtio-blk are still meant to be merged through the block tree, right? It's just so you get a chance to comment?

Quoted 5 lines
Quoted 1 line

Kevin

Right - not different from Anthony really.
Well for things completely unrelated to block, like virtio 1.0 support it might make sense to merged them through my tree.

Yes, I agree. In that case:

#4 lore raw
In reply to Kevin Wolf
Quoted 8 lines · Kevin Wolf

Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben:

Quoted 1 line

This will help make sure I get Cc'd on patches.

You wish...

This won't change the actual responsibility, i.e. patches to virtio-blk are still meant to be merged through the block tree, right? It's just so you get a chance to comment?

The proper way to document that is for us to split out virtio-blk.c and add the block tree git repo URL. Let's avoid informal agreements so that maintainership is clear to everyone from just the ./MAINTAINERS file.

Stefan

#5 lore raw
Quoted 10 lines · Stefan Hajnoczi
Quoted 8 lines · Kevin Wolf

Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben:

Quoted 1 line

This will help make sure I get Cc'd on patches.

You wish...

This won't change the actual responsibility, i.e. patches to virtio-blk are still meant to be merged through the block tree, right? It's just so you get a chance to comment?

Quoted 5 lines

The proper way to document that is for us to split out virtio-blk.c and add the block tree git repo URL. Let's avoid informal agreements so that maintainership is clear to everyone from just the ./MAINTAINERS file.

Stefan

MAINTAINERS is really about getting all the right people Cc'd. Who merges what can't be formalized using regular expressions:
it depends on more than which files are changed.

Signature · 1 line
MST