Skip to contentSkip to conversation

i40e: Add missing braces to i40e_dcb_need_reconfig()

PATCH Dave Jones 2 participants 2 messages Jan 28, 2014

Subsystems (3)
Networking Network drivers Intel Ethernet
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Indentation mismatch spotted with Coverity. Introduced in 4e3b35b044ea ("i40e: add DCB and DCBNL support")

Signed-off-by Dave Jones <[email protected]>
drivers/net/ethernet/intel/i40e/i40e_main.c +2 -1
index a4b940862b83..b901371ca361 100644
@@ -4440,9 +4440,10 @@ bool i40e_dcb_need_reconfig(struct i40e_pf *pf,
 	/* Check if APP Table has changed */
 	if (memcmp(&new_cfg->app,
 		   &old_cfg->app,
-		   sizeof(new_cfg->app)))
+		   sizeof(new_cfg->app))) {
 		need_reconfig = true;
 		dev_info(&pf->pdev->dev, "APP Table change detected.\n");
+	}
 
 	return need_reconfig;
 }
maintainer
#1 lore raw

From: Dave Jones <[email protected]>
Date: Mon, 27 Jan 2014 23:11:09 -0500

Quoted 4 lines

Indentation mismatch spotted with Coverity. Introduced in 4e3b35b044ea ("i40e: add DCB and DCBNL support")

Signed-off-by Dave Jones <[email protected]>

Looks straightforward enough for me to apply directly, thanks Dave.