Skip to contentSkip to conversation

libsocketcan: license

PATCH New yegorslists at googlemail.com 3 participants 4 messages Jan 16, 2014 – Jan 29, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libsocketcan: license

The GPL 2.1 LICENSE file is available in package's git repo and will be included in the next reslease.

#1 lore raw

PATCH 1/1 libsocketcan: new package

From: Yegor Yefremov <[email protected]>

---
 package/Config.in                    |    1 +
 package/libsocketcan/Config.in       |    6 ++++++
 package/libsocketcan/libsocketcan.mk |   10 ++++++++++
 3 files changed, 17 insertions(+), 0 deletions(-)
 create mode 100644 package/libsocketcan/Config.in
 create mode 100644 package/libsocketcan/libsocketcan.mk
package/Config.in +1 -0
index 2f62d6c..dca90d9 100644
@@ -677,6 +677,7 @@ source "package/liboping/Config.in"
 source "package/libosip2/Config.in"
 source "package/libpcap/Config.in"
 source "package/librsync/Config.in"
+source "package/libsocketcan/Config.in"
 source "package/libsoup/Config.in"
 source "package/libtirpc/Config.in"
 source "package/libtorrent/Config.in"
package/libsocketcan/Config.in new file +6 -0
new file mode 100644
index 0000000..97903db
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBSOCKETCAN
+	bool "libsocketcan"
+	help
+	  SocketCAN library to control CAN devices from C code.
+
+	  http://git.pengutronix.de/?p=tools/libsocketcan.git;a=summary
package/libsocketcan/libsocketcan.mk new file +10 -0
new file mode 100644
index 0000000..920a900
@@ -0,0 +1,10 @@
+################################################################################
+#
+# libsocketcan
+#
+################################################################################
+LIBSOCKETCAN_VERSION = 0.0.9
+LIBSOCKETCAN_SITE = http://www.pengutronix.de/software/libsocketcan/download/
+LIBSOCKETCAN_SOURCE = libsocketcan-$(LIBSOCKETCAN_VERSION).tar.bz2
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.7
#3 lore raw

PATCH 1/1 libsocketcan: new package

In reply to yegorslists at googlemail.com

Hello Yegor,

package/libsocketcan/libsocketcan.mk line 6

Quoted 12 lines · yegorslists at googlemail.com
package/libsocketcan/libsocketcan.mk new file +6 -0
new file mode 100644
index 0000000..920a900
@@ -0,0 +1,10 @@
+################################################################################
+#
+# libsocketcan
+#
+################################################################################
+LIBSOCKETCAN_VERSION = 0.0.9

Missing empty newline between comment header and the first variable.

package/libsocketcan/libsocketcan.mk line 10

Quoted 4 lines
package/libsocketcan/libsocketcan.mk new file +4 -0
+LIBSOCKETCAN_SITE = http://www.pengutronix.de/software/libsocketcan/download/
+LIBSOCKETCAN_SOURCE = libsocketcan-$(LIBSOCKETCAN_VERSION).tar.bz2
+
+$(eval $(autotools-package))

Even if the license text is not available, it would have been good to add LIBSOCKETCAN_LICENSE anyway.

Since Peter has already committed your patch, can you send a followup patch to fix those two issues, against the latest master branch?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com