Skip to contentSkip to conversation

Add gpm (general purpose mouse) server package

PATCH Superseded julien.boibessot at free.fr 2 participants 2 messages Jan 29, 2014

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Add gpm (general purpose mouse) server package

From: Julien Boibessot <[email protected]>

---
Changes since v2:
- As recommended by Yann:
* spell check
* use BR autoconf/make/libtool but in SDL package way
* put optionnal GPM_REMOVE_TEST_TOOLS_FROM_TARGET into ifeq

Changes since v1:
- 80x # in gpm.mk banner
- As recommended by Romain:
* remove possible circular dependency with ncurses
* don't allow package selection when BR2_PREFER_STATIC_LIB=y
* fixes headers path when gpm wants to build its dependencies rules

 package/Config.in     |    1 +
 package/gpm/Config.in |   24 ++++++++++++++++++++++
 package/gpm/gpm.mk    |   52 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 77 insertions(+), 0 deletions(-)
 create mode 100644 package/gpm/Config.in
 create mode 100644 package/gpm/gpm.mk
package/Config.in +1 -0
index 78c0e06..d52c65e 100644
@@ -290,6 +290,7 @@ source "package/fmtools/Config.in"
 source "package/freescale-imx/Config.in"
 source "package/fxload/Config.in"
 source "package/gadgetfs-test/Config.in"
+source "package/gpm/Config.in"
 source "package/gpsd/Config.in"
 source "package/gptfdisk/Config.in"
 source "package/gvfs/Config.in"
package/gpm/Config.in new file +24 -0
new file mode 100644
index 0000000..d20e392
@@ -0,0 +1,24 @@
+config BR2_PACKAGE_GPM
+	bool "gpm mouse server"
+	depends on !BR2_PREFER_STATIC_LIB
+	help
+	  "gpm" means general purpose mouse (server) and provides mouse support
+	  for Linux virtual consoles.
+	  gpm-root (to draw menus in current virtual console; config file in
+	  /etc/gpm-root.conf) and disable-paste (to disable paste buffer for
+	  security reasons), will also be installed.
+
+	  http://www.nico.schottelius.org/software/gpm/
+
+if BR2_PACKAGE_GPM
+
+config BR2_PACKAGE_GPM_INSTALL_TEST_TOOLS
+	bool "install gpm test tools also"
+	help
+	  Install gpm test tools (get-versions, mev, hltest, mouse-test,
+	  display-buttons & display-coords).
+
+endif
+
+comment "gpm mouse server needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
package/gpm/gpm.mk new file +52 -0

52 lines not on this page · raw message

Signature · 1 line
1.7.5.4
#1 lore raw

PATCH v3 1/1 Add gpm (general purpose mouse) server package

Julien,

package/gpm/Config.in line 2

Quoted 8 lines · julien.boibessot at free.fr
package/gpm/Config.in new file +2 -0
new file mode 100644
index 0000000..d20e392
@@ -0,0 +1,24 @@
+config BR2_PACKAGE_GPM
+	bool "gpm mouse server"

I believe we normally don't describe what the component is in its short description. It should just be the name, i.e "gpm", unless the name of the project is really "gpm mouse server".

package/gpm/Config.in line 16

Quoted 2 lines
package/gpm/Config.in new file +2 -0
+config BR2_PACKAGE_GPM_INSTALL_TEST_TOOLS
+	bool "install gpm test tools also"

Why do we have "also" here ? This should probably just be:

bool "install test tools"

there is no need to repeat "gpm", because this option is automatically shown "under" the gpm option.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com