Skip to contentSkip to conversation

b43: possible missing break in b43_wa_all

RFC New Dave Jones 1 participant 1 message Jan 29, 2014

Subsystems (3)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

RFC 1/1 b43: possible missing break in b43_wa_all

I'm going through all the 'missing break in switch' bugs in coverity, and most of them look like intentional/false positives, but this one looks odd to me.

It seems the intent is to B43_WARN_ON only if we don't know the phy, so it seems strange to do it after we've just initialized type 7.

If this is agreed to be a bug, I'll submit the below patch properly, but I want to be sure this isn't something like "type 7 is work in progress" It's been this way since 2007 though. I guess no-one runs with CONFIG_B43_DEBUG on.

Dave

drivers/net/wireless/b43/wa.c +1 -0
index 9b1a038be08b..47f0ec887e1f 100644
@@ -587,6 +587,7 @@ void b43_wa_all(struct b43_wldev *dev)
 			b43_wa_txpuoff_rxpuon(dev);
 			b43_wa_txlna_gain(dev);
 			b43_wa_rssi_adc(dev);
+			break;
 		default:
 			B43_WARN_ON(1);
 		}