Skip to contentSkip to conversation

Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk

PATCH New Yann E. MORIN 2 participants 3 messages Jan 29, 2014

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk

From: "Yann E. MORIN" <[email protected]>

The current default for BR2_PACKAGE_OVERRIDE_FILE points to:

    $(TOPDIR)/local.mk

This works well for in-tree builds, but is not very useful for out-of-tree builds, when the Buildroot source tree may be shared for different concurrent builds.

Also, it seems to be more sensible to have local.mk alognside the .config file.

Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:

    $(CONFIG_DIR)/local.mk
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Config.in +1 -1
index 7ec7c2a..f8d6e23 100644
@@ -488,7 +488,7 @@ config BR2_HAVE_DOCUMENTATION
 
 config BR2_PACKAGE_OVERRIDE_FILE
 	string "location of a package override file"
-	default "$(TOPDIR)/local.mk"
+	default "$(CONFIG_DIR)/local.mk"
 	help
 	  A package override file is a short makefile that contains
 	  variable definitions of the form <pkg>_OVERRIDE_SRCDIR,
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk

Op 29-jan.-2014 19:43 schreef "Yann E. MORIN" <[email protected]>:

Quoted 10 lines

From: "Yann E. MORIN" <[email protected]>

The current default for BR2_PACKAGE_OVERRIDE_FILE points to:

    $(TOPDIR)/local.mk

This works well for in-tree builds, but is not very useful for out-of-tree builds, when the Buildroot source tree may be shared for different concurrent builds.

Quoted 5 lines

Also, it seems to be more sensible to have local.mk alognside the .config file.

Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:

    $(CONFIG_DIR)/local.mk

... which in the default case equals TOPDIR, right? (Would be nice to
clarify in the commit message)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140129/80ac9d1a/attachment.html>

author
#2 lore raw

PATCH 1/1 Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk

Thomas, All,

On 2014-01-29 21:45 +0100, Thomas De Schampheleire spake thusly:

Quoted 11 lines

Op 29-jan.-2014 19:43 schreef "Yann E. MORIN" <[email protected]>:

Quoted 10 lines

From: "Yann E. MORIN" <[email protected]>

The current default for BR2_PACKAGE_OVERRIDE_FILE points to:

    $(TOPDIR)/local.mk

This works well for in-tree builds, but is not very useful for out-of-tree builds, when the Buildroot source tree may be shared for different concurrent builds.

Quoted 8 lines
Quoted 5 lines

Also, it seems to be more sensible to have local.mk alognside the .config file.

Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:

    $(CONFIG_DIR)/local.mk

... which in the default case equals TOPDIR, right? (Would be nice to clarify in the commit message)

Oh, yes. I intended to write that part, but was absorbed by the very nice fumet of the dinner being cooked at the time I wrote the commit log.

I plead guilty for having been disturbed by my nostrils, and my stomach!

I'll respin with that added. Thank you! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'