Skip to contentSkip to conversation

tda10071: remove a duplicative test

PATCH In review Dan Carpenter 2 participants 2 messages Jan 30, 2014

Subsystems (3)
Media (V4L/DVB) Kernel janitors TDA10071 media driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 tda10071: remove a duplicative test

"ret" is an error code here, we already tested that.

Signed-off-by Dan Carpenter <[email protected]>
drivers/media/dvb-frontends/tda10071.c +1 -2
index 8ad3a57cf640..a76df29c4973 100644
@@ -1006,8 +1006,7 @@ static int tda10071_init(struct dvb_frontend *fe)
 				dev_err(&priv->i2c->dev, "%s: firmware " \
 						"download failed=%d\n",
 						KBUILD_MODNAME, ret);
-				if (ret)
-					goto error_release_firmware;
+				goto error_release_firmware;
 			}
 		}
 		release_firmware(fw);
Acked-by Reviewed-by on v1 1/1
#1 lore raw
Acked-by Antti Palosaari <[email protected]>
Reviewed-by Antti Palosaari <[email protected]>

I will query that to the kernel 3.15.

thanks
Antti

Quoted 23 lines · Dan Carpenter

"ret" is an error code here, we already tested that.

Signed-off-by Dan Carpenter <[email protected]>
drivers/media/dvb-frontends/tda10071.c +1 -3
index 8ad3a57cf640..a76df29c4973 100644
@@ -1006,8 +1006,7 @@ static int tda10071_init(struct dvb_frontend *fe)
  				dev_err(&priv->i2c->dev, "%s: firmware " \
  						"download failed=%d\n",
  						KBUILD_MODNAME, ret);
-				if (ret)
-					goto error_release_firmware;
+				goto error_release_firmware;
  			}
  		}
  		release_firmware(fw);
--

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
http://palosaari.fi/