Added menu entry to build squashfs host tools separately
PATCH 1/1 Added menu entry to build squashfs host tools separately
Before, the squashfs tools for host were only built when a squashfs root filesystem image was generated.
If the squashfs image is selected, it automatically selects the squahsfs host tools as well. Consequently, I've removed host-squashfs from ROOTFS_SQUASHFS_DEPENDENCIES.
--- fs/squashfs/Config.in | 1 + fs/squashfs/squashfs.mk | 2 -- package/Config.in.host | 1 + package/squashfs/Config.in.host | 6 ++++++ 4 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 package/squashfs/Config.in.host
fs/squashfs/Config.in +1 -0
@@ -1,5 +1,6 @@ config BR2_TARGET_ROOTFS_SQUASHFS bool "squashfs root filesystem" + select BR2_PACKAGE_HOST_SQUASHFS help Build a squashfs root filesystem
fs/squashfs/squashfs.mk +0 -2
@@ -4,8 +4,6 @@ # ################################################################################ -ROOTFS_SQUASHFS_DEPENDENCIES = host-squashfs - ifeq ($(BR2_TARGET_ROOTFS_SQUASHFS4_LZO),y) ROOTFS_SQUASHFS_ARGS += -comp lzo else
package/Config.in.host +1 -0
@@ -12,6 +12,7 @@ source "package/omap-u-boot-utils/Config.in.host" source "package/openocd/Config.in.host" source "package/parted/Config.in.host" source "package/sam-ba/Config.in.host" +source "package/squashfs/Config.in.host" source "package/sunxi-tools/Config.in.host" source "package/uboot-tools/Config.in.host"
package/squashfs/Config.in.host new file +6 -0
@@ -0,0 +1,6 @@ +config BR2_PACKAGE_HOST_SQUASHFS + bool "host squashfs" + help + Tools to generate SquashFS filesystems. + + http://squashfs.sourceforge.net/
--
1.7.1
PATCH 1/1 Added menu entry to build squashfs host tools separately
Dear Jeroen De Wachter,
Quoted 3 lines · Jeroen De Wachter
If the squashfs image is selected, it automatically selects the squahsfs host tools as well. Consequently, I've removed host-squashfs from
ROOTFS_SQUASHFS_DEPENDENCIES.
In the other filesystems, we do not necessarily select BR2_PACKAGE_HOST_<utilities to build the filesystem>, and therefore we keep the <pkg>_DEPENDENCIES that contains host-<utilities to build the filesystem>.
I don't have a very strong opinion on which solution we should use, but I am sure that we want things to be consistent across the different filesystems. So for the time being:
Quoted 3 lines
config
BR2_TARGET_ROOTFS_SQUASHFS
bool "squashfs root filesystem"
+ selectBR2_PACKAGE_HOST_SQUASHFS
This is not necessary.
fs/squashfs/squashfs.mk line 7
Quoted 12 lines
help
Build a squashfs root filesystemfs/squashfs/squashfs.mk +0
-1@@ -4,8 +4,6 @@ # ################################################################################ -ROOTFS_SQUASHFS_DEPENDENCIES = host-squashfs
And this should be preserved.
Unless of course we decide to change our strategy.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 Added menu entry to build squashfs host tools separately
Quoted 4 lines · Thomas Petazzoni
Dear Jeroen De Wachter,
On Thu, 30 Jan 2014 14:52:23 +0100 (CET), Jeroen De Wachter wrote:
Quoted 8 lines
Quoted 3 lines
If the squashfs image is selected, it automatically selects the squahsfs host tools as well. Consequently, I've removed host-squashfs from
ROOTFS_SQUASHFS_DEPENDENCIES.In the other filesystems, we do not necessarily select BR2_PACKAGE_HOST_<utilities to build the filesystem>, and therefore we keep the <pkg>_DEPENDENCIES that contains host-<utilities to build the filesystem>.
I would actually prefer to have both the select and the dependencies,
since that's what we do for target packages.
In addition (but that's just a small consideration), if at some point
we make TARGETS contain only the target targets (heh), then the dependency chain for filesystems is still correct.
Regards,
Arnout
Quoted 30 lines
I don't have a very strong opinion on which solution we should use, but I am sure that we want things to be consistent across the different filesystems. So for the time being:
Quoted 3 lines
config
BR2_TARGET_ROOTFS_SQUASHFS
bool "squashfs root filesystem"
+ selectBR2_PACKAGE_HOST_SQUASHFSThis is not necessary.
fs/squashfs/squashfs.mk line 7
Quoted 12 lines
help
Build a squashfs root filesystemfs/squashfs/squashfs.mk +0
-1@@ -4,8 +4,6 @@ # ################################################################################ -ROOTFS_SQUASHFS_DEPENDENCIES = host-squashfsAnd this should be preserved.
Unless of course we decide to change our strategy.
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 Added menu entry to build squashfs host tools separately
Dear Arnout Vandecappelle,
Quoted 7 lines · Arnout Vandecappelle
Quoted 4 lines
In the other filesystems, we do not necessarily select BR2_PACKAGE_HOST_<utilities to build the filesystem>, and therefore we keep the <pkg>_DEPENDENCIES that contains host-<utilities to build the filesystem>.
I would actually prefer to have both the select and the dependencies,
since that's what we do for target packages.
But then we should be consistent and do this all over the place: as soon as a host package has a Config.in symbol, then it should be selected by its reverse dependencies.
Quoted 3 lines
In addition (but that's just a small consideration), if at some point
we make TARGETS contain only the target targets (heh), then the dependency chain for filesystems is still correct.
Hum, there are some host packages that we want to build and that are not dependencies of target packages. That's the very reason why we have the "Host utilities" menu.
That being said, it would certainly be good to have two make variables:
* TARGET_PACKAGES
* HOST_PACKAGES
that are respectively used to contain the list of targets for enabled target packages, and the list of targets for enabled host packages.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 Added menu entry to build squashfs host tools separately
Quoted 9 lines · Thomas Petazzoni
Dear Arnout Vandecappelle,
Quoted 5 lines · Arnout Vandecappelle
Quoted 4 lines
In the other filesystems, we do not necessarily select BR2_PACKAGE_HOST_<utilities to build the filesystem>, and therefore we keep the <pkg>_DEPENDENCIES that contains host-<utilities to build the filesystem>.
Quoted 6 lines
Quoted 2 lines
I would actually prefer to have both the select and the dependencies,
since that's what we do for target packages.But then we should be consistent and do this all over the place: as soon as a host package has a Config.in symbol, then it should be selected by its reverse dependencies.
Indeed.
Quoted 8 lines
Quoted 3 lines
In addition (but that's just a small consideration), if at some point
we make TARGETS contain only the target targets (heh), then the dependency chain for filesystems is still correct.Hum, there are some host packages that we want to build and that are not dependencies of target packages. That's the very reason why we have the "Host utilities" menu.
Quoted 8 lines
That being said, it would certainly be good to have two make variables:
*
TARGET_PACKAGES
*HOST_PACKAGESthat are respectively used to contain the list of targets for enabled target packages, and the list of targets for enabled host packages.
That's exactly what I mean.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 Added menu entry to build squashfs host tools separately
In reply to Jeroen De WachterJeroen, All,
On 2014-01-30 14:52 +0100, Jeroen De Wachter spake thusly:
Quoted 2 lines
Before, the squashfs tools for host were only built when a squashfs root filesystem image was generated.
We already have such a patch to that effect (and only about showing it in the menuconfig) waiting in the patchwork:
http://patchwork.ozlabs.org/patch/306629/
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 Added menu entry to build squashfs host tools separately
Ok,
I just wanted to make sure that when the squashfs host tools would be built, they'd show as selected in the host utilities too (regardless of whether they'd been selected separately or by enabling the squashfs file system image). I don't think that will be the case with the current patch?
I didn't check the way host tools were selected for the other filesystems though. I have no issues following convention :-)
Cheers,
Jeroen
----- Original Message -----
From: "Yann E. MORIN" <[email protected]>
To: "Jeroen De Wachter" <[email protected]>
Cc: buildroot at busybox.net
Sent: Monday, February 3, 2014 12:26:10 PM
Subject: Re: [Buildroot] [PATCH] Added menu entry to build squashfs host tools separately
Jeroen, All,
On 2014-01-30 14:52 +0100, Jeroen De Wachter spake thusly:
Quoted 2 lines
Before, the squashfs tools for host were only built when a squashfs root filesystem image was generated.
We already have such a patch to that effect (and only about showing it in the menuconfig) waiting in the patchwork:
http://patchwork.ozlabs.org/patch/306629/
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'