Skip to contentSkip to conversation

ARM: hisi: don't select SMP

PATCH New Rob Herring 2 participants 5 messages Jan 31, 2014 – Feb 1, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/HiSilicon SoC support
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 ARM: hisi: don't select SMP

From: Rob Herring <[email protected]>

SMP is a user configurable option, not a hardware feature and should not be selected.

Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/mach-hisi/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm/mach-hisi/Kconfig +0 -1
index 018ad67..8f4649b 100644
@@ -12,6 +12,5 @@ config ARCH_HI3xxx
 	select HAVE_SMP
 	select PINCTRL
 	select PINCTRL_SINGLE
-	select SMP
 	help
 	  Support for Hisilicon Hi36xx/Hi37xx processor family
Signature · 1 line
1.8.3.2
author
#2 lore raw

PATCH 1/1 ARM: hisi: don't select SMP

Quoted 9 lines · Olof Johansson
Quoted 6 lines · Rob Herring

From: Rob Herring <[email protected]>

SMP is a user configurable option, not a hardware feature and should not be selected.

Signed-off-by Rob Herring <[email protected]>

Yep, you're right. applied to fixes.

After doing some randconfig builds I found HAVE_ARM_TWD and HAVE_ARM_SCU need to have "if SMP" added here. I also found OMAP and SH-Mobile are still using LOCAL_TIMER which has been gone for a year. I guess everyone tests with other platforms enabled or don't notice they are using broadcast timer. Patch is coming.

Rob

#3 lore raw

PATCH 1/1 ARM: hisi: don't select SMP

Quoted 9 lines · Rob Herring
Quoted 8 lines · Olof Johansson
Quoted 6 lines · Rob Herring

From: Rob Herring <[email protected]>

SMP is a user configurable option, not a hardware feature and should not be selected.

Signed-off-by Rob Herring <[email protected]>
Quoted 7 lines
Quoted 1 line

Yep, you're right. applied to fixes.

After doing some randconfig builds I found HAVE_ARM_TWD and HAVE_ARM_SCU need to have "if SMP" added here. I also found OMAP and SH-Mobile are still using LOCAL_TIMER which has been gone for a year. I guess everyone tests with other platforms enabled or don't notice they are using broadcast timer. Patch is coming.

Yep, I noticed the same yesterday but please send the patch over and I'll apply it before sending up the current batch.

The OMAP platform that uses LOCAL_TIMER is OMAP5, and 5 isn't functional in mainline yet -- I can guarantee you that nobody is testing it. :(

-Olof

author
#4 lore raw

PATCH 1/1 ARM: hisi: don't select SMP

Quoted 18 lines · Olof Johansson
Quoted 9 lines · Rob Herring
Quoted 8 lines · Olof Johansson
Quoted 6 lines · Rob Herring

From: Rob Herring <[email protected]>

SMP is a user configurable option, not a hardware feature and should not be selected.

Signed-off-by Rob Herring <[email protected]>
Quoted 7 lines
Quoted 1 line

Yep, you're right. applied to fixes.

After doing some randconfig builds I found HAVE_ARM_TWD and HAVE_ARM_SCU need to have "if SMP" added here. I also found OMAP and SH-Mobile are still using LOCAL_TIMER which has been gone for a year. I guess everyone tests with other platforms enabled or don't notice they are using broadcast timer. Patch is coming.

Quoted 6 lines

Yep, I noticed the same yesterday but please send the patch over and I'll apply it before sending up the current batch.

The OMAP platform that uses LOCAL_TIMER is OMAP5, and 5 isn't functional in mainline yet -- I can guarantee you that nobody is testing it. :(

Actually that is needed for OMAP4 as ARM_TWD is the Cortex-A9 timers.

Rob