Skip to contentSkip to conversation

..another device for the ftdi_sio driver, 3rd infusion

PATCH Ulrich Hahn 2 participants 2 messages Feb 2, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
drivers/usb/serial/ftdi_sio.c +2 -0
diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio.c linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio.c
@@ -192,6 +192,8 @@
 	{ USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_IOBOARD_PID) },
 	{ USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_MINI_IOBOARD_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_SPROG_II) },
+	{ USB_DEVICE(FTDI_VID, FTDI_TAGSYS_LP101_PID) },
+	{ USB_DEVICE(FTDI_VID, FTDI_TAGSYS_P200X_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_LENZ_LIUSB_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_XF_632_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_XF_634_PID) },

Only in linux-3.13.1+tagsys/drivers/usb/serial: ftdi_sio.c.orig

drivers/usb/serial/ftdi_sio_ids.h +7 -0
diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio_ids.h linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio_ids.h
@@ -363,6 +363,13 @@
 /* Sprog II (Andrew Crosland's SprogII DCC interface) */
 #define FTDI_SPROG_II		0xF0C8
 
+/*
+ * Tagsys RFID Readers
+ * survey (two of them) by Ulrich Hahn
+ */
+#define FTDI_TAGSYS_LP101_PID	0xF0E9	/* Tagsys L-P101 RFID*/
+#define FTDI_TAGSYS_P200X_PID	0xF0EE	/* Tagsys Medio P200x RFID*/
+
 /* an infrared receiver for user access control with IR tags */
 #define FTDI_PIEGROUP_PID	0xF208	/* Product Id */
 
#1 lore raw

On Sun, Feb 02, 2014 at 12:10:56PM +0100, Ulrich Hahn wrote:

Please use a more descriptive subject line (which will end up as the commit log summary), e.g.

"[PATCH v3] USB: ftdi_sio: add Tagsys RFID Reader ids"

Note that the patch version should go in the [PATCH vX] (which will not show up in the git log).

You should also consider adding a slightly more verbose message in the body as well (e.g. mentioning which two devices you add support for). Right now your commit log would be empty.

Quoted 19 lines

diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio.c linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio.c

drivers/usb/serial/ftdi_sio.c +2 -0
@@ -192,6 +192,8 @@
 	{ USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_IOBOARD_PID) },
 	{ USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_MINI_IOBOARD_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_SPROG_II) },
+	{ USB_DEVICE(FTDI_VID, FTDI_TAGSYS_LP101_PID) },
+	{ USB_DEVICE(FTDI_VID, FTDI_TAGSYS_P200X_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_LENZ_LIUSB_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_XF_632_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_XF_634_PID) },

Only in linux-3.13.1+tagsys/drivers/usb/serial: ftdi_sio.c.orig
diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio_ids.h linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio_ids.h

drivers/usb/serial/ftdi_sio_ids.h line 368

Quoted 6 lines
drivers/usb/serial/ftdi_sio_ids.h +3 -0
@@ -363,6 +363,13 @@
 /* Sprog II (Andrew Crosland's SprogII DCC interface) */
 #define FTDI_SPROG_II		0xF0C8
 
+/*
+ * Tagsys RFID Readers
+ * survey (two of them) by Ulrich Hahn

No need to include the author in the comment. It will be apparent from the git log.

drivers/usb/serial/ftdi_sio_ids.h line 374

Quoted 6 lines
drivers/usb/serial/ftdi_sio_ids.h +4 -0
+ */
+#define FTDI_TAGSYS_LP101_PID	0xF0E9	/* Tagsys L-P101 RFID*/
+#define FTDI_TAGSYS_P200X_PID	0xF0EE	/* Tagsys Medio P200x RFID*/
+
 /* an infrared receiver for user access control with IR tags */
 #define FTDI_PIEGROUP_PID	0xF208	/* Product Id */

Thanks,
Johan